Re: [PATCH v6 2/5] dt-bindings: iio: adc: microchip,mcp3564: Add spi-device-addr

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The mcp3564 driver is not updated to parse the newly introduced generic `spi-device-addr` property, causing it to silently default to an incorrect address if device trees are updated to use the new property.
--

--- Patch [2]: [PATCH v6 2/5] dt-bindings: iio: adc: microchip,mcp3564: Add spi-device-addr ---
commit 63ce2b7ebde9aedefae19c7bc6bdc66fe833659e
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: adc: microchip,mcp3564: Add spi-device-addr

This commit adds the generic spi-device-addr property to the binding and
deprecates the existing vendor-specific microchip,hw-device-address property.

> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
> index 6753192761971..02bb198e9fa73 100644
> --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
[ ... ]
> @@ -91,6 +92,11 @@ properties:
>        clocking of the device address (BITS[7:6] - top two bits of COMMAND BYTE
>        which is first one on the wire).
>  
> +  spi-device-addr:
> +    maxItems: 1
> +    items:
> +      enum: [0, 1, 2, 3]
> +

[Severity: High]
Has the mcp3564 driver been updated to parse this new generic property?

If a device tree is updated to resolve the deprecation warning by replacing
microchip,hw-device-address with spi-device-addr, it looks like the driver
will fail to parse it and silently default to address 1:

drivers/iio/adc/mcp3564.c:mcp3564_config() {
    ...
    device_property_read_u32(dev, "microchip,hw-device-address", &tmp);
    ...
}

If a device uses address 0, 2, or 3, wouldn't this break SPI communication
with the ADC?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-ad5529r-driver-v6-0-cfdf8b9f5ee3@analog.com?part=2