From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4524C449ED6 for ; Wed, 15 Jul 2026 11:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116368; cv=none; b=uq0R5ns1/8AOHfnXHRu09IZneZjk9MTLNi5xjdJDwh3MObcDvLqzHGTCGuHPVKPAc83G+M1d4znjwJ/fbL5ad6I41o90axu7rvPgjU3d8ylktUqIZZ9gwtXHyTfQiEsUEUcmKUucvXfFiR8D52JX0RRl/IuqgPMnl9oAnuhIT8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784116368; c=relaxed/simple; bh=Thb61blW9JD4adfpev5hpA87KH3ldj9SOmcmA4e/D6c=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=gveMjadCkZhnpcOL+18b5dMYZ85d070Si7m8V5J64uX77avYuIwVNAkfjiBAg9pVUQXJdc9I5BEu/qrC6gjzPixicmysZI2U0VByaOIc9f2YQlzVdEOwDYBzAEEokdtcfK6+cqwY0hOaiVfFaRCN6FqIh9yWWBEeYH8zr8raumY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fa5eJh0G; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fa5eJh0G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A0271F00A3A; Wed, 15 Jul 2026 11:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784116366; bh=8WqZ8bb1F26TclUSKsQJWwuIFfBQNPQsGug8Bxh2k0U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fa5eJh0Gk0fbGSed649s/i4stEPtZd2Wbup2S168A0DOSD3zrywBKMsKCjvXI/0d8 soPqVT5UlO5n/Q7nJ6xaVsWm7YKiehf3TBlb/3e369sDYRb/gID3YaEOUk59xU9+0x aaoCE8f4SMgEnXGPwLLF27facOx91qMMp6MT/B4RWJtKy1Hizolp+tqFL7LyplkEnT Ilp9hnP3lJ9n5ViA5KRy0WanAhSJA2StsvFRX4+CAA5D68IasjBEkLGz+pAEDVTfSQ doCoC9HLsnXZMKn4lbeoK0O3SFMHjQuS8VqNxzrPWFacpZBkvhOxQl9ufjIokE0ynz Bx7CDJsYv+W1w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 3/6] phy: fsl-imx8mq-usb: add runtime PM support Reply-To: sashiko-reviews@lists.linux.dev To: "Xu Yang" Cc: neil.armstrong@linaro.org, imx@lists.linux.dev, linux-phy@lists.infradead.org, Frank.Li@kernel.org, olteanv@gmail.com, vkoul@kernel.org In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-3-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> <20260715-imx8mp-usb-phy-improvement-v6-3-00d95e270e4c@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Jul 2026 11:52:46 +0000 Message-Id: <20260715115246.7A0271F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] `PM_RUNTIME_ACQUIRE` falsely succeeds when runtime PM is disabled = (e.g., during system sleep), leading to a system hang when disabled hardwar= e registers are accessed. -- --- Patch [3]: [PATCH v6 3/6] phy: fsl-imx8mq-usb: add runtime PM support -= -- commit d85e441d52a7fee829fc860ee8795964a99e4555 Author: Xu Yang phy: fsl-imx8mq-usb: add runtime PM support This commit adds runtime PM support to ensure the PHY is properly powered and clocked during register access. It guards register accesses in PHY operations and Type-C orientation switching. > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/fre= escale/phy-fsl-imx8mq-usb.c > index 3a5788c609e1b..bc804d2b5aeeb 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c [ ... ] > @@ -136,17 +137,15 @@ static int tca_blk_typec_switch_set(struct typec_sw= itch_dev *sw, > { > struct imx8mq_usb_phy *imx_phy =3D typec_switch_get_drvdata(sw); > struct tca_blk *tca =3D imx_phy->tca; > - int ret; > =20 > if (tca->orientation =3D=3D orientation) > return 0; > =20 > - ret =3D clk_prepare_enable(imx_phy->clk); > - if (ret) > - return ret; > + PM_RUNTIME_ACQUIRE(&imx_phy->phy->dev, pm); > + if (PM_RUNTIME_ACQUIRE_ERR(&pm)) > + return -ENXIO; [Severity: High] Does this check falsely succeed when runtime PM is disabled, such as during system sleep? During system suspend, pm_runtime_force_suspend() disables runtime PM (disable_depth > 0) and turns off the PHY clocks. If a Type-C orientation change occurs via interrupt at this time, PM_RUNTIME_ACQUIRE (which wraps pm_runtime_get_active with RPM_TRANSPARENT) will return success despite the device being suspended. The driver would then proceed to tca_blk_orientation_set(), which accesses unclocked PHY registers, potentially causing a synchronous external abort or system hang. Could PM_RUNTIME_ACQUIRE_IF_ENABLED() be used here instead to safely check if the device is active and fail appropriately if runtime PM is disabled? > =20 > tca_blk_orientation_set(tca, orientation); > - clk_disable_unprepare(imx_phy->clk); > =20 > return 0; > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260715-imx8mp-usb= -phy-improvement-v6-0-00d95e270e4c@nxp.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F05DC44507 for ; Wed, 15 Jul 2026 11:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wapx8QUG+kN231ZQpboctl4kh2tz17piuSl1w3hYMiY=; b=3Mht0RTipLy/RF sq5t0ajl4LsTi9P1mHRE1OjCllKIYeiDbb2ARRLRStNOKGO9kcZTITP3tsXKJCIjA8lNb0L3wMe/m kPK8NFg7xgX7tCCsmF4ZKmdDamPvrUWEM88/aRUHwyL0xtHkC02Fn48j8R3r/Ezra8nmaEWzuM9kk slD5kJtyRLlKbumZ9JdLJxBOxt0HJrD22DcTg9OrbyS75K9BxHi7FCwcoL6QKoKOJ8KWf0QGxFU2G lSQhAFBNm/2lzZPApgj2B+ecPbEShYkniQ1hDVZ+L//Wgi7E288HG0r00ZyntgsD0TnhqY9TwnkBp TQ5P5A64uwyQB8CqkhEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjyAT-0000000Ee6k-0DLe; Wed, 15 Jul 2026 11:52:49 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjyAR-0000000Ee63-38lc for linux-phy@lists.infradead.org; Wed, 15 Jul 2026 11:52:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 3404A601C6; Wed, 15 Jul 2026 11:52:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A0271F00A3A; Wed, 15 Jul 2026 11:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784116366; bh=8WqZ8bb1F26TclUSKsQJWwuIFfBQNPQsGug8Bxh2k0U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fa5eJh0Gk0fbGSed649s/i4stEPtZd2Wbup2S168A0DOSD3zrywBKMsKCjvXI/0d8 soPqVT5UlO5n/Q7nJ6xaVsWm7YKiehf3TBlb/3e369sDYRb/gID3YaEOUk59xU9+0x aaoCE8f4SMgEnXGPwLLF27facOx91qMMp6MT/B4RWJtKy1Hizolp+tqFL7LyplkEnT Ilp9hnP3lJ9n5ViA5KRy0WanAhSJA2StsvFRX4+CAA5D68IasjBEkLGz+pAEDVTfSQ doCoC9HLsnXZMKn4lbeoK0O3SFMHjQuS8VqNxzrPWFacpZBkvhOxQl9ufjIokE0ynz Bx7CDJsYv+W1w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 3/6] phy: fsl-imx8mq-usb: add runtime PM support To: "Xu Yang" Cc: neil.armstrong@linaro.org, imx@lists.linux.dev, linux-phy@lists.infradead.org, Frank.Li@kernel.org, olteanv@gmail.com, vkoul@kernel.org In-Reply-To: <20260715-imx8mp-usb-phy-improvement-v6-3-00d95e270e4c@nxp.com> References: <20260715-imx8mp-usb-phy-improvement-v6-0-00d95e270e4c@nxp.com> <20260715-imx8mp-usb-phy-improvement-v6-3-00d95e270e4c@nxp.com> Date: Wed, 15 Jul 2026 11:52:46 +0000 Message-Id: <20260715115246.7A0271F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGBQTV9SVU5USU1FX0FD UVVJUkVgIGZhbHNlbHkgc3VjY2VlZHMgd2hlbiBydW50aW1lIFBNIGlzIGRpc2FibGVkIChlLmcu LCBkdXJpbmcgc3lzdGVtIHNsZWVwKSwgbGVhZGluZyB0byBhIHN5c3RlbSBoYW5nIHdoZW4gZGlz YWJsZWQgaGFyZHdhcmUgcmVnaXN0ZXJzIGFyZSBhY2Nlc3NlZC4KLS0KCi0tLSBQYXRjaCBbM106 IFtQQVRDSCB2NiAzLzZdIHBoeTogZnNsLWlteDhtcS11c2I6IGFkZCBydW50aW1lIFBNIHN1cHBv cnQgLS0tCmNvbW1pdCBkODVlNDQxZDUyYTdmZWU4MjlmYzg2MGVlODc5NTk2NGE5OWU0NTU1CkF1 dGhvcjogWHUgWWFuZyA8eHUueWFuZ18yQG54cC5jb20+CgpwaHk6IGZzbC1pbXg4bXEtdXNiOiBh ZGQgcnVudGltZSBQTSBzdXBwb3J0CgpUaGlzIGNvbW1pdCBhZGRzIHJ1bnRpbWUgUE0gc3VwcG9y dCB0byBlbnN1cmUgdGhlIFBIWSBpcyBwcm9wZXJseSBwb3dlcmVkCmFuZCBjbG9ja2VkIGR1cmlu ZyByZWdpc3RlciBhY2Nlc3MuIEl0IGd1YXJkcyByZWdpc3RlciBhY2Nlc3NlcyBpbiBQSFkKb3Bl cmF0aW9ucyBhbmQgVHlwZS1DIG9yaWVudGF0aW9uIHN3aXRjaGluZy4KCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGh5L2ZyZWVzY2FsZS9waHktZnNsLWlteDhtcS11c2IuYyBiL2RyaXZlcnMvcGh5 L2ZyZWVzY2FsZS9waHktZnNsLWlteDhtcS11c2IuYwo+IGluZGV4IDNhNTc4OGM2MDllMWIuLmJj ODA0ZDJiNWFlZWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wt aW14OG1xLXVzYi5jCj4gKysrIGIvZHJpdmVycy9waHkvZnJlZXNjYWxlL3BoeS1mc2wtaW14OG1x LXVzYi5jCgpbIC4uLiBdCgo+IEBAIC0xMzYsMTcgKzEzNywxNSBAQCBzdGF0aWMgaW50IHRjYV9i bGtfdHlwZWNfc3dpdGNoX3NldChzdHJ1Y3QgdHlwZWNfc3dpdGNoX2RldiAqc3csCj4gIHsKPiAg CXN0cnVjdCBpbXg4bXFfdXNiX3BoeSAqaW14X3BoeSA9IHR5cGVjX3N3aXRjaF9nZXRfZHJ2ZGF0 YShzdyk7Cj4gIAlzdHJ1Y3QgdGNhX2JsayAqdGNhID0gaW14X3BoeS0+dGNhOwo+IC0JaW50IHJl dDsKPiAgCj4gIAlpZiAodGNhLT5vcmllbnRhdGlvbiA9PSBvcmllbnRhdGlvbikKPiAgCQlyZXR1 cm4gMDsKPiAgCj4gLQlyZXQgPSBjbGtfcHJlcGFyZV9lbmFibGUoaW14X3BoeS0+Y2xrKTsKPiAt CWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCVBNX1JVTlRJTUVfQUNRVUlSRSgmaW14X3Bo eS0+cGh5LT5kZXYsIHBtKTsKPiArCWlmIChQTV9SVU5USU1FX0FDUVVJUkVfRVJSKCZwbSkpCj4g KwkJcmV0dXJuIC1FTlhJTzsKCltTZXZlcml0eTogSGlnaF0KRG9lcyB0aGlzIGNoZWNrIGZhbHNl bHkgc3VjY2VlZCB3aGVuIHJ1bnRpbWUgUE0gaXMgZGlzYWJsZWQsIHN1Y2ggYXMgZHVyaW5nCnN5 c3RlbSBzbGVlcD8KCkR1cmluZyBzeXN0ZW0gc3VzcGVuZCwgcG1fcnVudGltZV9mb3JjZV9zdXNw ZW5kKCkgZGlzYWJsZXMgcnVudGltZSBQTQooZGlzYWJsZV9kZXB0aCA+IDApIGFuZCB0dXJucyBv ZmYgdGhlIFBIWSBjbG9ja3MuIElmIGEgVHlwZS1DIG9yaWVudGF0aW9uCmNoYW5nZSBvY2N1cnMg dmlhIGludGVycnVwdCBhdCB0aGlzIHRpbWUsIFBNX1JVTlRJTUVfQUNRVUlSRSAod2hpY2ggd3Jh cHMKcG1fcnVudGltZV9nZXRfYWN0aXZlIHdpdGggUlBNX1RSQU5TUEFSRU5UKSB3aWxsIHJldHVy biBzdWNjZXNzIGRlc3BpdGUgdGhlCmRldmljZSBiZWluZyBzdXNwZW5kZWQuCgpUaGUgZHJpdmVy IHdvdWxkIHRoZW4gcHJvY2VlZCB0byB0Y2FfYmxrX29yaWVudGF0aW9uX3NldCgpLCB3aGljaCBh Y2Nlc3Nlcwp1bmNsb2NrZWQgUEhZIHJlZ2lzdGVycywgcG90ZW50aWFsbHkgY2F1c2luZyBhIHN5 bmNocm9ub3VzIGV4dGVybmFsIGFib3J0IG9yCnN5c3RlbSBoYW5nLgoKQ291bGQgUE1fUlVOVElN RV9BQ1FVSVJFX0lGX0VOQUJMRUQoKSBiZSB1c2VkIGhlcmUgaW5zdGVhZCB0byBzYWZlbHkgY2hl Y2sKaWYgdGhlIGRldmljZSBpcyBhY3RpdmUgYW5kIGZhaWwgYXBwcm9wcmlhdGVseSBpZiBydW50 aW1lIFBNIGlzIGRpc2FibGVkPwoKPiAgCj4gIAl0Y2FfYmxrX29yaWVudGF0aW9uX3NldCh0Y2Es IG9yaWVudGF0aW9uKTsKPiAtCWNsa19kaXNhYmxlX3VucHJlcGFyZShpbXhfcGh5LT5jbGspOwo+ ICAKPiAgCXJldHVybiAwOwo+ICB9CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9z YXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzE1LWlteDhtcC11c2ItcGh5LWltcHJvdmVtZW50 LXY2LTAtMDBkOTVlMjcwZTRjQG54cC5jb20/cGFydD0zCgotLSAKbGludXgtcGh5IG1haWxpbmcg bGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK