Re: [PATCH v4 13/21] media: imx355: Use pm_runtime autosuspend_delay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Unconditional assignment of the imx355_pm_ops structure causes dead code when CONFIG_PM is disabled.
--

--- Patch [13]: [PATCH v4 13/21] media: imx355: Use pm_runtime autosuspend_delay ---
commit 6f6f1ba748842249c2565926292b231a564e183f
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Use pm_runtime autosuspend_delay
    
Avoid powering the sensor up and down unnecessarily by using
pm_runtime's autosuspend_delay feature.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 120eda46d9820..17a2acc1152df 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c

[ ... ]

> @@ -1436,6 +1436,8 @@ static int imx355_probe(struct i2c_client *client)
>  	 */
>  	pm_runtime_set_active(imx355->dev);
>  	pm_runtime_enable(imx355->dev);
> +	pm_runtime_set_autosuspend_delay(imx355->dev, 1000);
> +	pm_runtime_use_autosuspend(imx355->dev);

[ ... ]

>  static struct i2c_driver imx355_i2c_driver = {
>  	.driver = {
>  		.name = "imx355",
>  		.acpi_match_table = ACPI_PTR(imx355_acpi_ids),
>  		.of_match_table = imx355_match_table,
>  		.pm = &imx355_pm_ops,

[Severity: Low]
This is a pre-existing issue, but shouldn't this PM operations assignment
be wrapped?

When CONFIG_PM is disabled, unconditionally assigning imx355_pm_ops causes
the structure and its callbacks to be linked into the kernel despite never
being used. Would it be better to wrap this with pm_ptr(&imx355_pm_ops) to
eliminate the dead code?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-media-imx355-v4-0-f7f966fb9ffd@raspberrypi.com?part=13