From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7099944683F for ; Wed, 15 Jul 2026 12:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119830; cv=none; b=ICS6d82bdwVk9xr9XzJoyCZBg/w5FuAdpPiC5X/xaLd8gvBUMrAX2HEHxWZIY7I5aaeVTSVY1ZBVHZD44Rc7+UGKf4btbMLSnGhaLHRiY43QuPzu/rWZXF1064vzdkqYqasCMEU/ewSAPr/Vtf15S0mwRw+iolRBNdKl5CiTJEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119830; c=relaxed/simple; bh=O4GCA9dncFpjvEFsosHxcw7KoGXzfJdJTyHWVOQIRVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YuyN4vxFoZGDnvkkFrnlYsptUpjX8sAbLwVTkdrZVWgPkB0bq/RA8tGDLn4k3HgJ4NEI67GUzFDReFVwAyc1GxQpd6DChP7dc0eu30T9gnk0Zy/SeXQXWAImOwbLOFOjn9/f3lyI3AhGlAluYTXAFfotGcMsKI6w0p4jtRn59q4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C/gSZhe6; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C/gSZhe6" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aec139da7eso2068553e87.1 for ; Wed, 15 Jul 2026 05:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119826; x=1784724626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1azHGGJy3K9uDsx0DgVKa5M1cFQOMhZnbWAiiL9xWBM=; b=C/gSZhe6fGr65TVNguQA7cS/kuOJuaNsjp04dYbu8JPyNvmXJzpvnsCfqzzqQSJuLp nwAJnUcRMFBMoSee0gWhRLtmMvLnSb71+u/pBbFeYVhc9fc81EH3HYSSPbkF6WQE7UJO 0QmK4gsKmrpiNmLIUXc/DkAQszCD3Ut2c0lzcygySsyeHMT86yqWEvquJ/fpPmmzZy6Z sVMBHFmezhA3mg2ZsOaQzi4+XfLmhiqIxB5RV2CvFoZCIJ/seYUJf5rNgqWlXsbR2/H4 4sDPAvZFaF2WD2HjH5erFw2MUni4XV1pIveSWQ2PKA73MDZKKcsTettaKpcTeRr4anV+ pdpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119826; x=1784724626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1azHGGJy3K9uDsx0DgVKa5M1cFQOMhZnbWAiiL9xWBM=; b=hWg9ov8t+9oiqWIVeX+eW+e6xkiap9zdQPsNtnQMbAuhbqGk+Sq2/O/HsxF2CaCkoW eXB2ikjg9QBXnLDtYUEdkpvElKHIKLSzbSrtQPWp+YdN4Z0m5zZ9E9p13wVNWVSUjjhF StaoRbxyLZ6t/+ld2RS8yMBSSlDz0BXsRtrxnp3Axge9dws832OguEu1IQmbzkJCGhF/ 4RZvMW9xYNLlqNh74Y/iLbnnsQEuH9z7EhxlAW3SlKvEuGVWvHNE4vZZPo9Bk4pbKFtB 9BmnHj/4scPu3xxJ92mb85jDhqr5kokzE6sPYTT2nsPsieLK4mrPLocfys9LFqMOqiR4 j3+A== X-Forwarded-Encrypted: i=1; AHgh+RpPRKQaHAwnDnag9w1v6Cpa6eeg3/gADensg1+uVOF5RDteDOxpt0hfFgzcqAdM8+Ywk4ePTOPgpxxN9Vs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo+/Tap/MbOchSrBO2S5YrgDDS46vSIoAovLnxpx3bvqqASJjM 7R9g1NvBO9lVZwnq7v9w92fQcib2qYX07bUIFjvw8LywzXLrSQ49GhNwWDaVjLkGk/U= X-Gm-Gg: AfdE7cmqykAXM3tisTTzG1q4FyTwlU80xmGs76GEVG95tW/x0P50n4GM6JPXetcObm0 S0bmyUGOODJkk0PizA4lsxZr7bl1V3aPxzjP9Nh95dsqGS986Q6XcghEb/+jlWJBZWUHUr+YBNw PwclnCpZPlR4MP4KzuEGMiHl0R8NkCHPT1SZLTAKs4iGYIQhHPM5MZkHcMVIZJfNEbEYLkcGUqG YVcNvCBDdW98Vu3wtUcRaqV8gyOqiegKB+HxFb94whyWnTaJi1B+2Q3d+r2shJWQv3yZgrYmzWZ 9y6L/EKTqdMstaWEm2MsQnNxYpMMK/VaPB2RQZn73zCJ4i/RSYUWeJJR/c0fdmaLusq5EWA0/G1 m0hRPkT3oJa7m6F/gc7Y8y6UCocmkSPdUTwOV+tKzQDf6/3ZUDwQBb/lBNIlkxIsb1hG5f18vwW 97ijHHRT/IsrVjZuRvLbBchar9K84IqMS8jJy34c1GdrT2U2K0XJtQgEsBaSZ+mU9FxaWLboK4R 6wCWfxUdQ92Cg== X-Received: by 2002:a05:6512:3182:b0:5b0:227d:cef9 with SMTP id 2adb3069b0e04-5b0227dd3ddmr4759402e87.3.1784119826203; Wed, 15 Jul 2026 05:50:26 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:25 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 14/61] staging: rtl8723bs: remove ODM_CheckPowerStatus and dead branches Date: Wed, 15 Jul 2026 19:47:42 +0700 Message-ID: <20260715124829.90290-15-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Delete the dummy ODM_CheckPowerStatus function from HalPhyRf_8723B.c, which always unconditionally returned true. Since all of its call sites across the driver checked for the negative condition (!ODM_CheckPowerStatus), the corresponding if blocks were unreachable and never executed. Clean up the codebase by removing both the obsolete function itself and these dead conditional branches to reduce code bloat. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c index 70b68f473..b77598287 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -1077,10 +1077,6 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) } } -static bool ODM_CheckPowerStatus(struct adapter *Adapter) -{ - return true; -} static void _PHY_SaveADDARegisters8723B( struct adapter *padapter, @@ -1093,8 +1089,6 @@ static void _PHY_SaveADDARegisters8723B( struct hal_com_data *pHalData = GET_HAL_DATA(padapter); struct dm_odm_t *pDM_Odm = &pHalData->odmpriv; - if (!ODM_CheckPowerStatus(padapter)) - return; for (i = 0 ; i < RegisterNum ; i++) { ADDABackup[i] = PHY_QueryBBReg(pDM_Odm->Adapter, ADDAReg[i], bMaskDWord); @@ -1556,8 +1550,6 @@ void PHY_IQCalibrate_8723B( /* u32 Path_SEL_BB = 0; */ u32 GNT_BT_default; - if (!ODM_CheckPowerStatus(padapter)) - return; if (!(pDM_Odm->SupportAbility & ODM_RF_CALIBRATION)) return; -- 2.55.0