From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D720847F2C8 for ; Wed, 15 Jul 2026 12:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119834; cv=none; b=bxe0/cfdWWV+SEVGf9eSaQx8MANELM1mj5LoLk+xZSJsTXq75ttZJZhpHR6V8GcKalUNC9Py4RINm4eJBgWRDqfCwPoLX00PLxCW3TyZ3tQPwDGFYauPazydxTBHKZIqX+vLswoJvD5hD+RPlP+K7CW76dx1+VB4/QqrtcMLrA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119834; c=relaxed/simple; bh=LDjnU8wWcc8WVujOeS2iCrdBFq4t8S0oQujwBbiTOO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=urukfAQpFUgXbAj1pESY+SiPWc0RTyDTx2wEhWs7VgA7mnwN8mM6vJ/47golXwZQuqthsXO8usdkGhs7jFsPLA5a0h3U6ukWzctnXIP2Nnu+vFwzojEcdcC2CjrJrPAL/ouHMhmv664RFtzl6JMp2YPkXqfl/Tx3q2fJS4XQa4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PBbOT8zP; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PBbOT8zP" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5b0231a3e86so4633172e87.0 for ; Wed, 15 Jul 2026 05:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119830; x=1784724630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ml0TaZ73hFYK/wxsUsTYoqomxGiJC157MiXEoyPfmO8=; b=PBbOT8zPr+WMifa2prwm5FU3DL30D7I3/hKZiaeb/TVjGMoAmLkzZiQZLfO6RJ7ZU1 uaIklaespk/8dJqEbECFwcT3vlOzWJYWTtI0D2Rmwr2leXNtVYwTB7UKjdjWu+hlwF1w khbCJ0Y8E/WW+aovekfBJHbNpZ5Qq+gpJKuBxqLFsBts80STvorqRJ9b8a6Y5EHciIev CAdUBU0rkjkoC2eIrXbGFNn+W+Kb3N/3YyNW9nA7+Z082lj7ZAOJbgoPlMkXqnduOP0Y EMce4tHqykRneCAmBMu4h3WnaRt7fcjqEYiY6OS+/Ry8Zrhk7aLuA2msMMx1KVpE64nA KfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119830; x=1784724630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ml0TaZ73hFYK/wxsUsTYoqomxGiJC157MiXEoyPfmO8=; b=jVYb4lom3+WLGosoL68jU4cyN8nSeF6ibOsyEg6J8xw/o04qXCFw0+IVhHS+9y0VO+ 2MFTRqMIjf2b26rLCmDM8fFXujTImtmqdDqVXY3vh6wsFF10wvPfyE+H0DT53mNGepZ0 HQeLbizPQl+hRkYSmvIp2UpnnMFKQqc3LSZ8AJb83FaloF0zdnZKz+JHrF3BjjlW0jU+ IBrjj02bpkwluJGNqk4CqQ/XzO2FAjxRgmLc9+JvruRcalN/UvYjYW4qHd+V3cg93hpw lsk11ss22oeILpFtpuammfRbQGLf7YCwiQ/iXFqizAUYBTZSWnaGNexYBdryOAl3pbzO a7WQ== X-Forwarded-Encrypted: i=1; AHgh+Rqd2g/w3xsuYvn5hKuf4ITFx7DAZhQeTTes0StbMIcSejc+kFt5tuVrP8uOj4oxhpGU+VSMuHS0Bht2G0g=@vger.kernel.org X-Gm-Message-State: AOJu0Yynpb3klTayWz612DNy3XWBaVLLfyF2YCXhJL96f+6YLEZbZKL1 ep+GSzSuuiCS05NLzOgkcThsy/oqQkl+6klO80pI0WWRIqaDXVBHm+t/ X-Gm-Gg: AfdE7cmSK9aVKyPoeDsvxjLXsHijRsAJAqOw0zwMacotISUhCWl4wu0xw6c2XhF4h8Z aGWCLpFlS/iIyehy0AUuk8V6QcguAmymO4Pev+/JjEd4lnOgfST3/Af0M7tbWylLjL2b4BdxqKl 0dXLtoi0q0UDpPP3AtDHjjpxcgnCMnu3zIWzAyVe8zo6Qn5bJ2zp5HKjqSOpUVOGKK43ioA43Kt 5FZweBNvcuzyQzcdIxkY6YYSi6eu1cB9oZ8Xs6sKZT1XO3pLUFTTWwP2Xz+EFFmwQluhbhy18qR RFcwUbGWq7A28++s4Bhr66ZpfYmK/OWACq6hMy9bpwkjK0aJAImyCPiCS1N3wZKDj/QXWKVSaL3 7qgVVjvmTdEfYlXrzmLfC7BUM5V1w+m+dMjIbbDkEyKdNUuEQkRCNraS5ezv87EozD98wzoNCQi dBIHq9K04aeKMkB8lGxxYOhSVF8rQLa6T0Fj0PiMoKkfA9ozzxyYGykcQ/PNCUdkNSqHHIoL87M ilIRs1kzIdUyg== X-Received: by 2002:a05:6512:8388:b0:5b0:1760:fabe with SMTP id 2adb3069b0e04-5b15d7766e5mr418334e87.15.1784119829423; Wed, 15 Jul 2026 05:50:29 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:29 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 18/61] staging: rtl8723bs: replace rtw_dm_in_lps_hdl with direct hal call Date: Wed, 15 Jul 2026 19:47:46 +0700 Message-ID: <20260715124829.90290-19-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant rtw_dm_in_lps_hdl() wrapper function from rtw_cmd.c and replace its call sites with direct calls to rtw_hal_set_hwreg(). The wrapper provided no additional abstraction or logic, serving only to pass fixed parameters (HW_VAR_DM_IN_LPS, NULL) to the underlying HAL function. Removing it eliminates unnecessary overhead and cleans up the driver interface. Clean up the function definition, remove its prototype from the header file, and update all invocations across the driver. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index 02b7d24c3..88ac64a6b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1354,10 +1354,6 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue) return res; } -static void rtw_dm_in_lps_hdl(struct adapter *padapter) -{ - rtw_hal_set_hwreg(padapter, HW_VAR_DM_IN_LPS, NULL); -} u8 rtw_dm_in_lps_wk_cmd(struct adapter *padapter) { @@ -1753,7 +1749,7 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf) lps_ctrl_wk_hdl(padapter, (u8)pdrvextra_cmd->type); break; case DM_IN_LPS_WK_CID: - rtw_dm_in_lps_hdl(padapter); + rtw_hal_set_hwreg(padapter, HW_VAR_DM_IN_LPS, NULL); break; case LPS_CHANGE_DTIM_CID: rtw_lps_change_dtim_hdl(padapter, (u8)pdrvextra_cmd->type); -- 2.55.0