From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0800481647 for ; Wed, 15 Jul 2026 12:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119841; cv=none; b=C0sBr1AI1pdtcn6WvqLtQX9mipoGUxDpFBFWKJpZflsJsKAGCq3PSyko0VfFwnwcUZybUSgXzvp2HVASfDsY5yJ9IKpdMZaneAG1ZG8ZDgjYNwkPIxWqAfzMz2QT7796UEKTopFpVEs9Xk2qarQBhkQLjg/Xu+epbs3gwk+7oeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119841; c=relaxed/simple; bh=6FEsm9xy2/G5ePTRB9/G5MfuZCJpfgDFjyq6xDkTXBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=abCgK03oIpliQXld7tGPVVuCLHWgveszILjoF8D6j/B3cp4buZYb1LkDGx6/XVNG7Z/0rvBFtKz++cYyZHui4t6rrnBifEZkzJOoQ2nS3WNCQgwpwzWGV/uupTUa6XDAbiBH9yv3rIFBlX61MYZvDO+N9H+GtK4aS0vImLjJJbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cFVQntBz; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cFVQntBz" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5aebd52488cso5790848e87.2 for ; Wed, 15 Jul 2026 05:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119835; x=1784724635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R4T+BgF6vFyikfScyBULJ8vIlQDG1v6/afOfd/dpITo=; b=cFVQntBzhWuOFZwOIIRGivFsNbHdb9BO3D1NKgrLsa5FGyRn6yHb11M0SL5EE/NBCj KVTmaU+yCtjLAcDsD6wv4NVFnSBC9bIAeS7BLhcwTFGmxBg28dLsMNQsBk5j/VEhA9zs L9LAxVuCG4GKTVSv1k3AStDX35fnxLuqsCcBQFn7tG+kh2MgcQu5t1Ij0zg6bIDgEQD+ pg3VZ7HLt7Q1BwDRImuaA0XsZl7KFgoT3LvuNK04lgYpb+LETvIjcw0V5u6ZFEDxlKEs pwgtj19ntU0IzISUDCLeUOHzf6H8ea2CGr4DwGOoiuolvUfoElbkxFGP5deMjjNQ9HMw 25Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119835; x=1784724635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=R4T+BgF6vFyikfScyBULJ8vIlQDG1v6/afOfd/dpITo=; b=WR5FiKDh946XnQ/B65WJh2wReJkOsdEmTQi/N5K22cJ9QJ5XA7Ov+xalqxMzeYgcAD lUloCEE/iT9zUOylIEvdYLl4kecbVMCly0sx7i/rO3bW3vORA0SgMnAGBO5qjbvvz8yp GaZoQHOsApd3S2jYlV+/+aJJm4X/BTvxEBVXZf/A2pEbyS1jts4Wq52F+PaZJTImaUr8 GibsEuvnksCQ+tLdDdCrZT76jVI90KSd5+GfWgSa/3+pOXMZn4ca2FJp0KXMrhOrO0WY YYoaPSXYtAYR7jnuAhfRWrQvXlxO3Sp+f9LgDLKPPh0RpB1oTBoz/xIfr7cmgHbZfNcG uYrQ== X-Forwarded-Encrypted: i=1; AHgh+RpneLz0TCJZWwqigKdy2YqX6KTr0Iyakr93OTCHWizQos8BQp8EUU+kAU4DP3kOcueWwiXzfxzXSt0V3Sc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo64qpVmC1exYkdlo1MPbTrmJnXU2WDLeRJ5yZeBtPMHBuaRRJ zX3gQcEFrJ49ggMSHRh61NlNdQq5SywccQ+6YPUqYaOsVC3vH/ja5MEk X-Gm-Gg: AfdE7cnqeLiE+uxDf8OZlWesTg77ypE2If9fgNbCN4D8Wuh511i5yvBiOD2+svRZySY WrmJDpWMdZfsaX1igWOHXWnaLd9PuvReUCFAEzlEn/MiwEkA5ko9PoX45P3ed8HnwPToBk4D2mq DLoWjBaguoeQutHD+7TEMu3g9hy+yNImm6NPKEMtt5f4y+ZztYkUdGJxYcYPvRUmPtMLMcWjEbx F6FD/qTSHRybTHPfKJ8u/UJzKNgAW8PKoaoncXxtgTvDIphbwgppibXoVz9FzrsQXKDQOJDMqOO K4TgZzPH4fEPYAwFg3WntGFOq46HFeZNSTb0mxwpjRpy4n0Ucdh17YuO0w9oFEx/mrZ1fUz8lTq nCNjGQGIju9hlvRJYkrpJCENt4HPMYhtQmQ2gMqEj5youneOjSK/xNeSiTRahLgb7OK+vooJzwZ wVYuYeFSH/9xcd9dvziqV93I2j6lVNoLOyzvoVABn9H8G895m4Zc65yNeKli5Nc0JMXMl6HuiC2 1pxszgwgBmdEQ== X-Received: by 2002:a05:6512:3514:b0:5b0:11e5:6bd5 with SMTP id 2adb3069b0e04-5b15d7a945cmr628452e87.40.1784119834393; Wed, 15 Jul 2026 05:50:34 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:34 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 24/61] staging: rtl8723bs: remove register_task_alive inline helper Date: Wed, 15 Jul 2026 19:47:52 +0700 Message-ID: <20260715124829.90290-25-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant static inline helper register_task_alive() from the power control management code. The function provides no additional logic, validation, or locking, acting merely as a wrapper around a standard bitwise OR operation on the pwrctrl->alives bitmap. Replacing it with a direct expression simplifies the driver's power interface. Clean up the inline definition and update all its call sites across the codebase to manipulate pwrctrl->alives directly. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index 1d6fe3734..c52988cfc 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -667,11 +667,6 @@ static void pwr_rpwm_timeout_handler(struct timer_list *t) _set_workitem(&pwrpriv->rpwmtimeoutwi); } -static inline void register_task_alive(struct pwrctrl_priv *pwrctrl, u32 tag) -{ - pwrctrl->alives |= tag; -} - static inline void unregister_task_alive(struct pwrctrl_priv *pwrctrl, u32 tag) { pwrctrl->alives &= ~tag; @@ -704,7 +699,7 @@ s32 rtw_register_task_alive(struct adapter *padapter, u32 task) mutex_lock(&pwrctrl->lock); - register_task_alive(pwrctrl, task); + pwrctrl->alives |= task; if (pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm < pslv) { @@ -789,7 +784,7 @@ s32 rtw_register_tx_alive(struct adapter *padapter) mutex_lock(&pwrctrl->lock); - register_task_alive(pwrctrl, XMIT_ALIVE); + pwrctrl->alives |= XMIT_ALIVE; if (pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm < pslv) { @@ -834,7 +829,7 @@ s32 rtw_register_cmd_alive(struct adapter *padapter) mutex_lock(&pwrctrl->lock); - register_task_alive(pwrctrl, CMD_ALIVE); + pwrctrl->alives |= CMD_ALIVE; if (pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm < pslv) { -- 2.55.0