From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FADC47B410 for ; Wed, 15 Jul 2026 12:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119844; cv=none; b=VwTRVLXR2z0zgVEcx3UsfAOtj7IiGUxNLohnT+x3XPfuWRLlFdk4dvrs8IYZwvNje4BF0RwucfAAYYdUDcq0YPxfiqTQy6Ray0SopTMWiwgFzu2jKMJMgTbzSiIahoRbuDTi4KoBBiOVc4WTcFnEhitudg8zTsefRXhXl10ysCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119844; c=relaxed/simple; bh=tRipzmLpOCevwuknURNOpBvPuJZmD+gFPvi10SppIGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CKLXx8kNg1oTa1p1Nsx8tV4s806WOKJ+GXO6fUkf0U5IKkXujcmEV0cEflUsn3YH7aid7yFNmSwFXH0S/bWLYK1EXcxTGz6HNsSiDh2xWsg2N0XDLkQq50xfLk3qfvk6B0gffv8EzQPmMg4zw9hX8XUcVmXSlHhanLDCbWd3MGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tDwR9eSU; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tDwR9eSU" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5aea9d606f0so5627468e87.3 for ; Wed, 15 Jul 2026 05:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119835; x=1784724635; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IfjYa8DESgLZHi2LJ4dhLFuZRUwHsIA52JsmeA7NWRU=; b=tDwR9eSUhOcTHyzmqyIs9cZOft091HyUW2n2ybdnVPs889YPtglw7DvxJ3/QiWbjY9 nzNKWHFbPgX4UHYXrMNr2mFZcq0/+JmfCwr+DmaX6yIQSTZStNc2VOEIM6Dx/qq61Hbq XwwJnVbrZckSZs+nxKfa7CWl+WV+eN9Q7L2kknu6vFciDKHxhoIody1AT8Ix30ae1S7o c8RrEEMbzR+5AtSY+6luhJOv2CDhunL0Ykg1cVVRTGjov5R2L3XVamFPqnNNtSObG/F1 +bJ6q/VAddispA+42/nINKKM8eBel81qreALy4CYG/VuuzzGN5Av55XyT0QclL8YKtK5 FV7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119835; x=1784724635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IfjYa8DESgLZHi2LJ4dhLFuZRUwHsIA52JsmeA7NWRU=; b=lMTrq2vA3+ECVNeRenjY70Ee1CLXQLEWBJR/HSmNiEFYGLsU0ekPiw0FRtNt+ttofv WtY9RTuGHdgYL4LyMXy2BjAAqff2oKxUtyjGt3lR5QndsST8z0HX7iEd150QDsTx5usj BklypLc4E+wKuwRnE35gAu6d3nLgCjpv/OMlz0SRdpobQmZuXOcML6T4wirRnCmYR92Q 6PUjltfOQuQTB6MjNPTacP58tv75Px//MFCirobxVJeWGEpTu3l0e/Du+ZeSgBezB0eS 1ROl7miDmeMvQFAEJPsxORxoiG43J9W+81gBiBAfrqjS0rPcrVvkv4Q5hrpMfuWssJnE 0mmA== X-Forwarded-Encrypted: i=1; AHgh+RpTKmuU34uQdW8wA7rv2u23X03Gsx5lyf0uLEUSmw5L9mY+bpo/t7NWuAv9ZSBZlQNlRyGHNt19iJw/Nc4=@vger.kernel.org X-Gm-Message-State: AOJu0YzqdAzu2Vog+4agT3XzXknFUNmTJfC2C6UqouO7LcxBw80UEID/ d0Zep1eJhilJU+DFCRj6OMkGhg/PCSAsJAmlESOGN1O1s/LF5M76e8cU X-Gm-Gg: AfdE7cnXb82c9bhukEGv60TJnwAEqgYj2rg41CdVUClySbSPHgUYn9uCn6s+YRjEWWw ldOmYrc3X0zdIgKwvIeoaD4aRHJY2DFL5PhHrbqgkCjr8IONNn9FkaPCAIfynhdIAalXJVKpNPU 3qiAlcNIXlvMNyBjWxpkGcHMShf5URZPe9bHbzqhnXLOKHVJe9nziGmyS2NUkTsCI4pdYXxtpm2 +FAOkm4Jk7FXTqQTW9Xf6ht6KWJznu551xSCKygNgmApHECMosy7KfXNHLnsYPfJi643l1/X2NI +t2DhxDPMtzbsVyGRuD5VQqMHlp+VU40ONqbTbqLQzPcnjJsOIemfYhevzaipwilsm7kHnIJM9I RcXDF9t+XNy1u2+E6c6fmt/HFlHpIWfl6v6Cw7ZoHTOjkPREhEfjs6qDcFigc8UPAW05ayM/QQ7 zjbhKSs9cN1Dzb22v+q+xc+qB2gYheueCmthXfXaBR3cPuFXGVlmYPXZLiPyrOcJxm+HENUKneD coMOUZRKL20GA== X-Received: by 2002:a05:6512:66da:b0:5aa:6f0e:8404 with SMTP id 2adb3069b0e04-5b15d782523mr462324e87.21.1784119835167; Wed, 15 Jul 2026 05:50:35 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:34 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 25/61] staging: rtl8723bs: remove unregister_task_alive inline helper Date: Wed, 15 Jul 2026 19:47:53 +0700 Message-ID: <20260715124829.90290-26-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant static inline helper unregister_task_alive() from the power control management code. The function provides no additional logic, validation, or locking, acting merely as a wrapper around a standard bitwise AND-NOT operation on the pwrctrl->alives bitmap. Replacing it with a direct expression simplifies the driver's power interface. Clean up the inline definition and update all its call sites across the codebase to manipulate pwrctrl->alives directly. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index c52988cfc..a15f3ee9b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -667,11 +667,6 @@ static void pwr_rpwm_timeout_handler(struct timer_list *t) _set_workitem(&pwrpriv->rpwmtimeoutwi); } -static inline void unregister_task_alive(struct pwrctrl_priv *pwrctrl, u32 tag) -{ - pwrctrl->alives &= ~tag; -} - /* * Description: *Check if the fw_pwrstate is okay for I/O. @@ -747,7 +742,7 @@ void rtw_unregister_task_alive(struct adapter *padapter, u32 task) mutex_lock(&pwrctrl->lock); - unregister_task_alive(pwrctrl, task); + pwrctrl->alives &= task; if ((pwrctrl->pwr_mode != PS_MODE_ACTIVE) && pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm > pslv) { @@ -874,7 +869,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter) mutex_lock(&pwrctrl->lock); - unregister_task_alive(pwrctrl, XMIT_ALIVE); + pwrctrl->alives &= XMIT_ALIVE; if ((pwrctrl->pwr_mode != PS_MODE_ACTIVE) && pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm > pslv) @@ -910,7 +905,7 @@ void rtw_unregister_cmd_alive(struct adapter *padapter) mutex_lock(&pwrctrl->lock); - unregister_task_alive(pwrctrl, CMD_ALIVE); + pwrctrl->alives &= CMD_ALIVE; if ((pwrctrl->pwr_mode != PS_MODE_ACTIVE) && pwrctrl->fw_current_in_ps_mode) { if (pwrctrl->cpwm > pslv) { -- 2.55.0