From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 006F847ECFA for ; Wed, 15 Jul 2026 12:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119846; cv=none; b=hL0aZ7EGTFCB83u4uT5aQF372UuLqJw9Sg60U4bLJhf9wjRBCGueaeV2LddvZnnAFUz9M5CCu2E5w74YH738Fk5AkxEoZrCjEA//HgL9Rz+NBbU5PB7i0mO8zJN62A/36P17hGZ8vrYOV6G7txb4FuL/sG/Dj6KF6dGwFrG2n4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119846; c=relaxed/simple; bh=zZXAo8npoDzLKVKKYOc0BU24XqQ2NLcE3VqH4JNn+WI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S9JArr5RJITNU+tHjG23Ns8s3nOSjrUMHFABzua4o1cjiJBjQBb/sdm5PF2t8b5x45bU1aV9HlGsSBKmFt4dqR5S/isPJ7Gqnc7TwL6rhmJ6OUtrD3r1w2R47PurvLQ3BdYjVdsHVTiiXJ0G7IJtbBIYNWj2536I0qCOVCVPK7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CLiQsYAP; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CLiQsYAP" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-39c7fd45465so44856661fa.1 for ; Wed, 15 Jul 2026 05:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119839; x=1784724639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XDOCH3L6xBsyr24MyXHVgIBAtfoXRa0Y/GN8N+RqAIw=; b=CLiQsYAP5iRtr1SjQnxM04UzJQobSgRZMMFl44a8o6+iBHRDXt4J55ZPsIR0zi2pR3 6Nqlu8UuN0sDXhnl08CFFEDMEHXNCgJuFUlDg6UeUaCHfAG3szDIdk8RvZ3jigKuF4vy agtxe9HRwpAMDX+85uCR+WSle6RmtGAfKodbarjFOC4B3HqnSr+lT7mwIL3gK4VAT1BD dK+DsgarLp8SGfOcs6fKRqtaa9sxi7KszyMNUp+LHT0UMCNZ+qKqi0HjqsQ+oWH5Rb4B 3FK6raPZsVoxoXDn96dNVoRBIPl+ZiXmHnylah9hoBd+tcsgnbUqSzibz65Sv5GQzaX1 OvhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119839; x=1784724639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XDOCH3L6xBsyr24MyXHVgIBAtfoXRa0Y/GN8N+RqAIw=; b=s8vohtOAAuQNFzxtbwbxhTPt8qalrzkUgWIEqoHS54xOngrsx9iV0LxCE5jpATDmoN x2h6MK1deVR9S0q6Fc5B5XMw1adS8vP1g3ra336mvNG4H8ONEALgOcoZze8BPaGplV1k rqfgSCrISSgINVm8wUq7D7kyvQq5hohXZ4PN6wKaNxNrla7uQGP2LaspJV3JG8IerDNo gxZfnukFQs4eGLC9kahm7EP35+418ukYR9vFuYjxX1I2bXtmuyjY0fFlURNgeFUOcSvE AxQXPrmaDrvsAjtGNp3HFbJlDrYI19chwwqP+ubSs4K43OUD8hilPYglcZWL96aWpCjR RPPQ== X-Forwarded-Encrypted: i=1; AHgh+RpUXHpJKwnw69b9uNr/xFHVpXZ0KOtg9v+/NBvY2ULP7BoyjPwaJsqsLKSSCdIVJKs8Vk14tJBlbciW3HY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn8VfNVyocWIjEsN3yaknJVHVvbDml2a8ANNpn0gwt9vn3xxOx 1EI4Vz41Uzl2TFJjCO2WaTae7g+vzRcEBakeYshdwVgSt0TprV5tVmLI X-Gm-Gg: AfdE7ck42cIz7XbuuV59lW7WcQVPuul1WTTrzfU9ehOjrV5ZtosdVkrvlBOjj93QAzq TrDJNa3cfs6yCoJ4zrHnXstc/1E8pHvCxxrGpRyec+vW3PcYUYuTywGQuK1VoNiRaPw49kJlXzr 0AsFBpsHrjk1PWv6vkOziAqFErMc9F8EySlkkd8m7ULJi82j8mAB+SDRHq7rUBCtvf/VBNhZ1jm xhdYtpGpSF5Ow1RbUVSTwOayv8NLraZUCTKnrML+fp70m6cYEiT9WXkUkR5ObuiSKwm542ZrhCr v/98Wt+mXf85C/DeawM6L7jR+a/lO6hPtejFhNlyAFwt6qkvQsVonG87bgX/FHjEJjnUpx4OazB s/HNO4fI9N76/6+wSvtAVdKiF15y0gzvG+RMZ5ytP/W5anp7YtOAa23UQy+w4z8ejHk0RbIkzxN ihp+ryQ6hoMUidvSmCbWU0FwDQZr7Naqgi8B/SsS0MzAWwg6ga77lD5saZTCJiY9OeON6HMenRP zyXnCgUzyRj7Q== X-Received: by 2002:a05:6512:2524:b0:5ae:bd5e:95f7 with SMTP id 2adb3069b0e04-5b159b6ab5bmr1418321e87.4.1784119839311; Wed, 15 Jul 2026 05:50:39 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:39 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 30/61] staging: rtl8723bs: replace correct_TSF with direct HAL call Date: Wed, 15 Jul 2026 19:47:58 +0700 Message-ID: <20260715124829.90290-31-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant correct_TSF() wrapper function from rtw_wlan_util.c and replace its call sites with direct calls to rtw_hal_set_hwreg(). The helper provides no extra logic or validation, serving only to pass the fixed HW_VAR_CORRECT_TSF flag and a NULL pointer to the underlying HAL layer. Removing it simplifies the driver's synchronization interface and reduces call overhead. Clean up the function definition, remove its prototype from the header file, and update all invocations across the driver. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 5 ----- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index d472570db..9dfa31171 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -4690,7 +4690,7 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res) if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE) { /* correcting TSF */ - correct_TSF(padapter, pmlmeext); + rtw_hal_set_hwreg(padapter, HW_VAR_CORRECT_TSF, NULL); /* set_link_timer(pmlmeext, DISCONNECT_TO); */ } @@ -4714,7 +4714,7 @@ void mlmeext_sta_add_event_callback(struct adapter *padapter, struct sta_info *p /* update_TSF(pmlmeext, pframe, len); */ /* correcting TSF */ - correct_TSF(padapter, pmlmeext); + rtw_hal_set_hwreg(padapter, HW_VAR_CORRECT_TSF, NULL); /* start beacon */ if (send_beacon(padapter) == _FAIL) { diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index dc2e341aa..03e047397 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1600,11 +1600,6 @@ void update_TSF(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) pmlmeext->TSFValue |= le32_to_cpu(*pbuf); } -void correct_TSF(struct adapter *padapter, struct mlme_ext_priv *pmlmeext) -{ - rtw_hal_set_hwreg(padapter, HW_VAR_CORRECT_TSF, NULL); -} - void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) { int i; diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index 6b1ac26b3..b12128963 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -602,7 +602,6 @@ void sa_query_timer_hdl(struct timer_list *t); extern void process_addba_req(struct adapter *padapter, u8 *paddba_req, u8 *addr); extern void update_TSF(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len); -extern void correct_TSF(struct adapter *padapter, struct mlme_ext_priv *pmlmeext); extern void adaptive_early_32k(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len); extern bool traffic_status_watchdog(struct adapter *padapter, bool from_timer); -- 2.55.0