From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3283B47B415 for ; Wed, 15 Jul 2026 12:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119846; cv=none; b=s6GWLjXbCD8frJtLEjCNzdKokPWkvzXlgIEjNC97mQqGtk+QtgKXRJ8qExOMtvqCo3dyaL5qI2rdAzYLisPUC2fQPgXBWGUyNEpKlkA3qbQKLzmf7zkXP1pjhWa4VjJVEu0FFYMNrwRJVBUqCHWP6tlvYH9SvjHRSkg+jpKfQYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119846; c=relaxed/simple; bh=WWVrQEGBR/w9v0EI6kme+tNtURJsD6oKvV59TvhbnAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GI8CMb8rLcY0J0pzYbrYJxIiiF7lKHjqMC/NjIx9/Df8rZC+0PcjVtX0U2zHeIFSd4/rFSGxtIr6e52IoRWkOKBucz5+T8aAG5ObVytpWEBjyat5P664WDRnpVoM2JCO+1UVRO1hRa//m+OXGwPEwey0enTqRJ+vsDi3iHVVJzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c0jRMBO2; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c0jRMBO2" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-39d4c864bfbso23142471fa.1 for ; Wed, 15 Jul 2026 05:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119840; x=1784724640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FtlASsqkw0C4v5Z/7LIib8Kc0TPvk4rZzD6C198Kz1k=; b=c0jRMBO2PsvzLS3nuBH8CvR5bQQYIgwFcjSzu+WX7yOr3UlWKJ4NZhF0Tf6cqlE+EX SzJaAvZCw5EIb7sIkuGgHScfmbj2ZbMgIAADwl35Y0LLCmNKjwsNmfwQczFIWM9D2rmR Y7Ot0/YrIlzJuqpMte4+6GATDpcDRLRxH0BJ8C15TrPWt8olPnRPr6Ue3vVvVMbVShV3 n7LrXjJi0qki9FVGh/HOL6EyflvWUoSMIOG1sAxGL4CdjgfdONxwhEEDE2VTls7KuKdB Y2sN8zXn1w1h51oBaHunnziu9Z/DcMBlPgtkWcOsMzZLmKwXtydhdDjODgv0hKxSpD1P DROQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119840; x=1784724640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FtlASsqkw0C4v5Z/7LIib8Kc0TPvk4rZzD6C198Kz1k=; b=VC3PhpONpZdXINCWeQSj6QpZIstOwlc4tlNQ6xbioFQMNKWVxCxjk5hQwjcTwc6HmG h1iWXyLIiqAMQl/QAwHMbPQu6KM4skF9eEvzUz2qa9bAdGhWgxRCVdCf7d+QoefI033a wKMgHA43EC+fsklnxWbCruVM1bc2bt/OeRPFAqMme+RsQhCN5+GK5Tt7603QwrZV/Hpe FOxyHU0JiArV82wGx0gUuMOLOZ0uhfQh1tBhFQwUfCQ1caUKRsh50K6ZFl5LSVY+oMQC 3DUuvYNYG51Mbo/WoTu+Jin3HIXiq9+fnj7CtoNyiLajgS/vfkgWJouIZ4Q8oAKB/8r8 QKew== X-Forwarded-Encrypted: i=1; AHgh+Ro6oPlc3NcHoa3LuOMpN14EfIHSBXYpXdn8Uaixp8PMcxhwmBVEofzI+Cn1kqrk7ly9lNwxF+G/piaTGF4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1J7jTW6qay1Mkmob7jfkcOMI2kSao+BO92RjAI80tXepLlWyJ Pet03VIEDvPKWbWXx6El2/PvMEprubmb0a9zNEMBrHJlkZ6uNV58XxTucHoMTCnWD2A= X-Gm-Gg: AfdE7ck7ibRnGnX338r8ryS53FjYaShG8fgf41/Ikh7BReEQ+EyGr3+mDzAT1YXG47f B+nssm6qRE8RDgOGbKjLT6yTXxipPiWOF+BFiu10EukG0EbBphkO7sxfvMEdTyNwB46RAXBamBc qHaufkqgwwoG0HMI1wo2ib7l/5QxG2uR0YjpDyaNoWOeaCxqqQgHcb7WTp1RHGmFpmhaHxb9cOX lofkG4ABzk2heAC9HqU9BnM0hiENgfvKel/9XtDtypV752AXaBhPtFsJjkUfFKGkrm3VD9YQx+H xzCiLQMaVc2hQYd30cgSOxqw13snUh3v81KElIrMvYiXi8qMh5QlYDAJcx0kpHcrz4tE4HP2p16 VrPfyAOo7I4e3RlT9KkY5CWTnZG4OIyUqmKc//p4TKgPRphg5SDzBTAue+Ez+aW8uVKo4DECrRx 9jFam2daVki/KOfck1YfN+zpQ9E8+vyPWOLzIZ2Fusj2BBgOzU3MUZ4h8+fER8F6PIOB9Le8ffF s2wOqKVOLFtLg== X-Received: by 2002:a05:6512:3c88:b0:5ae:b7ca:33ec with SMTP id 2adb3069b0e04-5b0235613f8mr3811386e87.9.1784119840071; Wed, 15 Jul 2026 05:50:40 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:39 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 31/61] staging: rtl8723bs: replace rtw_sctx_done with direct status call Date: Wed, 15 Jul 2026 19:47:59 +0700 Message-ID: <20260715124829.90290-32-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant rtw_sctx_done() wrapper function from rtw_xmit.c and replace its call sites with direct calls to rtw_sctx_done_err(). The helper provides no extra logic, serving only to pass the fixed RTW_SCTX_DONE_SUCCESS status code to the underlying error-handling function. Removing it simplifies the transmit context interface and reduces call overhead. Clean up the function definition, remove its prototype from the header file, and update all invocations across the driver. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ---- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index c8bdd0f3c..01f8b378e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -463,7 +463,7 @@ int rtw_cmd_thread(void *context) FUNC_ADPT_ARG(pcmd->padapter)); if (pcmd->res == H2C_SUCCESS) - rtw_sctx_done(&pcmd->sctx); + rtw_sctx_done_err(&pcmd->sctx, RTW_SCTX_DONE_SUCCESS); else rtw_sctx_done_err(&pcmd->sctx, RTW_SCTX_DONE_CMD_ERROR); } diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index fdda407c1..9a525be74 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -2565,10 +2565,6 @@ void rtw_sctx_done_err(struct submit_ctx **sctx, int status) } } -void rtw_sctx_done(struct submit_ctx **sctx) -{ - rtw_sctx_done_err(sctx, RTW_SCTX_DONE_SUCCESS); -} int rtw_ack_tx_wait(struct xmit_priv *pxmitpriv, u32 timeout_ms) { diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h index f67cb22e3..f85a03efe 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -212,7 +212,6 @@ enum { void rtw_sctx_init(struct submit_ctx *sctx, int timeout_ms); int rtw_sctx_wait(struct submit_ctx *sctx); void rtw_sctx_done_err(struct submit_ctx **sctx, int status); -void rtw_sctx_done(struct submit_ctx **sctx); struct xmit_buf { struct list_head list; -- 2.55.0