From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0330947CC99 for ; Wed, 15 Jul 2026 12:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119853; cv=none; b=Moz97nPX6UmIIM9XxdulNTRocrpyBZ5QLeyQc4c+xJjGV70CtsFynwUW+JNNVfNkohDlZXK/Ifc0LMnKnzsWlwlFUbmG+8oZW9oDZ0euBueuFNT3m3mXq60H1lUOPL27SBBDJFZ8yQGVqitBOrK1mMjfpF5jVCZd5NookwugRZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119853; c=relaxed/simple; bh=ugc1wl73gyCiFlC8VPNE08duIEs6oNaSxsOBFhWPaAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NQ1G92VGSBanvOG9OX4fPGAr7lsFCwfM77iuGvrby7x9mxwEL5hSDuaxQ5wgcMIv/6+jzcjcka13wQ8Q/NAezxxXggAFlqLVEbX6e8WyogTocM9ShlVqZYx9Ucq79/ERm51IhHr2QY4UVvrgA7rjyOTf5k1tYgT9uHiGeq2X+d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=amFXCtMQ; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="amFXCtMQ" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-39c9107baa7so54296461fa.3 for ; Wed, 15 Jul 2026 05:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119845; x=1784724645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AMl0JK2aYeTwB6YV2v47Dym/vUmzgdvhjJIdnzT3agg=; b=amFXCtMQI14Ne4Bt5AD/8xL2igXHJptu0GJsa+LnSMJB51yr5A09yo4TDTpzdRNCjz 1cXaAmNmHLyQhmu1we/SBlyfumXnyHyuqeNr435rtuJ1zNGtRe1qVkQBqbD1h2eD9bmm 7WKkG9wElHqSV6W/7m99YcMaBaO0OpILAIXCD4jOJ3cCjllc2YgvB5niH4+6zkP81NkG BaoLvDZcKFN4V4+gPN8S350A8LhRBceqQiHtLGYgOu1i7zH0prrIN99BdgYXxcV1yrnG YXde9uabo7QI3I76d1HaTdI7DGtYMR5mLLdJUfFqNtPfarCHNpgvUgHN6qkm6z/Vj38r rEUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119845; x=1784724645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AMl0JK2aYeTwB6YV2v47Dym/vUmzgdvhjJIdnzT3agg=; b=VD4mee1GizeAEibNtppmXzAMHJtGokxSvD8x94aEThzfedLPbuPshlT9mkpI2LpvV3 TSnVOZx7ZuMxuS2h8ZXIDnN2R874C4pQkUvZaRDtQ6/hQjW7/slTQ5kZPZ5XNSMbD7su aczYwiqZp8hcaS0AObmY6dh3dJF8u8BE0s002r+t6ha6gza4q81HnVXqSxrwHLsjg3cW rfA5v3UQx1GbjIyoEDt8H5Lj7MihlJsbQdu12DH07jQMA+TzhPFne7n7a0Y6Itth5fWY J96Qtd17GQ+yWWlBsuJEChfYtsTtS510L25LoPE/sMxcPX7XgmfWwXejpDULHLNeWww4 TSVQ== X-Forwarded-Encrypted: i=1; AHgh+Rph+E6tL5rwBUQaOOSUbq92r7GFIDnMJ16Gngn88USl8NCkr3upllk0b49Cx3TJMDprmbUNYsKAj8RovWQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3fe02lH0EzeUz7aH8uZc1L9WWtA+QME0qYvKJgGP0VUuxtTU2 IZM4SLawFx8w/1eYre6EyPQfXdHxBXQ0W8ysfL+ikngfPfZx17GT0689uXeCDQU5dtM= X-Gm-Gg: AfdE7ckDZwpQHl465MWuu83GAvH/bY3xQBtNzypz7YuKx3wwsdOkJVvXOQW+8WiAOtg 0KdmaxmdvSDLaz/ICtfmm8VKBwDjKD0HC53IMS92+O7qtmvIft1gqIOPJnVm3UqVgKUgx6soEov KKCrYTyPYVqTpWJjEKZMmUY0jFUrSFuGy/NY0+XW+AnOXKeVA4jVv2qAgUz2NbFbL7XKm7P4/+5 P+Xpe20NchTTYlsZefoT2hjdzg8rzJYvQUU13cLR/YY70FQrirGmlBaCx0Q5P/modKhuyoDEmHg VPzO4i0H6vCMqbbCq1JuDsNXsIOe33fHBDmAQL8d7OlesD7Q9FC7eh1qAiIt7OKhp8zt307qyI6 L68AcPtH6wk/epAE9p1K+Ol23RU0W2AS2lPPWMtUQrH5f3dksUyErH3OkSPEqwObkRtCG9s4/39 EoySms/t9CLBzGTX9HGkmNyzmeokdY4QomAMaexNQaGhG6Hk1Q6AhaXuW28YTqrf5bvuEAkZX57 iHCMSaYmCJjfg== X-Received: by 2002:a05:6512:6819:b0:5b0:15b1:3d5d with SMTP id 2adb3069b0e04-5b15d783560mr562863e87.22.1784119844729; Wed, 15 Jul 2026 05:50:44 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:50:44 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 37/61] staging: rtl8723bs: replace halbtc8723b1ant_SwMechanism with direct call Date: Wed, 15 Jul 2026 19:48:05 +0700 Message-ID: <20260715124829.90290-38-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the redundant halbtc8723b1ant_SwMechanism() wrapper function from the Bluetooth coexistence code. The helper provides no extra logic, serving only to pass the arguments along with a fixed NORMAL_EXEC state flag to the underlying function halbtc8723b1ant_LowPenaltyRa(). Removing it simplifies the driver's coexistence mechanism path and eliminates unnecessary indirection. Clean up the function definition, remove its prototype from the header file, and update all call sites to invoke halbtc8723b1ant_LowPenaltyRa directly. Signed-off-by: Arsenii Pashchenko --- .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c index 0613beaa3..522e4dd4c 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c @@ -755,12 +755,6 @@ static void halbtc8723b1ant_LpsRpwm( pCoexDm->preRpwm = pCoexDm->curRpwm; } -static void halbtc8723b1ant_SwMechanism( - struct btc_coexist *pBtCoexist, bool bLowPenaltyRA -) -{ - halbtc8723b1ant_LowPenaltyRa(pBtCoexist, NORMAL_EXEC, bLowPenaltyRA); -} static void halbtc8723b1ant_SetAntPath( struct btc_coexist *pBtCoexist, u8 antPosType, bool bInitHwCfg, bool bWifiOff @@ -1271,35 +1265,32 @@ static bool halbtc8723b1ant_IsCommonAction(struct btc_coexist *pBtCoexist) !bWifiConnected && pCoexDm->btStatus == BT_8723B_1ANT_BT_STATUS_NON_CONNECTED_IDLE ) { - /* halbtc8723b1ant_SwMechanism(pBtCoexist, false); */ bCommon = true; } else if ( bWifiConnected && (pCoexDm->btStatus == BT_8723B_1ANT_BT_STATUS_NON_CONNECTED_IDLE) ) { - /* halbtc8723b1ant_SwMechanism(pBtCoexist, false); */ bCommon = true; } else if ( !bWifiConnected && (pCoexDm->btStatus == BT_8723B_1ANT_BT_STATUS_CONNECTED_IDLE) ) { - /* halbtc8723b1ant_SwMechanism(pBtCoexist, false); */ bCommon = true; } else if ( bWifiConnected && (pCoexDm->btStatus == BT_8723B_1ANT_BT_STATUS_CONNECTED_IDLE) ) { - /* halbtc8723b1ant_SwMechanism(pBtCoexist, false); */ + bCommon = true; } else if ( !bWifiConnected && (pCoexDm->btStatus != BT_8723B_1ANT_BT_STATUS_CONNECTED_IDLE) ) { - /* halbtc8723b1ant_SwMechanism(pBtCoexist, false); */ + bCommon = true; } else { @@ -1975,14 +1966,14 @@ static void halbtc8723b1ant_RunCoexistMechanism(struct btc_coexist *pBtCoexist) else halbtc8723b1ant_LimitedRx(pBtCoexist, NORMAL_EXEC, false, true, 0x8); - halbtc8723b1ant_SwMechanism(pBtCoexist, true); + halbtc8723b1ant_LowPenaltyRa(pBtCoexist, NORMAL_EXEC, true); halbtc8723b1ant_RunSwCoexistMechanism(pBtCoexist); /* just print debug message */ } else { halbtc8723b1ant_LimitedTx(pBtCoexist, NORMAL_EXEC, 0, 0, 0, 0); halbtc8723b1ant_LimitedRx(pBtCoexist, NORMAL_EXEC, false, false, 0x5); - halbtc8723b1ant_SwMechanism(pBtCoexist, false); + halbtc8723b1ant_LowPenaltyRa(pBtCoexist, NORMAL_EXEC, false); halbtc8723b1ant_RunSwCoexistMechanism(pBtCoexist); /* just print debug message */ } @@ -2019,7 +2010,7 @@ static void halbtc8723b1ant_InitCoexDm(struct btc_coexist *pBtCoexist) /* force to reset coex mechanism */ /* sw all off */ - halbtc8723b1ant_SwMechanism(pBtCoexist, false); + halbtc8723b1ant_LowPenaltyRa(pBtCoexist, NORMAL_EXEC, false); /* halbtc8723b1ant_PsTdma(pBtCoexist, FORCE_EXEC, false, 8); */ halbtc8723b1ant_CoexTableWithType(pBtCoexist, FORCE_EXEC, 0); -- 2.55.0