From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0152447DFB0 for ; Wed, 15 Jul 2026 12:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119878; cv=none; b=eUMvBBA4hgUpARqjVIJsYrsHO+jv/zFZdwDHsRhe53kDwEGBq0353/KcPbdqeyRqifOa/D7bMrQ15+/LGf7fEMrw+0tTM9V80nB04YEWT+NX67zHsbCy/aVOafCssMXgJ0zD9iw+HYOOlJVfX/40HeDUIJZtm2i7PyLbFFRVIN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784119878; c=relaxed/simple; bh=4UMnNqvjYlYoBVL98iCDufghaVBXrJyxQ7ZYTuAFCco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VM3VkEv7Y8tArIjZt+kV0a4lY16tqBMu5rCC9wns7yrMOIMOSyarfZZ0a0n9+82tV1XTaid1X9jUPSujRqnKt3Q5T1eYT8soKoSQd/oN3CAm+AYgNahiOZweEBgHaioRTah/VE6F+c93bj8L0CB7ktaqE4Z4N1Q5TDWbeMG/uv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eJ7p8ylD; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eJ7p8ylD" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5b15dcaca31so762350e87.0 for ; Wed, 15 Jul 2026 05:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784119867; x=1784724667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/4u9zgrmxiREjYwS8Qv0Serfz7FqeIq0lu9hAYsQr4Q=; b=eJ7p8ylDUugsV9YNo6iWdzOQq4VXn5Upo35twKkP/Le/tCpF+b2oqQKylFupUOJul6 RZNGkrWoZmF2Ry+rDmGq+LzP6ty7xnJuMN4LiGrTnHsRTrF/W+E1vbupRVCfd2O8JdzI 8BCc72aT/39MF5BgdaENmnBKQkM9H4pTpa9Q18qLHQXN0RasjzNPZiU8sh0Rs/jhp2B3 s94Y0E4d1+Pj/V66HESx/RioQpu6yMID1n8//X3XWIljLFPKi0SXj+g0MUiupgP2ykFb BiXaeCirRgfgXY0CuLrm6BHpMO171BQuOLAjJ9nyd9/4s4tZz1uvl7ui1hrpDCjluZnS Rt4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784119867; x=1784724667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/4u9zgrmxiREjYwS8Qv0Serfz7FqeIq0lu9hAYsQr4Q=; b=TJTdnYtROcEemJEv4CS6+lhHQtzOGEqcyBYbfaW1wFWijy8agHZHanxuxm3bZjrhUi cUq92MN34BpHxg8woP545JBNCLZYQH+QFmFdL4UD/lnU/Jjskl4g7vfd2eFISv6TVVb3 V0Zk6POiW3ygOQBVhEAFoXwnaIIDWdTEJzyiUJALi1m4No9K8wCEd7CEVFhCA7FsozIK E5L5aH44zt4mr1D2SIhhWY5onJPlbaDVSDZdvC9sma7NsU2LiQQQLXEOK27jkb6i563I R0a6QWYkASNwZwH9GF+tSUIea7xaB1hi01hir2GRMpX2SqqT1PwswWYrSzREFwLmhsUF y56w== X-Forwarded-Encrypted: i=1; AHgh+RrUWsKrSdbCRIt5v5z2lc4oisiu2YiPa9+dDPxmVqJ1DoEWV5S5agg3ZN/9UN4RvbkCFyEUsfJh5eIlebs=@vger.kernel.org X-Gm-Message-State: AOJu0YzLw36bEGdX/d8YFMulOU5oYJFjAnnUniReX/Xl2J0Q+lUeo8/E TzgwOXTFNrl3upSI6cFetAIVuz6shLW9m62CpfbLMca17pQSqaTvQJJ3r/jm/eE6ChM= X-Gm-Gg: AfdE7cl9p4CqCcbt6bp5J7Mc/diwS20pk/tmtnzvxiqjiJF50tj/aKYSYxqCJyBRUpR vKLBl37mQnBsO+wFwIJC3YTCom7Dv+WB5tUkNVWAjkOVdRXE+QilJSXEcUu5DbdcK3FA1dQnP+Q Cfhjjg3SLdfvxQMlZ/AkyKN0vbR1F1kYAYuP+6KrBTuje4m5hsqQlNFCNJ1ob0Aj+YfXA6oiJ++ +jESe9VZWedlHCnZl2kZnxID+MP4TRe/F4QhS8HAVeWZsBdgxj/alBicAv5+Z5qbKRx4DLERS5W yRDUbu5y3sOmmdIY6gvThsfVrX556e4qeyz3ocsJKGOD8W+tpNmll+TpNMxj+WGn5ua1KEMg0Sb mPDylCAFv/IvKuLmOEKpJrRHe1POa/AFVgKymyGygvTxucDkKd86GjqBiMrITb3GJCP1Qj3Wf8P 9h7wCvzUwGg2YwFdbZc6cHys1QNhHsMAWFgqsuj1yKdeATjSi7StjpuF0OX6LaXxQxZv2ZWGIgB 7ECZqVKvJACZA== X-Received: by 2002:a05:6512:3e03:b0:5b1:5061:e5d2 with SMTP id 2adb3069b0e04-5b159b86efdmr1520546e87.30.1784119867382; Wed, 15 Jul 2026 05:51:07 -0700 (PDT) Received: from archlinux ([94.180.44.28]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b022fac999sm3404042e87.55.2026.07.15.05.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:51:07 -0700 (PDT) From: Arsenii Pashchenko To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ulijg308@gmail.com Subject: [PATCH 61/61] staging: rtl8723bs: fix tx power limit lookup by using correct channel index Date: Wed, 15 Jul 2026 19:48:29 +0700 Message-ID: <20260715124829.90290-62-ulijg308@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260715124829.90290-1-ulijg308@gmail.com> References: <20260715124829.90290-1-ulijg308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In phy_get_tx_pwr_lmt(), the result of phy_GetChannelIndexOfTxPowerLimit() is erroneously assigned back to the input parameter 'channel'. Since 'channel' is never used again afterward, this triggers a -Wunused-but-set-parameter compiler warning. Furthermore, the actual index variable 'idx_channel' remains initialized to -1, causing the function to always fail the subsequent validation check and prematurely return MAX_POWER_INDEX. Fix this by assigning the computed channel index directly to 'idx_channel'. This resolves the compiler warning and restores the intended hardware tx power limit lookup logic. Signed-off-by: Arsenii Pashchenko --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c index 7ad04aa85..bbaedf256 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -718,7 +718,7 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel, if (idx_rate_sctn == 0 || idx_rate_sctn == 1) idx_bandwidth = 0; - channel--; + idx_channel--; if (idx_regulation == -1 || idx_bandwidth == -1 || idx_rate_sctn == -1 || idx_channel == -1) -- 2.55.0