From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0902042047B for ; Wed, 15 Jul 2026 13:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784121213; cv=none; b=sjMfdemOEHHCNsa4iUnsgT0sbidf3XBwvT4774D/cGHgfCx7Re/9nprvtGyoLYCp0X0vva/fOrfqZL9kK3pRTaZTN/90dJNATUEyHpyyQC3PQ/iS6qVtM/S+yFxgNhCilaBr1t8ocAI1DsWjPR2QEiOJjmT/RQKZZGGoyG6sS4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784121213; c=relaxed/simple; bh=KQMxyJQdifvarpCGsWxhXxjn98U5iaRvdp/JTh7SIvE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RJNaiXvSLsecmLeD2fDG0tmGUNhYKKed3k8KzURx1l1eZxTBxGRte55FNj6H9PJeBl/ucuWmpwGPu9SZ65udp7aFEZVoUL/xS7kkBiGbcYZXLkONsFQATRwOLWILySG4Qixd8N9I5r5l54ox+IUMMPoP9/6TE4PNVVyUfJS62d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=IxqjBN3J; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="IxqjBN3J" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47defd0c1c5so1628967f8f.3 for ; Wed, 15 Jul 2026 06:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784121210; x=1784726010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Isug4d4gZLeQ1dsQFpAeiurry6hWvqBofOhP4QHYRoo=; b=IxqjBN3JRYuS+94iqYFkwe3VRuVhO0VVDKjT2kd/zswaYSh6Jsu8L+VST0y7VstmFc GgHyPiz8no7W8AgWdUyedG7Bo/tkjlbMgPwlZcEeSi8x9yJAs2PcboJLH/R/oKLDsjGv fuzp17TY+mHJHzJFqNK2CATIqylnzngzv7RrkhEC9auXPD4tdF9pT+8ZYHfzkTTkY9RF oxUmD0Y8Mi9ChGgS5qDaw2v+dht6b+gyGsx0HrNHjrrp2KB7Db+yCHkb+uwPaLVkiaTX 1dmAp/bwnq1VKFzdZLuPt2dK5ToNNo/6AlrMa36FfPTpijzvH66n3BA0WRlyj9DYE8QV 10lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784121210; x=1784726010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Isug4d4gZLeQ1dsQFpAeiurry6hWvqBofOhP4QHYRoo=; b=Wq/VF8xe3hMg6bbsn+4qR9TzXWUO+jh7ErzZo/bG+S64QLoYG+w0kckMgy8XP5qq/w 59DT4PHatp5uWeRrWEohtUO3H/1fhjtScU+8RjS3QOI/17HI2DuWQA/CLCRMUztTMx+C 32m2xKwc00tZFykFJ1rVrzzXKYV+WaASQGQTF25rOfQQBzToWp2V62K8DK99wOk37bh6 81zHqOpXpQrEFaEi0zIjwP15XBo5D1/OXiy8UW2Jx1cUT1fGh9KEAHsfHMiy/6iyiseG t2E6iqdOh3A0wZ6IhXQd5GKPQgg1xjslv8mT9eTo0nTe/+O2XIiXIZ2qyTNzwNHkBvMY l1Ow== X-Gm-Message-State: AOJu0Yy7qaIfoT6GfbB+SN7ydX3vKnAW0D6VFkZXTVnDqIALbIt2/OvO q2AyWVG0aWfVusB7Il+KmpLjsC8ZNQeF/1n41O+8g2oKu8mcawFFrjXrzfscj/G/DB3OZvKcdic F02Oe X-Gm-Gg: AfdE7cnqTqbAGBMvsY4wK2JBcvMmxR+M438VcM88m9e5OO8e///rJpkvAFkcO/G+hp4 NaJQ2ssfGWn5KhDBbVRe4bhaNlSxFnsiXuKx+zhpCCLiwk2hMpngfwZTaM48fToH1SmvQVQGzO1 hlPb0+qKsVvAxevQv0IjWA51MlIN3aWJdb8/QfThC9uflepARNB+2kUS4uP078IDyCyWGX1pOsO OLJqeEylt2YBW8hMrfllkhSj0/NXjCHac0+T0DXVWyFiVaU3Sxz87k7LESAi5WYkFw7tMP33ee6 XZMHId3sR6yUNIcwzNRLm3kBcFo96tDWe60B/oGTqBYLsh4g3OnG/VVScc8GjeblZucmID1ioB7 2taWS8owO6zfZc0N7JORpB+OMQE72xptu8BunJyd525AEg5imAyhTyE849C71xpbuTT62bhFsoO X5mjnGwKtNRF+Cih44UtaR9eeTPj9RDcN8PgKXKQev4wogZ6CbhLi9WPiX X-Received: by 2002:a05:6000:25c2:b0:474:6a5b:860b with SMTP id ffacd0b85a97d-47f2dcd79damr19586444f8f.37.1784121210262; Wed, 15 Jul 2026 06:13:30 -0700 (PDT) Received: from arnold.baylibre (88-127-129-70.subs.proxad.net. [88.127.129.70]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f464d6fa7sm16418290f8f.37.2026.07.15.06.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 06:13:29 -0700 (PDT) From: Corentin Labbe To: dakr@kernel.org, gregkh@linuxfoundation.org, mcgrof@kernel.org, rafael@kernel.org, russ.weight@linux.dev Cc: linux-kernel@vger.kernel.org, Corentin LABBE Subject: [PATCH] firmware: maintain a firmware list Date: Wed, 15 Jul 2026 13:13:25 +0000 Message-Id: <20260715131325.26099-1-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Corentin LABBE Checking if some firmware is missing need to check dmesg for error message, and on some machine this information could be lost since dmesg uses a ring buffer. Having the list of all firmware requests is useful in many situations, like selecting the minimal list when doing some buildroot config or reducing the size of linux-firmware on gentoo via saveconfig. So for letting thoses tasks to be automated easily, it is better to have all loaded firmware in one place. This patch adds a debugfs with all firmware that was tried to be loaded and the result of those actions. Signed-off-by: Corentin LABBE --- Hello I believe the list could setup more appropriate elsewhere in /sys, but without idea, I used debugfs. If you have better idea, let me know it. Regards drivers/base/firmware_loader/main.c | 100 ++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 24213a0ea831..786d9b2b096e 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -11,7 +11,9 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include +#include #include +#include #include #include #include @@ -35,6 +37,7 @@ #include #include #include +#include #include #include @@ -48,6 +51,95 @@ MODULE_AUTHOR("Manuel Estrada Sainz"); MODULE_DESCRIPTION("Multi purpose firmware loading support"); MODULE_LICENSE("GPL"); +struct fw_loaded_entry { + struct list_head node; + const char *driver; + const char *fw_name; + int result; +}; + +static LIST_HEAD(fw_loaded_list); +static DEFINE_MUTEX(fw_loaded_lock); +static struct dentry *fw_debugfs_dir; + +static void fw_record_request(struct device *device, const char *name, int ret) +{ + const char *driver = device ? dev_driver_string(device) : "(none)"; + struct fw_loaded_entry *entry; + + if (!name || name[0] == '\0') + return; + + guard(mutex)(&fw_loaded_lock); + + /* Update in place if we have already seen this request. */ + list_for_each_entry(entry, &fw_loaded_list, node) { + if (!strcmp(entry->driver, driver) && + !strcmp(entry->fw_name, name)) { + entry->result = ret; + return; + } + } + + entry = kzalloc(sizeof(*entry), GFP_KERNEL); + if (!entry) + return; + + entry->driver = kstrdup(driver, GFP_KERNEL); + entry->fw_name = kstrdup(name, GFP_KERNEL); + if (!entry->driver || !entry->fw_name) { + kfree(entry->driver); + kfree(entry->fw_name); + kfree(entry); + return; + } + + entry->result = ret; + list_add_tail(&entry->node, &fw_loaded_list); +} + +static int fw_list_show(struct seq_file *m, void *v) +{ + struct fw_loaded_entry *entry; + + guard(mutex)(&fw_loaded_lock); + + list_for_each_entry(entry, &fw_loaded_list, node) { + const char *name; + + if (entry->result >= 0) { + seq_printf(m, "%s %s OK\n", + entry->driver, entry->fw_name); + continue; + } + + name = errname(-entry->result); + if (name) + seq_printf(m, "%s %s %s\n", + entry->driver, entry->fw_name, name); + else + seq_printf(m, "%s %s %d\n", + entry->driver, entry->fw_name, entry->result); + } + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(fw_list); + +static void fw_loaded_list_free(void) +{ + struct fw_loaded_entry *entry, *tmp; + + guard(mutex)(&fw_loaded_lock); + + list_for_each_entry_safe(entry, tmp, &fw_loaded_list, node) { + list_del(&entry->node); + kfree(entry->driver); + kfree(entry->fw_name); + kfree(entry); + } +} + struct firmware_cache { /* firmware_buf instance will be added into the below list */ spinlock_t lock; @@ -911,6 +1003,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name, fw_log_firmware_info(fw, name, device); } + fw_record_request(device, name, ret); + *firmware_p = fw; return ret; } @@ -1727,6 +1821,10 @@ static int __init firmware_class_init(void) if (ret) goto out; + fw_debugfs_dir = debugfs_create_dir("firmware_loader", NULL); + debugfs_create_file("firmware_list", 0444, fw_debugfs_dir, NULL, + &fw_list_fops); + return register_sysfs_loader(); out: @@ -1739,6 +1837,8 @@ static void __exit firmware_class_exit(void) unregister_fw_pm_ops(); unregister_reboot_notifier(&fw_shutdown_nb); unregister_sysfs_loader(); + debugfs_remove_recursive(fw_debugfs_dir); + fw_loaded_list_free(); } fs_initcall(firmware_class_init); -- 2.53.0