All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Song Hu <husong@kylinos.cn>
Cc: SJ Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] damon: update outdated comment about DAMOS filter handling
Date: Wed, 15 Jul 2026 06:56:40 -0700	[thread overview]
Message-ID: <20260715135640.84147-1-sj@kernel.org> (raw)
In-Reply-To: <20260715092634.1450702-1-husong@kylinos.cn>

On Wed, 15 Jul 2026 17:26:34 +0800 Song Hu <husong@kylinos.cn> wrote:

> The kernel-doc comment above enum damos_filter_type states that only the
> anon and memcg type filters are handled by damon_operations (and therefore
> accounted as 'tried'), and that DAMON_OPS_VADDR and DAMON_OPS_FVADDR do
> not support those two filter types.
> 
> Neither is accurate anymore.  damos_filter_for_ops() routes every filter
> type except ADDR and TARGET to the operations layer, and the VADDR and
> FVADDR operations (the latter being a copy of the former) handle all of
> those types through damos_folio_filter_match() / damos_va_filter_out().
> Update the comment to match the code.

Thank you for updating this!
> 
> Signed-off-by: Song Hu <husong@kylinos.cn>

Reviewed-by: SJ Park <sj@kernel.org>

This patch is applied to damon/next [1] tree.  If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]

      reply	other threads:[~2026-07-15 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  9:26 [PATCH] damon: update outdated comment about DAMOS filter handling Song Hu
2026-07-15 13:56 ` SJ Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715135640.84147-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=husong@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.