From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6985D2F39B4; Wed, 15 Jul 2026 14:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784124112; cv=none; b=H/PNKBIincTDlHSSl+ejWq0TWdAJ603BsaberbKrzFkJuOeI+4i9yjL9BHg3ql0eI/jDmqiHOqIlEf6hAOYFjPuaS7KCicSgWVjJiw99Yx0tX3iLaMN32JQOrqtdgUE7ofPJWOobs6GSv1l15hUCgkbt0cHoyS0tiXJ/i9TwIlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784124112; c=relaxed/simple; bh=uTMNPCRq8D0flY48pJnXGpzKYNKCwlS1FHUUgYwgar0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hiQtL/TfLiSJc5lU7JCoF2EufYZnv3StOm6u2GUNTpbqFSqor8ySjE8Ob6w0As373c0rjZIBj2AqeR/KQcpHZ3g5pOvLgDBxW14B9hyD9xNsfYvJD4YGz6HYKwsRR6V/7oKhUCFIWODE1lYjuGuH/P1hcSf6+kcnAQYMiv+e1ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=Sib5nQDY; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="Sib5nQDY" Received: from francesco-nb (xcpe-178-82-120-96.dyn.res.sunrise.net [178.82.120.96]) by mail11.truemail.it (Postfix) with ESMTPA id 12CED1FC12; Wed, 15 Jul 2026 16:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1784124108; bh=o9e56pBy+caxR+Chcucx0VwaDuQlyH1PFgilBztsuSw=; h=From:To:Subject; b=Sib5nQDY+Bj+oCMJJ5JdKrMn/z3dotAqATE4QLmZAswoVlu2XApO5y479nYKQyCCk biBP+/65qTNmxRQDTonv2eusULiYYSqCG5K9FVjTMSnO9GnhlfFbw5d+Z2q/LuFqQs Mq0leaFK7F/sidN2ACpJhHunClxtULQBufiwMiQttE7cb0yqtb3UxaiXszKlTosKot QyZ62Fk2XYxYMCUzW+VOAlLZEhkVP+HiamhrEUBZKN2j+U/b5twp096QJjJcU/5BCU RmiKdQ6+FVvl4N2LdbE+9lF2+5qCj6bSKWYGlEhEJQd9QHiv5/1Mpyzjuuf36tY73X huOoN8kPDYJ0A== Date: Wed, 15 Jul 2026 16:01:46 +0200 From: Francesco Dolcini To: Pengpeng Hou Cc: Brian Norris , Francesco Dolcini , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: validate rate scope TLV length Message-ID: <20260715140146.GC56330@francesco-nb> References: <20260706091346.76985-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706091346.76985-1-pengpeng@iscas.ac.cn> On Mon, Jul 06, 2026 at 05:13:46PM +0800, Pengpeng Hou wrote: > From: Pengpeng > > mwifiex_ret_tx_rate_cfg() verifies that a TLV stays within the command > response, then parses RATE_SCOPE as struct mwifiex_rate_scope. The > type-specific parser also needs to prove that the declared TLV payload > covers the bitmap fields that it reads. > > Check the RATE_SCOPE payload length before copying the legacy bitmaps, > and require the VHT bitmap area only for firmware API version 15 where > it is consumed. > > Signed-off-by: Pengpeng Is this change tested? On which device? How? Francesco