Re: [PATCH v3 net 5/6] selftests/xsk: fix too-many-frags multi-buffer Tx test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] A newly added multi-line comment uses the deprecated kernel style where text is placed on the same line as the opening `/*`.
--

--- Patch [5]: [PATCH v3 net 5/6] selftests/xsk: fix too-many-frags multi-buffer Tx test ---
commit 41dfcc558e2b05136aed2feb3d3534323946fd99
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests/xsk: fix too-many-frags multi-buffer Tx test

This commit updates the too-many-frags test to keep oversized Tx descriptors
valid so they can be accounted and reclaimed, while marking the corresponding
Rx packet invalid. It also adds a synchronization packet to verify the Tx
path recovers at the next packet boundary.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_xsk.c b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> index 6eb9096d084c0..de17dd48f1764 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_xsk.c
[ ... ]
> @@ -2288,24 +2288,30 @@ int testapp_too_many_frags(struct test_spec *test)
[ ... ]
>  	if (pkt_stream_generate_custom(test, pkts, 2 * max_frags + 3)) {
>  		free(pkts);
>  		return TEST_FAILURE;
>  	}
>  
> +	/* The generated Tx stream must keep the too-big packet valid so that
> +	 * __send_pkts() accounts its descriptors in outstanding_tx. The Rx
> +	 * stream, however, must not expect this packet on the wire.
> +	 */

[Severity: Low]
This isn't a bug, but could this multi-line comment be formatted to match
the preferred BPF subsystem style?

The BPF guidelines specify that multi-line comments should have the opening
/* on its own line, rather than having the comment text start on the same
line.

> +	test->ifobj_rx->xsk->pkt_stream->pkts[2].valid = false;
> +	test->ifobj_rx->xsk->pkt_stream->nb_valid_entries--;
>  
>  	ret = testapp_validate_traffic(test);
>  	free(pkts);
>  	return ret;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714140722.111645-1-maciej.fijalkowski@intel.com?part=5