From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2966F399377 for ; Wed, 15 Jul 2026 14:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784127392; cv=none; b=JrqhUpzS1t4lNgSmsr03cYbdLe4I3CaEjLY07PF2zg8NMTf5xC2n82NGPBgWEMdNfDGUcwbSF6BC7xgNnUm1/IlcIr6nIMczijmvQsFEDAK6LYIpZodjhKIANqvvr033EUDkvNkuZEvai0o+RmTWB/FdpNUGlr7sVFQNnSP23bA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784127392; c=relaxed/simple; bh=p5KuDeusVEoCUg38XXhv4wSbGDVLdalEOTq5OJM3HGI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MZcyXApAV5PgOfVTJ8gVyWWWo4ZH/knqHjVEfbHoM7d20eZCLLFb5/lMhlskyL4wTdtUdr5vb0A9+Gz3Yb+iXGRMKP4qQTi/kykyUdtQJfvhLjqfLR9oY74svJwGFE2s/wcoaNgBTwR22qOL7UVo1Ji977MMRStCr6akUUSK7wE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LjJ1XRAX; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LjJ1XRAX" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so46732645e9.0 for ; Wed, 15 Jul 2026 07:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784127389; x=1784732189; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RblpppZAMmnU5omlXvpMP24NqfykpV279MnhnwwEblY=; b=LjJ1XRAXXQlOd319bPxMs5AnJJpO+otA7uhYsMEY49KYrjvov6RC6Acx/vJdIJLnKB tcfxUJZfWZ6ThQF9RiMxQH4WRlPwWONpMvT8938iCm9qfRxM000nf6pX1Fhy8F5LtD3j tVGJlBR7GlmF01diFYkw8zhweYUlC7XKcyAwE6Ljn30CWDL0aM/tFyX6WeUxlfj8/aVk Lc/NTwzR1u1g/C51iKuXosslJ/44puTbwSCPyjO/QAJCG2lj8s7vBrFvnt4ldLhKwP6z eKo987FgQQd4yw2Eb8QqBSN8vK9pzRfhtY9yxnkwmou5EbfeFdXPD0t3bbCVKkvvFqUI 45Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784127389; x=1784732189; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RblpppZAMmnU5omlXvpMP24NqfykpV279MnhnwwEblY=; b=gqkIGco+D2HacA1YY/LNSXoU+1FammSYxWXafhMIibGLn3GcD5F47PgkHoW3hHkF3R EBowwVuBC6lnMskEtSKCwqF+xMPBixkYm4fxBeJ3uAsdFs2flsOW3GcAhYMDuOh1bWvG tYQ/F9Sqfx0bxBYg29LvLOqqUESWHRG0B7FhYnM17w8hR2gi0RN44lHnFjzyo7g6d5l2 Jku/MdBO7lz/cacrgCvYkvAx9O4tnf6+XMAer1YADerZPqUAfB763NSR9iIGndIWCv61 lS4QM1mgUTpUcV+B9C9uatsmzh5ZBmytK1wgOzIAMSIEDGF593u+nNAC9O0eLpPt7TeQ enJw== X-Forwarded-Encrypted: i=1; AHgh+Rqt45dmJifDW4UGbBesctiek8TLH4FHZh8QY7IphQBzYYX0WyQGT0kVblS4WlzjsmUoXy04AH/1z91EcRw=@vger.kernel.org X-Gm-Message-State: AOJu0YwS7TwUt8sHqccnC6gN9VXu+1b31NLR7+SV3L7sHKdMRVL1qtUV 8HzmXwMCP9qaYC/oYmK8QYdeLwCYljgZ3SD5LmYH7OqCChgMFf/b8ogpbeWqz++1r2I= X-Gm-Gg: AfdE7ck5mEkRnojLzUicvGcP5cwN7ifLjYb+CdKlsHxATzAuie9LzKMI9xZ/l7gL+q8 Ri+QObQmdQVGBNx/y5O3YTt2FFYeio7Z4tm2R2kecnPG6aw6NX2tp7e0DWFZEK7S4PAazmvXhP7 c30Q2JmJ4DVWwrPsF4ijT7UULEqT3WZFydiYV2XDOKoaU6uUJ4WvGtQxlHnFfDW73+YiiOV7BDE f/RMmoUOKnRIM2agNC9SyO+8+YdqydtME5opxjSZsUEbiCSR9H5t96QBVo8J4jutUcvKlqz0muv Xm8DV700DjOacCs+W1KgpUfC87a/9WNATw3yHY8XKFgH2Uo9ZTValrxUGiXvfb0CTcFYior7dCg hh1YO3Q7mI0xzrDzZ2pK2toK8kawJyVl8kEcs/0bulVnCqY8snbWQ49/YGMgI46QJacTBHo9On3 t+IQ9tRQ== X-Received: by 2002:a7b:c8d3:0:b0:492:6113:d4fc with SMTP id 5b1f17b1804b1-4953899c37bmr54386175e9.17.1784127389264; Wed, 15 Jul 2026 07:56:29 -0700 (PDT) Received: from avermoal ([185.13.179.173]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4950a322c86sm145746985e9.11.2026.07.15.07.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 07:56:28 -0700 (PDT) From: Mikhail Lukianchikov To: lee@kernel.org Cc: avermoal@gmail.com, mfd@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v1] mfd: viperboard: fix native fields type in structures as little-endiand Date: Wed, 15 Jul 2026 20:52:44 +0600 Message-ID: <20260715145243.461827-2-avermoal@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sparse reports several warnings about incorrect type in assignment (different base types) when building the i2c-viperboard.c driver: warning: incorrect type in assignment (different base types) expected unsigned short [usertype] addr got restricted __le16 [usertype] The structures vprbrd_i2c_write_hdr, vprbrd_i2c_read_hdr, and vprbrd_i2c_addr_msg describe raw USB packets and, as I understand it, require Little-Endian byte-order. Therefore, 16-bit field in these structures were annotated as __le16, not native unsigned short. This satisfies Sparse and ensures correct behavior on Big-Endian architectures. Signed-off-by: Mikhail Lukianchikov --- include/linux/mfd/viperboard.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mfd/viperboard.h b/include/linux/mfd/viperboard.h index 46287a1f6bf6..5761ebdc81b3 100644 --- a/include/linux/mfd/viperboard.h +++ b/include/linux/mfd/viperboard.h @@ -57,15 +57,15 @@ struct vprbrd_i2c_write_hdr { struct vprbrd_i2c_read_hdr { u8 cmd; - u16 addr; + __le16 addr; u8 len0; u8 len1; u8 len2; u8 len3; u8 len4; u8 len5; - u16 tf1; /* transfer 1 length */ - u16 tf2; /* transfer 2 length */ + __le16 tf1; /* transfer 1 length */ + __le16 tf2; /* transfer 2 length */ } __packed; struct vprbrd_i2c_status { @@ -89,7 +89,7 @@ struct vprbrd_i2c_addr_msg { u8 cmd; u8 addr; u8 unknown1; - u16 len; + __le16 len; u8 unknown2; u8 unknown3; } __packed; -- 2.55.0