From: linuxtestproject.agent@gmail.com
To: Tomas Dzik <tdzik@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] LTP/Lite test float_trigo core dumps due to free(): invalid pointer
Date: Wed, 15 Jul 2026 14:57:30 +0000 [thread overview]
Message-ID: <20260715145730.4076-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <c2a4d3fb4e65c526dc207aadf2e3f70fec46cc0d.1784119861.git.tdzik@redhat.com>
Hi Tomas,
On Wed, 15 Jul 2026 15:04:46 +0200, Tomas Dzik wrote:
> LTP/Lite test float_trigo core dumps due to free(): invalid pointer
--- [PATCH 2/3] ---
> Add some checks for malloc() returning NULL
The subject does not name the affected component (the float gen* data
generator tools under testcases/misc/math/float/). Without that, a
reader browsing the git log cannot tell which tree the change belongs
to without opening the diff.
"some" also implies the coverage is partial. Inspection shows there is
exactly one malloc() call per changed file and all of them receive a
NULL check. Consider something like:
float: add malloc() NULL check in gen* data generator tools
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-15 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:45 [LTP] [PATCH 0/3] Fix to float_trigo core dump and related enhancements Tomas Dzik via ltp
2026-07-15 13:04 ` Tomas Dzik via ltp
2026-07-15 9:45 ` [LTP] [PATCH 1/3] LTP/Lite test float_trigo core dumps due to free(): invalid pointer Tomas Dzik via ltp
2026-07-15 10:55 ` [LTP] " linuxtestproject.agent
2026-07-15 9:45 ` [LTP] [PATCH 2/3] Add some checks for malloc() returning NULL Tomas Dzik via ltp
2026-07-15 9:45 ` [LTP] [PATCH 3/3] Replace sprintf() with more secure snprintf() variant in float tests Tomas Dzik via ltp
2026-07-15 13:04 ` [LTP] [PATCH 0/3] Fix to float_trigo core dump and related enhancements Tomas Dzik via ltp
2026-07-15 13:04 ` [LTP] [PATCH 1/3] LTP/Lite test float_trigo core dumps due to free(): invalid pointer Tomas Dzik via ltp
2026-07-15 14:57 ` linuxtestproject.agent [this message]
2026-07-15 13:04 ` [LTP] [PATCH 2/3] Add some checks for malloc() returning NULL Tomas Dzik via ltp
2026-07-15 13:04 ` [LTP] [PATCH 3/3] Replace sprintf() with more secure snprintf() variant in float tests Tomas Dzik via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-07-09 15:40 [LTP] [PATCH 1/3] LTP/Lite test float_trigo core dumps due to free(): invalid pointer Tomas Dzik via ltp
2026-07-09 16:34 ` [LTP] " linuxtestproject.agent
2026-07-08 9:37 [LTP] [PATCH] " Tomas Dzik via ltp
2026-07-08 10:21 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715145730.4076-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=tdzik@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.