All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [linux-next:master] [crypto]  2f204fe718: stress-ng.af-alg.ops_per_sec 113.7% improvement
Date: Wed, 15 Jul 2026 16:27:49 +0000	[thread overview]
Message-ID: <20260715162749.GA1794078@google.com> (raw)
In-Reply-To: <202607152204.a0a3bf98-lkp@intel.com>

On Wed, Jul 15, 2026 at 11:00:46PM +0800, kernel test robot wrote:
> 
> 
> Hello,
> 
> 
> we don't have enough knowledge to deeply analyze the impact of this commit
> to stress-ng.af-alg performance tests.
> 
> along with the major kpi improvement:
> 
>    7756377          +113.7%   16578454        stress-ng.af-alg.ops_per_sec
> 
> we also noticed lots of misc tests seem have changes, e.g.
> 
>     697423            -9.5%     630908 ±  2%  stress-ng.af-alg.aes_cipher_ops/sec
>     245103          -100.0%       0.00        stress-ng.af-alg.blowfish_cipher_ops/sec
>     369646          -100.0%       0.00        stress-ng.af-alg.camellia_cipher_ops/sec
>     162192          -100.0%       0.00        stress-ng.af-alg.cast5_cipher_ops/sec
>     115113          -100.0%       0.00        stress-ng.af-alg.cast6_cipher_ops/sec
> 
> we don't know if these are expected behavior upon 2f204fe718.
> so this report is just FYI what we observed in our tests.
> 
> 
> 
> kernel test robot noticed a 113.7% improvement of stress-ng.af-alg.ops_per_sec on:
> 
> 
> commit: 2f204fe718f5bf519013cc2536ad7bb2cbb51661 ("crypto: af_alg - Add af_alg_restrict sysctl, defaulting to 1")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

That commit makes AF_ALG block access to some algorithms by default,
overridable by a sysctl.  Apparently these performance tests
misinterpret that as a change in performance.

It actually doesn't make much sense to do performance testing on AF_ALG
at all anymore, given that AF_ALG is deprecated.  A limited form of
AF_ALG is being left in place just for backwards compatibility with a
few programs.  None of those programs use it in a performance-critical
way, as far as I know.

To the extent that it's still done at all, it shouldn't test random
algorithms like "ecb(cast5)" that are obsolete and unused.

- Eric

      reply	other threads:[~2026-07-15 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 15:00 [linux-next:master] [crypto] 2f204fe718: stress-ng.af-alg.ops_per_sec 113.7% improvement kernel test robot
2026-07-15 16:27 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715162749.GA1794078@google.com \
    --to=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.