From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA601C44508 for ; Wed, 15 Jul 2026 19:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pvvVNjQB4tXqBfluqGcHPLZIffvzi7vUtWZjPSdDO1w=; b=wDobXbyLBYdmeZ y//47mrGaZyKjL5SiAtjXX0xkuIePlqaP1wQuOEY2llq6tEkmXzllhDgJ7fHzVJaMrxoSJielZkgW lTy/RROQQoBJZs9BEKub0KFZ8hO2Uwhjjuw67K4Z/heJICwtwkLNz/hq9xFXisOWAOU/zfDt9Giw+ 47lnpHy04mbUqq/u5XXyTys1WXv7kZW/DYLq5ZZLFra/U5hMILFr8qUgvXNd/sHW13s99bbOzjokG d7DKhdNZSpAaDZ215Ft5/8DBRub2/2YzxrEoPfqsrWNmlvraBrMExWYOZ16kiErH2r80rxnzpcyKK Eld1gNi9kw8VQ9B/xcvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk54I-0000000Flx9-2jVs; Wed, 15 Jul 2026 19:14:54 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk54H-0000000FlwP-1gJB for linux-phy@lists.infradead.org; Wed, 15 Jul 2026 19:14:53 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D95F240080; Wed, 15 Jul 2026 19:14:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A4821F00A3F; Wed, 15 Jul 2026 19:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784142892; bh=amNxNsxiYD+UwtXtFy7mITJnpHsCeZnOsPz7hH07J1c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cT/ZWzWZll5TSuMVtPS0/WWMwmU6AZeAWjX8sYp3qGg1by485NnMCYPhhT9yHO44N 9sJbfXWiRBvGWw1ZsP2vKmj1wKsa9Sxuo2NgHsxzYnQA22tF0KXVLXJ3n1I5UJCub7 z9GU7UzdqiURi3/Wla6R/uJqz/gnoXviib1qMh2fL3rKOtC3FXv1z4uSggVO9ydzXO M/F8JHD8Lo/+PYwBucuqlVhdRsWzw+udWg8msgNL0EbHq8GJoaSY3f4jhrEECf/fh9 mEfg2f1htC/7c/PZ3Cngmw3s3Y/CqKFjQgf9beaEZMY03n0QHp41evXKJwqJQBDyFV bbKay+RVlGQwA== From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH 05/10] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes To: "Coia Prant" Cc: robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260714191341.690906-6-coiaprant@gmail.com> References: <20260714191341.690906-1-coiaprant@gmail.com> <20260714191341.690906-6-coiaprant@gmail.com> Date: Wed, 15 Jul 2026 19:14:51 +0000 Message-Id: <20260715191452.4A4821F00A3F@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gRGV2aWNldHJlZSBhbnRp LXBhdHRlcm46IGR1bW15IGZpeGVkLWNsb2NrIG5vZGVzIHVzZWQgZm9yIGludGVybmFsIFNvQyBj bG9ja3MgYW5kIGxlZnQgdW5hc3NpZ25lZC4KLSBbTG93XSBTdGF0ZSBtaXNtYXRjaDogZml4ZWQt Y2xvY2sgbm9kZXMgYXJlIGVuYWJsZWQgYnkgZGVmYXVsdCBkZXNwaXRlIGNvbW1pdCBtZXNzYWdl IGNsYWltcy4KLS0KCi0tLSBQYXRjaCBbNV06IFtSRkMgUEFUQ0ggMDUvMTBdIGFybTY0OiBkdHM6 IHJvY2tjaGlwOiByazM1Njg6IGFkZCBYUENTIGFuZCBmaXhlZC1jbG9jayBub2RlcyAtLS0KY29t bWl0IGI0N2UxZmNlYmQ0MzM3NGQ2NDMxZmMyMGZmYTY0YTAzOTc1MTNkNjgKQXV0aG9yOiBDb2lh IFByYW50IDxjb2lhcHJhbnRAZ21haWwuY29tPgoKYXJtNjQ6IGR0czogcm9ja2NoaXA6IHJrMzU2 ODogYWRkIFhQQ1MgYW5kIGZpeGVkLWNsb2NrIG5vZGVzCgpUaGUgUkszNTY4IFNvQyBpbnRlZ3Jh dGVzIGEgU3lub3BzeXMgRGVzaWduV2FyZSBYUENTIHRoYXQgcHJvdmlkZXMKdGhlIFBoeXNpY2Fs IENvZGluZyBTdWJsYXllciBmb3IgMTAwMEJBU0UtWCwgU0dNSUksIGFuZCBRU0dNSUkKaW50ZXJm YWNlcyB2aWEgaXRzIGZvdXIgTUlJIHBvcnRzLiBBZGQgdGhlIFhQQ1MgZGV2aWNlIG5vZGUgYW5k Cml0cyBwY3MtbWlpIHN1Yi1ub2RlcyB0byB0aGUgU29DIGRldmljZSB0cmVlLgoKPiBBbHNvIGFk ZCB0d28gZml4ZWQtY2xvY2sgbm9kZXMgKHhwY3NfZ21hYzBfY2xrIGFuZCB4cGNzX2dtYWMxX2Ns aykKPiBwcm92aWRpbmcgdGhlIDEyNSBNSHogcmVmZXJlbmNlIGNsb2NrIGZvciB0aGUgR01BQ3Mg d2hlbiBvcGVyYXRpbmcKPiB3aXRoIFhQQ1MuICBUaGVzZSBjbG9ja3MgYXJlIHVzZWQgYXMgdGhl IGFzc2lnbmVkLWNsb2NrLXBhcmVudHMKPiBmb3IgdGhlIHJlc3BlY3RpdmUgR01BQyBub2Rlcy4K CltTZXZlcml0eTogTG93XQpUaGUgY29tbWl0IG1lc3NhZ2Ugc3RhdGVzIHRoZXNlIGNsb2NrcyBh cmUgdXNlZCBhcyBhc3NpZ25lZC1jbG9jay1wYXJlbnRzCmZvciB0aGUgcmVzcGVjdGl2ZSBHTUFD IG5vZGVzLCBidXQgdGhlIHBhdGNoIGRvZXNuJ3QgYXBwZWFyIHRvIGFkZCB0aGUKYXNzaWduZWQt Y2xvY2stcGFyZW50cyBwcm9wZXJ0aWVzIHRvIHRoZSBnbWFjMCBvciBnbWFjMSBub2Rlcy4gQXJl IHRoZXNlCmFzc2lnbm1lbnRzIG1pc3Npbmc/Cgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzU2OC5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1NjguZHRzaQo+IGluZGV4IDNiYzY1M2YwMjdmMWYuLjk4OWUxNjRjMGViMzkgMTAwNjQ0 Cj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjguZHRzaQo+ICsrKyBi L2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LmR0c2kKClsgLi4uIF0KCj4gKwl4 cGNzX2dtYWMwX2NsazogeHBjcy1nbWFjMC1jbG9jayB7Cj4gKwkJY29tcGF0aWJsZSA9ICJmaXhl ZC1jbG9jayI7Cj4gKwkJY2xvY2stZnJlcXVlbmN5ID0gPDEyNTAwMDAwMD47Cj4gKwkJY2xvY2st b3V0cHV0LW5hbWVzID0gImNsa19nbWFjMF94cGNzX21paSI7Cj4gKwkJI2Nsb2NrLWNlbGxzID0g PDA+Owo+ICsJfTsKCltTZXZlcml0eTogTG93XQpTaG91bGQgdGhpcyBpbnRlcm5hbCBTb0MgY2xv Y2sgYmUgbW9kZWxlZCBhcyBhIGNsb2NrIHByb3ZpZGVyIGZyb20gdGhlCmdlbmVyYXRpbmcgWFBD UyBJUCBub2RlIHVzaW5nICNjbG9jay1jZWxscywgcmF0aGVyIHRoYW4gdXNpbmcgYSBkdW1teQpm aXhlZC1jbG9jaz8KCkFkZGl0aW9uYWxseSwgdGhlIGNvbW1pdCBtZXNzYWdlIHN0YXRlcyAiQWxs IG5vZGVzIGFyZSBsZWZ0IGRpc2FibGVkIGJ5CmRlZmF1bHQiLCBidXQgdGhpcyBub2RlIGlzIG1p c3NpbmcgdGhlIHN0YXR1cyA9ICJkaXNhYmxlZCIgcHJvcGVydHkuIFdpbGwKdGhpcyBsZWF2ZSB0 aGUgY2xvY2sgdW5jb25kaXRpb25hbGx5IGVuYWJsZWQ/Cgo+ICsKPiArCXhwY3NfZ21hYzFfY2xr OiB4cGNzLWdtYWMxLWNsb2NrIHsKPiArCQljb21wYXRpYmxlID0gImZpeGVkLWNsb2NrIjsKPiAr CQljbG9jay1mcmVxdWVuY3kgPSA8MTI1MDAwMDAwPjsKPiArCQljbG9jay1vdXRwdXQtbmFtZXMg PSAiY2xrX2dtYWMxX3hwY3NfbWlpIjsKPiArCQkjY2xvY2stY2VsbHMgPSA8MD47Cj4gKwl9OwoK W1NldmVyaXR5OiBMb3ddClNpbWlsYXJseSwgZG9lcyB0aGlzIG5vZGUgYWxzbyBuZWVkIGEgc3Rh dHVzID0gImRpc2FibGVkIiBwcm9wZXJ0eSB0byBhbGlnbgp3aXRoIHRoZSBiZWhhdmlvciBkZXNj cmliZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcxNDE5MTM0MS42OTA5MDYtMS1jb2lh cHJhbnRAZ21haWwuY29tP3BhcnQ9NQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgt cGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A8D41A56D for ; Wed, 15 Jul 2026 19:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784142899; cv=none; b=RUWacp3zl8xHJt5imsCoEjYYZKQnAlLhdt8VnGSt8cq6hRalvNMhKfopQwl+gs2mIAshmxJPeWZND7delNmLh4g5SNE2R9+ip2aRSQ33JR7vGuNCTAD+v5mhieUDf5HoZEvoOFdzSjnSY/MlkSZZzPEWDShSdHfA5tzcmNaROsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784142899; c=relaxed/simple; bh=oyszTGkmqP0pSnxSF+Y70XsfZRG3OfqC2UZlMd0PPdg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Rtw7spCn96De2nqsdu10cVLvEFfK/v4G2wUue6wz9Jh9o5R087BgI2kGyzWdNOIgyXvK0cNO3dfnD0BigCnWv7ArGVJcWtWIvEj0PewIu7QWiByJ/Lt90a1VSqx6syRmMidOxykCQZLDGwxRZXfV23RPkSQ28NFpOp5bXueTwYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cT/ZWzWZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cT/ZWzWZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A4821F00A3F; Wed, 15 Jul 2026 19:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784142892; bh=amNxNsxiYD+UwtXtFy7mITJnpHsCeZnOsPz7hH07J1c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cT/ZWzWZll5TSuMVtPS0/WWMwmU6AZeAWjX8sYp3qGg1by485NnMCYPhhT9yHO44N 9sJbfXWiRBvGWw1ZsP2vKmj1wKsa9Sxuo2NgHsxzYnQA22tF0KXVLXJ3n1I5UJCub7 z9GU7UzdqiURi3/Wla6R/uJqz/gnoXviib1qMh2fL3rKOtC3FXv1z4uSggVO9ydzXO M/F8JHD8Lo/+PYwBucuqlVhdRsWzw+udWg8msgNL0EbHq8GJoaSY3f4jhrEECf/fh9 mEfg2f1htC/7c/PZ3Cngmw3s3Y/CqKFjQgf9beaEZMY03n0QHp41evXKJwqJQBDyFV bbKay+RVlGQwA== From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH 05/10] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes Reply-To: sashiko-reviews@lists.linux.dev To: "Coia Prant" Cc: robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, vkoul@kernel.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260714191341.690906-6-coiaprant@gmail.com> References: <20260714191341.690906-1-coiaprant@gmail.com> <20260714191341.690906-6-coiaprant@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Jul 2026 19:14:51 +0000 Message-Id: <20260715191452.4A4821F00A3F@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] Devicetree anti-pattern: dummy fixed-clock nodes used for internal = SoC clocks and left unassigned. - [Low] State mismatch: fixed-clock nodes are enabled by default despite co= mmit message claims. -- --- Patch [5]: [RFC PATCH 05/10] arm64: dts: rockchip: rk3568: add XPCS and= fixed-clock nodes --- commit b47e1fcebd43374d6431fc20ffa64a0397513d68 Author: Coia Prant arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes The RK3568 SoC integrates a Synopsys DesignWare XPCS that provides the Physical Coding Sublayer for 1000BASE-X, SGMII, and QSGMII interfaces via its four MII ports. Add the XPCS device node and its pcs-mii sub-nodes to the SoC device tree. > Also add two fixed-clock nodes (xpcs_gmac0_clk and xpcs_gmac1_clk) > providing the 125 MHz reference clock for the GMACs when operating > with XPCS. These clocks are used as the assigned-clock-parents > for the respective GMAC nodes. [Severity: Low] The commit message states these clocks are used as assigned-clock-parents for the respective GMAC nodes, but the patch doesn't appear to add the assigned-clock-parents properties to the gmac0 or gmac1 nodes. Are these assignments missing? > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/d= ts/rockchip/rk3568.dtsi > index 3bc653f027f1f..989e164c0eb39 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi [ ... ] > + xpcs_gmac0_clk: xpcs-gmac0-clock { > + compatible =3D "fixed-clock"; > + clock-frequency =3D <125000000>; > + clock-output-names =3D "clk_gmac0_xpcs_mii"; > + #clock-cells =3D <0>; > + }; [Severity: Low] Should this internal SoC clock be modeled as a clock provider from the generating XPCS IP node using #clock-cells, rather than using a dummy fixed-clock? Additionally, the commit message states "All nodes are left disabled by default", but this node is missing the status =3D "disabled" property. Will this leave the clock unconditionally enabled? > + > + xpcs_gmac1_clk: xpcs-gmac1-clock { > + compatible =3D "fixed-clock"; > + clock-frequency =3D <125000000>; > + clock-output-names =3D "clk_gmac1_xpcs_mii"; > + #clock-cells =3D <0>; > + }; [Severity: Low] Similarly, does this node also need a status =3D "disabled" property to ali= gn with the behavior described in the commit message? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260714191341.6909= 06-1-coiaprant@gmail.com?part=3D5