From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0E59C44507 for ; Wed, 15 Jul 2026 20:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vQXEzd1tjjER4eTmHZ+rFrVKVAU/FKJHunLPb4hVQzc=; b=fEg87FWc9oo0eM 155iJCzBwfvE7LF/gNI4NhpH1JTGWPMzUEwsJR01VP+TP8ABKuD5sUFB5F0MwHaTwgwwsWksyAaBS +N59HDToriXHOM6xpe1HJkHqxWX6/kiHu7bW4cO8iWAP0dRkSJZmlIxhBvr21UJ9OFYHuzPvPRuPb b4W7zIYZIbtiXHizw1OTctOQP0OePvc6d2it6ziNuuWHMkroAWFKXkeoAh51uDNDTI095EcoxjkMj 054opZwby0OzKQERYwDCU1g9resmRHF1XOLzNSzBw2G6OKodT+dOjJao8RR6/CuG8VZfvy7boBVgT x/umc9TQiN7h5l7z5fiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk6MG-0000000FtNY-1vva; Wed, 15 Jul 2026 20:37:32 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk6MB-0000000FtMa-3AHN for linux-mtd@lists.infradead.org; Wed, 15 Jul 2026 20:37:31 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5b0115b9e17so2603483e87.0 for ; Wed, 15 Jul 2026 13:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784147844; x=1784752644; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NoIda1guEjtKHuZZquZPDvd4YRXgpw3e0ECzSA1t07Y=; b=a7ersYBXxiWkRfaBGPHiOCMXHkYENlW4s0m0lETLCqiNN8sC9OlkMuft9clsdiDCQo 7T4FhKm+99tX1nbg6tbuFs1PQnEp+8IjipD//jua+Znc/WNRDzDPCfKvOC7FEaUtdKlW 8gKozxBL2+REw1z2pT+yRWcuoJHqzq4s56CxOnZxPblSchUlWJ8p2374ErFDvdLhBHRC FxiKzmQ0AqMVXP/vMBYrygNKBkyM1Q/mvzAs2CMHWwTvEOaEAhPd2s500zHqgD/wn6tP HUAF5ZjH7vXSqGtSmWu6aNx7rdtTRPAOzzYBstnYpYFCBXN/aN9ICVIw0ofSDdV0aEjf b0CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784147844; x=1784752644; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NoIda1guEjtKHuZZquZPDvd4YRXgpw3e0ECzSA1t07Y=; b=WDCXYKtBsOmD8aZTV3jfwp0oMcbhPlTZ3wvIr+H4JPUBl9XAYD40HUxIn+etUzHEVW H7EtcT4e60dCoap1JzN4eXcFuvXZjCvlleEdHREwh/jkIOd9EKK/wuBkGnqQolTQuH0t fIjc3OMVOLpHlLfs4j0WsjptZohTwlr82Qz64lEz3smP30lbxK3Ar+DeFywCHllsPGn5 vBV5T770IAdvwfhsvT/NsV3VoRs5zE7Iuiy0uhfDvQSoWpnKe4cUg0mQXkEyjVKOeb9B UPoSBdVSTtxJWRPX36tLVZOY1LbeLbryLfMbWfmC3GRCcRMCONw1zuF6fCY5j7JOsObY d5vA== X-Forwarded-Encrypted: i=1; AHgh+RrD2LEEbK5YITfo9rnwTvKXAZCE56Yq6ZAwL58Se4vjg0MSzSbZ44WSXtrStXSItq+2sRpolrYjKwE=@lists.infradead.org X-Gm-Message-State: AOJu0YxS7cO53PfA12sUvzZpoa8eYrkNZrN6ZZG0t5ZBaM+KIuuOilSn b+R90Y+wrKo5io32+XM6rEf3+drZlyu/XnawJ+++g5lLGbWxbWOnZmF7 X-Gm-Gg: AfdE7cllNe89svRxtWoxy8ZMROc480wxKN9Fo7sIJdqncVB7YWehs4C4E3Ct27bGHkR scXxKOIaHHpr1CLNuWsiItKAcJa0wy93/9IBhJnAsomRsGUD/FtgnG5U5jMvHzjkPj6GWPvfBH5 YNYSHdPVhpTYLLbwL1+/AlqLSQWISVZqBOk//qaynDBS3VVwx9qCY/uuvTtlTwX8GD+uTyfjrN8 hebDPPX9jzkvuVTEOowEnK+wygJo0ukIUWJXXcTM9fuhGJLD3LMdmIcjZLdSBwnHsqOOadI6WyE BjJ3vgLVdNL5gzbSeWsLSMpE7wBYi8lb72iy4lAvSFh5Za2LUefnE8ei0V/yWuF1YDmJDyrpbsl zG1HgfKH13HaA/KiK9BE7j8jI0hjhTS1UiPihI6RpEHZ/u+FxSWMnI8W3qSJW5Na+CeiXlWc4JF bB1xb8MU6cMhP7eiYVVjB6jnNGfa++ExeDf9p+TqwtZ13k/CbkjxdJ X-Received: by 2002:a05:6512:611:10b0:5b0:1df9:2aed with SMTP id 2adb3069b0e04-5b0235633f1mr3066253e87.5.1784147844176; Wed, 15 Jul 2026 13:37:24 -0700 (PDT) Received: from NoteBook ([37.153.34.175]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b01ca9dde5sm4422923e87.38.2026.07.15.13.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 13:37:23 -0700 (PDT) From: Aleksandr Mineev To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Aleksandr Mineev Subject: [PATCH] mtd: spinand: fmsh: fix FM25G01B/FM25G02B Quad I/O read dummy cycles Date: Wed, 15 Jul 2026 23:36:02 +0300 Message-ID: <20260715203602.1462-1-sanderrrs@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260715_133728_462610_EB5D829F X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org The FM25G01B/FM25G02B datasheets specify a single dummy byte for the 0xEB Quad I/O read-from-cache operation, but the generic read_cache_variants set uses two dummy bytes for the 1S-4S-4S variant. The extra dummy byte shifts the data phase and returns corrupted data with no ECC error, breaking boot on boards using these chips. Use a dedicated read-from-cache variant set with ndummy=1 for the 1S-4S-4S (0xEB) operation. FM25G01B datasheet: https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf FM25G02B datasheet: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf Fixes: d5a5c9eb2ee9 ("mtd: spinand: fmsh: add support for FM25G{01,02}B") Signed-off-by: Aleksandr Mineev --- drivers/mtd/nand/spi/fmsh.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c index be5db9f9502b..6352e9c9e502 100644 --- a/drivers/mtd/nand/spi/fmsh.c +++ b/drivers/mtd/nand/spi/fmsh.c @@ -44,6 +44,14 @@ static SPINAND_OP_VARIANTS(update_cache_variants, SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0), SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0)); +static SPINAND_OP_VARIANTS(fm25g_read_cache_variants, + SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0)); + static int fm25g01b_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { @@ -192,7 +200,7 @@ static const struct spinand_info fmsh_spinand_table[] = { SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xd1), NAND_MEMORG(1, 2048, 128, 64, 1024, 21, 1, 1, 1), NAND_ECCREQ(8, 528), - SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + SPINAND_INFO_OP_VARIANTS(&fm25g_read_cache_variants, &write_cache_variants, &update_cache_variants), SPINAND_HAS_QE_BIT, @@ -202,7 +210,7 @@ static const struct spinand_info fmsh_spinand_table[] = { SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xd2), NAND_MEMORG(1, 2048, 128, 64, 2048, 41, 1, 1, 1), NAND_ECCREQ(8, 528), - SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + SPINAND_INFO_OP_VARIANTS(&fm25g_read_cache_variants, &write_cache_variants, &update_cache_variants), SPINAND_HAS_QE_BIT, -- 2.54.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E03E3C7696 for ; Wed, 15 Jul 2026 20:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784147850; cv=none; b=gCrft4iRt94bx0rKud4Ijbj6qVX4YDyl+6A5Myxh20dPI+V3buvju6/+Iu2RQlKSCqtWQ2vxu8TXx8RTI0Zg9hCJuhDVIm4n44Ra+bQ1XydR9BO6ecDguhLOsaurJUEEYgu6EHTU5yM+hC0S7Ual9XY1fu/X7Rriq13z53Dh4pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784147850; c=relaxed/simple; bh=9QHm2HB3xN6YlqkAf+0wIczl0r5pJzJYDHp5/G0ZYKI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tfvYUzQZw7n8KxpJjcn6eDAHERQgwjUWchCZ/PXoz2N1I/AAQ96Hlmr+YE8jt7n2iwIpjWS4SYfz9lJ5cMbq29dn5cZg+qDB665Uvt/Ylzl011Okz+/LLqsZ5LqCaRrClc7FGs6UG4THgAM2GRoUIrqSTBOfsoAWEbXePGInvpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HXO46VVM; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HXO46VVM" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5b018fe8318so2201091e87.3 for ; Wed, 15 Jul 2026 13:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784147844; x=1784752644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NoIda1guEjtKHuZZquZPDvd4YRXgpw3e0ECzSA1t07Y=; b=HXO46VVMSNyOpAU71TU0g1V02bbA4vX6lYIWLf42owUBnx83RzPUg8qON8Ye5JcbMj djSoIikaVsJnBDcon4miWflDwGudNaORxZAGH7bAbr0meiMciIoTHKd7VoVxD6k4NCwR fFMectaIpPOXNyjQ7PHT1nqUHJfoBQ/xtZxdJrv/AaZikqj3B9Bt1NLxE2viTowYpMsW JniWISwfHNUZu/FOhQkk+NW8PS/rU0SKNtlsph/aySHzBRk6yUguIr8Q44z2dgcOhdiu 1KNYiGfkqLF83jgqHS5aoC3JoASHhABx0bYNvIeDX7EptFLOitrwZUmud2g7iX3N/3W3 BnYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784147844; x=1784752644; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NoIda1guEjtKHuZZquZPDvd4YRXgpw3e0ECzSA1t07Y=; b=mJ0Nr82E7ASuE/eYOqsdNT+p8z1fEi/M1CbU7PViauCvpMk8oseVCPNVvRPdE1soGu woKNboltGJwdkRJvpmUX/E1sYwQNkgko0b/Gp8I8JedPkV3V70fHcjFA0U/PwT2JGaDG cDNQ06U4KnnOUPXAiHuiJZqqX5sOu6noj3FQJb5ktJGBjGe5/2fnVWOfypDFEt8RKGGr P3YF/xkj9U3TQj/3lwlqwNmJo5wiTc82uimzw2SQ9spb2DRwYKQ89lkM0147ViSKUz/N eRrm9wawxZXtBXJPmGGZspT9Nt4NJ4/ZC3nRG+aQTXHG/xnRFoTFgkrDJtyQh35KdPbq r8Xg== X-Forwarded-Encrypted: i=1; AHgh+RpM92g47EezNx/0VnVgEPrAeIyaN1n34zWdgjSep52uXdC8PO/+agfPZnNK1tX3nqBStsdBjHXB4RCTv9c=@vger.kernel.org X-Gm-Message-State: AOJu0YwoauxoXIqcRLLboEgb3ywm8ZzdoNdAPx9c3ypuTur7DGH6NOQp GMbNUwi4oNYBpZ4vIzGSbV5u2GLg7kU9vr1vgamCrA2YYBw5XYey3iI0 X-Gm-Gg: AfdE7cni+BN5qrmJUL4dyGwCrb9WG6eQ05lm+CyV3IK8PWYESF3fnc13gL1jiasvu3l gNPknpLQaLUip9ZxYzhu40VtjAp0KnlLLKwUnwifcGsWVc2TMYKEW+E6EIVJ1JSLgMMAQbnL397 UMcVKXiMay88u/kJ6f9301de1FNcKgWfUKaujzWFKULmFYuyaRhXzCV/bjux51IcPRK0o211JMg VzY7rd2a1nviH07J56Pk5upG4/JQRU+peg2ZTA2skGRq1NxfKwWrYUSVUTXXIjcgddBsgbL44ZF XdUUY7uIsVlsFuV4hPDswP0QNC4yfNbYNzR2TmB8o7/tEA8DIcLGZcG8BSlfHl7H0Yez2zKweEa nPLd4ckM2TsRUzPgUzggRvyr62VWJ6F0DOkMRjpY4tboYvo7vj6mBM+bnNIvco+T/kpqoUwQG6J NBD5ZnNAwGp0UpnTclMtfmdr2zOPKxhYGb3kh10uAIh22wq+6JPf+v X-Received: by 2002:a05:6512:611:10b0:5b0:1df9:2aed with SMTP id 2adb3069b0e04-5b0235633f1mr3066253e87.5.1784147844176; Wed, 15 Jul 2026 13:37:24 -0700 (PDT) Received: from NoteBook ([37.153.34.175]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b01ca9dde5sm4422923e87.38.2026.07.15.13.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 13:37:23 -0700 (PDT) From: Aleksandr Mineev To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Aleksandr Mineev Subject: [PATCH] mtd: spinand: fmsh: fix FM25G01B/FM25G02B Quad I/O read dummy cycles Date: Wed, 15 Jul 2026 23:36:02 +0300 Message-ID: <20260715203602.1462-1-sanderrrs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The FM25G01B/FM25G02B datasheets specify a single dummy byte for the 0xEB Quad I/O read-from-cache operation, but the generic read_cache_variants set uses two dummy bytes for the 1S-4S-4S variant. The extra dummy byte shifts the data phase and returns corrupted data with no ECC error, breaking boot on boards using these chips. Use a dedicated read-from-cache variant set with ndummy=1 for the 1S-4S-4S (0xEB) operation. FM25G01B datasheet: https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf FM25G02B datasheet: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf Fixes: d5a5c9eb2ee9 ("mtd: spinand: fmsh: add support for FM25G{01,02}B") Signed-off-by: Aleksandr Mineev --- drivers/mtd/nand/spi/fmsh.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c index be5db9f9502b..6352e9c9e502 100644 --- a/drivers/mtd/nand/spi/fmsh.c +++ b/drivers/mtd/nand/spi/fmsh.c @@ -44,6 +44,14 @@ static SPINAND_OP_VARIANTS(update_cache_variants, SPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0), SPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0)); +static SPINAND_OP_VARIANTS(fm25g_read_cache_variants, + SPINAND_PAGE_READ_FROM_CACHE_1S_4S_4S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_2S_2S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0), + SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0)); + static int fm25g01b_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { @@ -192,7 +200,7 @@ static const struct spinand_info fmsh_spinand_table[] = { SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xd1), NAND_MEMORG(1, 2048, 128, 64, 1024, 21, 1, 1, 1), NAND_ECCREQ(8, 528), - SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + SPINAND_INFO_OP_VARIANTS(&fm25g_read_cache_variants, &write_cache_variants, &update_cache_variants), SPINAND_HAS_QE_BIT, @@ -202,7 +210,7 @@ static const struct spinand_info fmsh_spinand_table[] = { SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xd2), NAND_MEMORG(1, 2048, 128, 64, 2048, 41, 1, 1, 1), NAND_ECCREQ(8, 528), - SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + SPINAND_INFO_OP_VARIANTS(&fm25g_read_cache_variants, &write_cache_variants, &update_cache_variants), SPINAND_HAS_QE_BIT, -- 2.54.0