Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Add Qualcomm Maili video clock controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Spaces are used instead of tabs for macro value alignment.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: clock: qcom: Add Qualcomm Maili video clock controller ---
commit 1f9a58072beaf3de6334360055c245542fde73e1
Author: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

dt-bindings: clock: qcom: Add Qualcomm Maili video clock controller
    
This commit adds device tree bindings for the video clock controller on
the Qualcomm Maili SoC.

> diff --git a/include/dt-bindings/clock/qcom,maili-videocc.h b/include/dt-bindings/clock/qcom,maili-videocc.h
> new file mode 100644
> index 0000000000000..ae52686639db3
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,maili-videocc.h

[ ... ]

> +/* VIDEO_CC resets */
> +#define VIDEO_CC_INTERFACE_BCR					0
> +#define VIDEO_CC_MVS0_BCR					1
> +#define VIDEO_CC_MVS0_CLK_ARES					2
> +#define VIDEO_CC_MVS0_FREERUN_CLK_ARES				3
> +#define VIDEO_CC_MVS0_VPP0_BCR					4
> +#define VIDEO_CC_MVS0C_BCR					5
> +#define VIDEO_CC_MVS0C_CLK_ARES					6
> +#define VIDEO_CC_MVS0C_FREERUN_CLK_ARES                         7

[Severity: Low]
Could we use tabs to align the value for VIDEO_CC_MVS0C_FREERUN_CLK_ARES
instead of spaces?

> +#define VIDEO_CC_XO_CLK_ARES					8
> +
> +#endif

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-maili_videocc-v2-0-7ed5ab140770@oss.qualcomm.com?part=1