From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, robh@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v5 2/6] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC
Date: Thu, 16 Jul 2026 06:14:45 +0000 [thread overview]
Message-ID: <20260716061445.A1D231F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716055751.279033-2-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Devicetree Makefile targets for rev900 and rev902 LVDS boards incorrectly include the DSI-to-LVDS adapter overlay instead of the native LVDS overlay.
--
--- Patch [2]: [PATCH v5 2/6] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC ---
commit 9cbdc6e353675bf76d693179ba857291f2e7ba5e
Author: Marek Vasut <marex@nabladev.com>
arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC
This patch adds legacy board revision compatibility DT overlays for both
i.MX8M Mini and Plus eDM SBC boards. It also includes adjustments to
support legacy board revisions.
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index fbfd0e79f118d..09ea330884ad4 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
[ ... ]
> @@ -338,6 +344,24 @@ imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-mi1010z1t-1cp11-dtbs := \
> imx8mp-data-modul-edm-sbc.dtb \
> imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-mi1010z1t-1cp11.dtbo
>
> +imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900-dtbs := \
> + imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-rev900.dtb \
> + imx8mp-data-modul-edm-sbc-overlay-edm-mod-imx8mm-lvds-g070y2-l01.dtbo \
> + imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtbo
> +
> +imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev902-dtbs := \
> + imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-rev902.dtb \
> + imx8mp-data-modul-edm-sbc-overlay-edm-mod-imx8mm-lvds-g070y2-l01.dtbo \
> + imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev902.dtbo
[Severity: Medium]
Do these targets incorrectly include the DSI-to-LVDS adapter overlay
(edm-mod-imx8mm) instead of the native LVDS overlay (edm-sbc-imx8mp-lvds)
for the SBC?
If so, this might cause the LVDS display pipeline for the rev900 and rev902
i.MX8MP SBCs to be misconfigured. They might expect the lt9211 DSI-to-LVDS
adapter instead of the native lcdif2 and lvds_bridge, which could lead to a
display probe failure at runtime.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716055751.279033-1-marex@nabladev.com?part=2
next prev parent reply other threads:[~2026-07-16 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 5:56 [PATCH v5 1/6] arm64: dts: imx8mm: imx8mp: Add LVDS DTOs for Data Modul i.MX8M Mini and Plus eDM SBC Marek Vasut
2026-07-16 5:56 ` [PATCH v5 2/6] arm64: dts: imx8mm: imx8mp: Add legacy board " Marek Vasut
2026-07-16 6:14 ` sashiko-bot [this message]
2026-07-16 5:56 ` [PATCH v5 3/6] arm64: dts: imx8mm: imx8mp: Add HDMI " Marek Vasut
2026-07-16 5:56 ` [PATCH v5 4/6] arm64: dts: imx8mm: imx8mp: Add CM " Marek Vasut
2026-07-16 6:08 ` sashiko-bot
2026-07-16 5:56 ` [PATCH v5 5/6] arm64: dts: imx8mm: imx8mp: Add FIO1 " Marek Vasut
2026-07-16 6:13 ` sashiko-bot
2026-07-16 5:56 ` [PATCH v5 6/6] arm64: dts: imx8mm: imx8mp: Add FIO1-Audio " Marek Vasut
2026-07-16 6:23 ` sashiko-bot
2026-07-16 6:10 ` [PATCH v5 1/6] arm64: dts: imx8mm: imx8mp: Add LVDS " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716061445.A1D231F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.