All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shlok Kulshreshtha <diy2903@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Shlok Kulshreshtha <diy2903@gmail.com>
Subject: Re: [PATCH] t7614: avoid hiding git's exit code in a pipe
Date: Thu, 16 Jul 2026 12:42:54 +0530	[thread overview]
Message-ID: <20260716071254.14953-1-diy2903@gmail.com> (raw)
In-Reply-To: <xmqq1pd4m4ea.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> All look trivially correct.

Thanks for the review.

>  * This "cat-file the commit object, and strip away the object
>    header with sed" pattern appears quite often throughout the test
>    suite.
> [...]
>    or something like that.
>
> But again, these are clearly outside the scope of this patch.

Agreed on keeping them out of this patch.  I'd like to take up the
commit_body() helper as a separate follow-up once this lands, and
convert the existing "cat-file ... | sed" call sites (including the
unnecessary backslash before the dollar sign) over to it.

Thanks,
Shlok

      reply	other threads:[~2026-07-16  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 11:33 [PATCH] t7614: avoid hiding git's exit code in a pipe Shlok Kulshreshtha
2026-07-15 19:36 ` Junio C Hamano
2026-07-16  7:12   ` Shlok Kulshreshtha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716071254.14953-1-diy2903@gmail.com \
    --to=diy2903@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.