Re: [PATCH 12/22] iio: dac: max517: Remove redundant i2c_master_send() length check

[Joshua Crofts <joshua.crofts1@gmail.com>]

On Wed, 15 Jul 2026 17:57:27 -0700
Jonathan Cameron <jonathan.cameron@oss.qualcomm.com> wrote:

> i2c_master_send() returns either a negative errno or exactly the count
> passed in, so the length check after the 'ret < 0' test can never be
> true. Drop the dead branch.
> 
> Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> Assisted-by: Claude:claude-opus-4-8
> ---
>  drivers/iio/dac/max517.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
> index d2ddc72e0e50..e0d1a26c4f73 100644
> --- a/drivers/iio/dac/max517.c
> +++ b/drivers/iio/dac/max517.c
> @@ -55,10 +55,8 @@ static int max517_set_value(struct iio_dev *indio_dev,
>  	res = i2c_master_send(client, outbuf, 2);

Someone should also remove all the hard-coded sizes, they appear in multiple
drivers you're touching.

-- 
Kind regards

CJD