From: Bin Guo <guobin@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, farosas@suse.de
Subject: [PATCH 3/3] migration: clean up postcopy blocktime presentation
Date: Thu, 16 Jul 2026 18:19:52 +0800 [thread overview]
Message-ID: <20260716101952.65329-4-guobin@linux.alibaba.com> (raw)
In-Reply-To: <20260716101952.65329-1-guobin@linux.alibaba.com>
Small cleanups for the postcopy blocktime fine-grained tracking
feature:
* Remove a redundant memset() on latency_buckets after g_new0().
* Use singular "Latency" in the HMP label for postcopy non-vCPU
latency, consistent with other single-value labels.
Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
migration/migration-hmp-cmds.c | 2 +-
migration/postcopy-ram.c | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 6bedf786df..4a18ca8bba 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -96,7 +96,7 @@ static void migration_dump_blocktime(Monitor *mon, MigrationInfo *info)
}
if (info->has_postcopy_non_vcpu_latency) {
- monitor_printf(mon, "Postcopy non-vCPU Latencies (ns): %" PRIu64 "\n",
+ monitor_printf(mon, "Postcopy non-vCPU Latency (ns): %" PRIu64 "\n",
info->postcopy_non_vcpu_latency);
}
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 341cad264a..28d698260e 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -297,9 +297,6 @@ static struct PostcopyBlocktimeContext *blocktime_context_new(void)
unsigned int smp_cpus = ms->smp.cpus;
PostcopyBlocktimeContext *ctx = g_new0(PostcopyBlocktimeContext, 1);
- /* Initialize all counters to be zeros */
- memset(ctx->latency_buckets, 0, sizeof(ctx->latency_buckets));
-
ctx->vcpu_blocktime_total = g_new0(uint64_t, smp_cpus);
ctx->vcpu_faults_count = g_new0(uint64_t, smp_cpus);
ctx->vcpu_faults_current = g_new0(uint8_t, smp_cpus);
--
2.50.1 (Apple Git-155)
prev parent reply other threads:[~2026-07-16 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 10:19 [PATCH 0/3] migration: postcopy blocktime cleanups and assert fix Bin Guo
2026-07-16 10:19 ` [PATCH 1/3] migration: fix ineffective overflow assert in postcopy blocktime Bin Guo
2026-07-16 10:19 ` [PATCH 2/3] migration: fix const mismatch in format_time_str() Bin Guo
2026-07-16 10:19 ` Bin Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716101952.65329-4-guobin@linux.alibaba.com \
--to=guobin@linux.alibaba.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.