From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7AAA28505E; Thu, 16 Jul 2026 14:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211835; cv=none; b=ujS9fUE9ZZoGB19H2J6Zyi9OYpYJEItT3Qjx5sv232lN3O/vfVJz/FrcXjd2DrS5CjtfvbFObO8EoO74NLV7AbL0Ti38Duef2+W5IhO6N6+dvw7+m7tIoMONnwY6E40OxgUITA/pQBikj509tLw3RNCBDHHhofsuaQuqWOtrEuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211835; c=relaxed/simple; bh=RZ9c32wP7rtassSrZFj3ufauMz0bUFQ6DDJkF+oATYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q1PPx9WebLtYXMdqsINVUCLR7sOTH8PGFEtFLjqcw9P3xYTjpZU9Eql7ABikpb2Qr4L/xv4sUYAJohBUgwq6LRT8Ivnb4YOkQXW/HNB+Cj3gUpxIWob93xsKmOenDOpFteJAvYEtvZsluzRuRHDQWyXZk3BdM4ugnjzi6hiktA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BpI5xyXr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BpI5xyXr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 388BF1F000E9; Thu, 16 Jul 2026 14:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784211834; bh=clUhW2bOaar4wJYFCmIW67loArVTGi8SoByKsKT5+bw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BpI5xyXrb2BC1YOQwtTl3f8hYlzBZcHYf4gVGJjTvqiWiuhLOHjuKXuE/pQqk5BxF tY9y01/rU4JI+7OnbnMYR8v02tNO382ZQiwG2JsswQq+D7VwVerM6WF8tdzK/GL+Zl V8GrMEH39J6naOW0tNqpwhjqJvR6XKmp7GGEd9Cw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stepan Ionichev , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 6.12 054/349] iio: gyro: bmg160: bail out when bandwidth/filter is not in table Date: Thu, 16 Jul 2026 15:29:48 +0200 Message-ID: <20260716133034.534591342@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133033.287196923@linuxfoundation.org> References: <20260716133033.287196923@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stepan Ionichev commit 8320c77e67382d5d55d77043a5f60a867d408a2b upstream. bmg160_get_filter() walks bmg160_samp_freq_table[] looking for the entry matching the bw_bits value read from the chip: for (i = 0; i < ARRAY_SIZE(bmg160_samp_freq_table); ++i) { if (bmg160_samp_freq_table[i].bw_bits == bw_bits) break; } *val = bmg160_samp_freq_table[i].filter; If no entry matches, i ends up equal to the array size and the next line reads one slot past the end. bmg160_set_filter() has the same shape, driven by 'val' instead of bw_bits. smatch flags both: drivers/iio/gyro/bmg160_core.c:204 bmg160_get_filter() error: buffer overflow 'bmg160_samp_freq_table' 7 <= 7 drivers/iio/gyro/bmg160_core.c:222 bmg160_set_filter() error: buffer overflow 'bmg160_samp_freq_table' 7 <= 7 Return -EINVAL when no entry matches. The set_filter() path is reachable from userspace via the sysfs in_anglvel_filter_low_pass_3db_frequency interface, so userspace can trivially trigger the out-of-bounds read with a value that is not in bmg160_samp_freq_table[].filter. Fixes: 22b46c45fb9b ("iio:gyro:bmg160 Gyro Sensor driver") Signed-off-by: Stepan Ionichev Reviewed-by: Andy Shevchenko Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/gyro/bmg160_core.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/iio/gyro/bmg160_core.c +++ b/drivers/iio/gyro/bmg160_core.c @@ -204,6 +204,9 @@ static int bmg160_get_filter(struct bmg1 break; } + if (i == ARRAY_SIZE(bmg160_samp_freq_table)) + return -EINVAL; + *val = bmg160_samp_freq_table[i].filter; return ret ? ret : IIO_VAL_INT; @@ -221,6 +224,9 @@ static int bmg160_set_filter(struct bmg1 break; } + if (i == ARRAY_SIZE(bmg160_samp_freq_table)) + return -EINVAL; + ret = regmap_write(data->regmap, BMG160_REG_PMU_BW, bmg160_samp_freq_table[i].bw_bits); if (ret < 0) {