From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A64142A7B7; Thu, 16 Jul 2026 14:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211969; cv=none; b=hvafFtgR7q2vMgvH2q4dZ9Kf7R4om1aFz2KU52ZZ8GwBMcDgQkXQ1O5piCYUwX6Yc0zFsq7wQLqfFnIWIem6FzUrD4Ihx9+AYw+HnI06ZuYiGNipnMGJlXsZeWcO6it1Cd83wIyTOixm58IPUkLpmeoeiAPPOQ67keHzmemYPqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211969; c=relaxed/simple; bh=luWDKyAT/h/9gF/fFQY53aUbDf8ej7ZafqHW7Zfo2LI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U532sHE+rGyMxdRSpmUwEPj+mNhS/nIvx2Ck3iuCHReBKWj9dsVVRRm/dfbEKAyrdZKRHn1d8oGsEUZ1hu5UHBGz0c0lcOHDJTSGafy+DiDCG1wjpq4ZJqfKa7m/QdQKz4QC22GOoeAc4PaVjDnAxU8abJVOHfEjyo70Zcg17Bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ODNspzQX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ODNspzQX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C70B1F000E9; Thu, 16 Jul 2026 14:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784211968; bh=GGl1aaWo2WRLkkO+jeHBJFrXYJ78GDvFuro0ugaNMGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ODNspzQXtt6gQVfh3MynZTvmkRjhw6OYGdn9JwarB+c5d4jlLRlQdZPW/KF6R0nPn IY782QBO1510GkD24uF5ZpGMuvDQLpPdEJG/rjAyvTX82WI1QYjU2rDYNEa5wGlgbk JVd6c/NCf72dn2wzjG+lHWdIuLsp/qbtYfTyHFT0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rajat Jain , Johan Hovold , Luiz Augusto von Dentz Subject: [PATCH 6.12 096/349] Bluetooth: btusb: fix wakeup source leak on probe failure Date: Thu, 16 Jul 2026 15:30:30 +0200 Message-ID: <20260716133035.464135775@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133033.287196923@linuxfoundation.org> References: <20260716133033.287196923@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 3d93e1bb0fb881fe3ef961d1120556658e9cac4d upstream. Make sure to disable wakeup on probe failure to avoid leaking the wakeup source. Fixes: fd913ef7ce61 ("Bluetooth: btusb: Add out-of-band wakeup support") Cc: stable@vger.kernel.org # 4.11 Cc: Rajat Jain Signed-off-by: Johan Hovold Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/btusb.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2925,6 +2925,11 @@ static int marvell_config_oob_wake(struc return 0; } +#else +static inline int marvell_config_oob_wake(struct hci_dev *hdev) +{ + return 0; +} #endif static int btusb_set_bdaddr_marvell(struct hci_dev *hdev, @@ -3739,6 +3744,11 @@ static int btusb_config_oob_wake(struct bt_dev_info(hdev, "OOB Wake-on-BT configured at IRQ %u", irq); return 0; } +#else +static inline int btusb_config_oob_wake(struct hci_dev *hdev) +{ + return 0; +} #endif static void btusb_check_needs_reset_resume(struct usb_interface *intf) @@ -3962,7 +3972,6 @@ static int btusb_probe(struct usb_interf hdev->notify = btusb_notify; hdev->wakeup = btusb_wakeup; -#ifdef CONFIG_PM err = btusb_config_oob_wake(hdev); if (err) goto out_free_dev; @@ -3971,9 +3980,9 @@ static int btusb_probe(struct usb_interf if (id->driver_info & BTUSB_MARVELL && data->oob_wake_irq) { err = marvell_config_oob_wake(hdev); if (err) - goto out_free_dev; + goto err_disable_wakeup; } -#endif + if (id->driver_info & BTUSB_CW6622) set_bit(HCI_QUIRK_BROKEN_STORED_LINK_KEY, &hdev->quirks); @@ -4216,6 +4225,9 @@ err_release_siblings: } err_kill_tx_urbs: usb_kill_anchored_urbs(&data->tx_anchor); +err_disable_wakeup: + if (data->oob_wake_irq) + device_init_wakeup(&data->udev->dev, false); out_free_dev: if (data->reset_gpio) gpiod_put(data->reset_gpio);