From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5BD3195EF; Thu, 16 Jul 2026 14:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784210877; cv=none; b=h4kAx/PIs4xpR0+K9L1Jc22wRfmADkIdyS8ljLDqxSAE4j+BCEu3VpVw44F1wGHkRfsalWtuHHRZQ2hWKVJveFCCpTt1ZG5L3T1uoJyISvgJiCxhhrSx8tECH0E4LFTNoPg/TU5viDkmmVd9G9zygsaYYhNDb2clzwDkHvNpIac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784210877; c=relaxed/simple; bh=AX0w79ydSxbMSNfOi/rYnx0NEmoWFKO+jEMKCiK8A5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J/rNf9KLUyx/bLQCJ5TEMrG528Pl4wplU3m8EF3PK/L/GYhlzpWoiCdyJ9SwJ9cLynv5mafVI6fOFg22xEQLA1PIxUdZCrUsluu95X1JAHEhjFIAwViXgOMq3z2QyPmlML9RVQ9k9S3mxEYBAYQuma/bMDnYkXq5XFUpZRA6EFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KgsgCZpJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KgsgCZpJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C19F1F000E9; Thu, 16 Jul 2026 14:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784210875; bh=nrc3arxxDV1tvHhtCa9jRss/t2q8wFmBEelfqIKDVCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KgsgCZpJpz7vUZMerfLW8x157+kH+boE0pj93hhS14DSGMWdeVugN4mKGetjjc6iR yih5v65wTfVowsgfOlUp0cYUnFwPZM/UZ/IWyc/w5E6cA08/n+NKBXkwyuqfV/CdgS YN0W0sXYftaENBArsws4u8pTXo+cbVhMn8ShUUMU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+c1e9aedbd913fadad617@syzkaller.appspotmail.com, Deepanshu Kartikey , Konstantin Komarov , Sasha Levin Subject: [PATCH 6.18 213/480] fs/ntfs3: fix missing run load for vcn0 in attr_data_get_block_locked() Date: Thu, 16 Jul 2026 15:29:20 +0200 Message-ID: <20260716133049.341526097@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133044.672218725@linuxfoundation.org> References: <20260716133044.672218725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Deepanshu Kartikey [ Upstream commit d7ea8495fd307b58f8867acd81a1b40075b1d3ba ] When a compressed or sparse attribute has its clusters frame-aligned, vcn is rounded down to the frame start using cmask, which can result in vcn != vcn0. In this case, vcn and vcn0 may reside in different attribute segments. The code already handles the case where vcn is in a different segment by loading its runs before allocation. However, it fails to load runs for vcn0 when vcn0 resides in a different segment than vcn. This causes run_lookup_entry() to return SPARSE_LCN for vcn0 since its segment was never loaded into the in-memory run list, triggering the WARN_ON(1). Fix this by adding a missing check for vcn0 after the existing vcn segment check. If vcn0 falls outside the current segment range [svcn, evcn1), find and load the attribute segment containing vcn0 before performing the run lookup. The following scenario triggers the bug: attr_data_get_block_locked() vcn = vcn0 & cmask <- vcn != vcn0 after frame alignment load runs for vcn segment <- vcn0 segment not loaded! attr_allocate_clusters() <- allocation succeeds run_lookup_entry(vcn0) <- vcn0 not in run -> SPARSE_LCN WARN_ON(1) <- bug fires here! Reported-by: syzbot+c1e9aedbd913fadad617@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c1e9aedbd913fadad617 Fixes: c380b52f6c57 ("fs/ntfs3: Change new sparse cluster processing") Signed-off-by: Deepanshu Kartikey Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/attrib.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c index 5a7675112e7b8a..501f2ec153ab87 100644 --- a/fs/ntfs3/attrib.c +++ b/fs/ntfs3/attrib.c @@ -1045,6 +1045,20 @@ int attr_data_get_block(struct ntfs_inode *ni, CLST vcn, CLST clen, CLST *lcn, if (err) goto out; } + + if (vcn0 < svcn || evcn1 <= vcn0) { + struct ATTRIB *attr2; + + attr2 = ni_find_attr(ni, attr_b, &le_b, ATTR_DATA, NULL, + 0, &vcn0, &mi); + if (!attr2) { + err = -EINVAL; + goto out; + } + err = attr_load_runs(attr2, ni, run, NULL); + if (err) + goto out; + } } if (vcn + to_alloc > asize) -- 2.53.0