From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80AFE3BED2D; Thu, 16 Jul 2026 13:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209164; cv=none; b=aEh7CHS8LsMmImNfS3KWZ5GJ/LyAE1PDhQdEr/bwtj560MCoyBK84a19XcDeUYB8cvomHafFQ0OfxTJTEciEvJxwejwoXgLnQ3HTSAbr+y3+6LvUGAiM5xxVmZ3QayBCc9qUGVWqAq3PK4KY05RFBB0WEVzmEVLPs8TiECrhSyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209164; c=relaxed/simple; bh=MMV7bQ87v+ou9TGdoEbJUAlR0XK+hj+2iCzjeWla03Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VrPNyuy3ZVFlRCU2NS+j4bs6PTyppVrZgQqE8uFbPDkfXJT95CWsv9B72fsNZNm24q9jbE5iG0soE8v0l13xONE/h4YBXHLelmECBbkZqnj6iMO2s0XHnsWm0hZmC+ei8tPtsmxDzUNqYzLcjQ+BhouZ9OUNMgcFceJ9oJLXkRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l0SX9UUs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l0SX9UUs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E51E51F000E9; Thu, 16 Jul 2026 13:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784209163; bh=NW4gjR0Lldap8UzJYX0WQmYYasBRoMzzhYIWDZHBtGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=l0SX9UUs72iu6aIckVh3Bbdtv4lFzODe+hfJLTnml7GQ4hmaijzyltnUtCc90FIud WzovRjwQ8GD9/YTWXz1jarJT6jxQ4FKFFgfURnJWn7NDGrVH84motcaHbzm4NMtF3y uzZ79ShknlRLEjlDG+4oAtIGuXDVIMeBCZFvVFbU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhao Dongdong , Takashi Iwai Subject: [PATCH 7.1 082/518] ALSA: ymfpci: check snd_ctl_new1() return value Date: Thu, 16 Jul 2026 15:25:50 +0200 Message-ID: <20260716133049.582965530@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133047.772246337@linuxfoundation.org> References: <20260716133047.772246337@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhao Dongdong commit e64d170346d00b580c0043de3e5ccb3e331c47d4 upstream. snd_ctl_new1() can return NULL when memory allocation fails. snd_ymfpci_create_spdif_controls() does not check the return value before dereferencing kctl->id.device, which can lead to a NULL pointer dereference. Add NULL checks after snd_ctl_new1() calls and return -ENOMEM if any fails. Assisted-by: Opencode:DeepSeek-V4-Flash Cc: stable@vger.kernel.org Fixes: c9b83ae4a160 ("ALSA: ymfpci: Fix kctl->id initialization") Signed-off-by: Zhao Dongdong Link: https://patch.msgid.link/tencent_4745C5DC2333325C0EDAB1EFC88A136E6809@qq.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/ymfpci/ymfpci_main.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/sound/pci/ymfpci/ymfpci_main.c +++ b/sound/pci/ymfpci/ymfpci_main.c @@ -1781,16 +1781,22 @@ int snd_ymfpci_mixer(struct snd_ymfpci * if (snd_BUG_ON(!chip->pcm_spdif)) return -ENXIO; kctl = snd_ctl_new1(&snd_ymfpci_spdif_default, chip); + if (!kctl) + return -ENOMEM; kctl->id.device = chip->pcm_spdif->device; err = snd_ctl_add(chip->card, kctl); if (err < 0) return err; kctl = snd_ctl_new1(&snd_ymfpci_spdif_mask, chip); + if (!kctl) + return -ENOMEM; kctl->id.device = chip->pcm_spdif->device; err = snd_ctl_add(chip->card, kctl); if (err < 0) return err; kctl = snd_ctl_new1(&snd_ymfpci_spdif_stream, chip); + if (!kctl) + return -ENOMEM; kctl->id.device = chip->pcm_spdif->device; err = snd_ctl_add(chip->card, kctl); if (err < 0)