From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7292C0F69; Thu, 16 Jul 2026 14:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211497; cv=none; b=ZFkeRyQckOBV8feWjzHsOeUWc+Surp/+8pvHeDJq1cHf91XlaWYzW9F2MxWXYdpYCB7leSVfWM46umqrY8EDtU2Pnst9stIhMFBEJSYh8TOw1MHCLcW8FbSnsWnZ3UvbjhZbc+GiBp3Ffxbi/J4HQoZzmDclixsBPNzBKx7xJyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784211497; c=relaxed/simple; bh=zGcsvxvG022TenhVlBHS6Xm1alovwPMniz2Me6BnINE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S1wLd693DcETRIIcTC2OhFzKrT08R1wGN3Jnr9bMiZQo3bFzzHx2T7Y+UJHxeBFf0okVUy4L6VtNAZZlY9T60D8Sv71PzgSR4X1m7PKS2L8EF1clRZ/FIdbwie6MNv5vYWjsOyZxMq7Lnt9JAr5v0vsbgdw8jt9K/jvCaN4pu8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=svsD/MLP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="svsD/MLP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9591F000E9; Thu, 16 Jul 2026 14:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784211495; bh=LKnW6BAB2V+kAkP2ptD++LIlUiPIDzgLX3OGGnCju+0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=svsD/MLPCcAXs2Zb/zI03/yN/IxOHMQGoqy6dgh/PcciXDhf9UDRXehADciKd9Mn6 Zmeb0twu5mjrhSBY8YkXslkqzb6WdwsapiSZEamkkTaERtYje+EgyauQ7dLW7//8bI 2EWVLD2faa37m4KI30AJk8wCU0i47GE80k0qnVzg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot@kernel.org, Bryam Vargas , Dmitry Torokhov Subject: [PATCH 6.18 449/480] Input: mms114 - fix touch indexing for MMS134S and MMS136 Date: Thu, 16 Jul 2026 15:33:16 +0200 Message-ID: <20260716133054.536178092@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716133044.672218725@linuxfoundation.org> References: <20260716133044.672218725@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Torokhov commit a6ac4e24c1a8a533bb61035184fdcc7eede4cc8d upstream. The MMS134S and MMS136 touch controllers have an event size of 6 bytes rather than 8 bytes. When __mms114_read_reg() reads the touch data packet from the device into the touch buffer, the events are packed tightly at 6-byte intervals. However, the driver iterates through the events using standard C array indexing (touch[index]), where each element is sizeof(struct mms114_touch) (8 bytes) apart. As a result, any touch events beyond the first one are read from incorrect offsets and parsed improperly. Fix this by explicitly calculating the byte offset for each touch event based on the device's specific event size. Fixes: 53fefdd1d3a3 ("Input: mms114 - support MMS136") Fixes: ab108678195f ("Input: mms114 - support MMS134S") Reported-by: sashiko-bot@kernel.org Assisted-by: Antigravity:gemini-3.5-flash Reviewed-by: Bryam Vargas Link: https://patch.msgid.link/20260616050912.1531241-1-dmitry.torokhov@gmail.com Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/mms114.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) --- a/drivers/input/touchscreen/mms114.c +++ b/drivers/input/touchscreen/mms114.c @@ -218,7 +218,9 @@ static irqreturn_t mms114_interrupt(int struct i2c_client *client = data->client; struct input_dev *input_dev = data->input_dev; struct mms114_touch touch[MMS114_MAX_TOUCH]; + struct mms114_touch *t; int packet_size; + int event_size; int touch_size; int index; int error; @@ -236,9 +238,11 @@ static irqreturn_t mms114_interrupt(int /* MMS136 has slightly different event size */ if (data->type == TYPE_MMS134S || data->type == TYPE_MMS136) - touch_size = packet_size / MMS136_EVENT_SIZE; + event_size = MMS136_EVENT_SIZE; else - touch_size = packet_size / MMS114_EVENT_SIZE; + event_size = MMS114_EVENT_SIZE; + + touch_size = packet_size / event_size; error = __mms114_read_reg(data, MMS114_INFORMATION, packet_size, (u8 *)touch); @@ -246,18 +250,20 @@ static irqreturn_t mms114_interrupt(int goto out; for (index = 0; index < touch_size; index++) { - switch (touch[index].type) { + t = (struct mms114_touch *)((u8 *)touch + index * event_size); + + switch (t->type) { case MMS114_TYPE_TOUCHSCREEN: - mms114_process_mt(data, touch + index); + mms114_process_mt(data, t); break; case MMS114_TYPE_TOUCHKEY: - mms114_process_touchkey(data, touch + index); + mms114_process_touchkey(data, t); break; default: dev_err(&client->dev, "Wrong touch type (%d)\n", - touch[index].type); + t->type); break; } }