From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788E641D63D for ; Thu, 16 Jul 2026 13:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207115; cv=none; b=DlOh7fmoMJsEZnfX0IBkmMsT/89JyMhSASqnFxGS1jTdn+Y1tqN6UCnw7+zdotIwhK0aWKq14zKBRV6d8Xpa0mls3UFlBqyr2qh2P0sOZ6qI+3KoeMG8e0oFhF7S28bQVBMcZt92QQLB9bqXPwVLdpIYLLk8Ef6PPeAVb+aVf9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784207115; c=relaxed/simple; bh=Ph5O7sdd3xwfE3bGAXgs+upkajj44wtizah1gh+lDoM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cRdhiO9nI1/jZsqMdG4sLTvgjpOFGrpfMuTsxZNZbJ+BUH5pyii3/YwCBB4hrEvkEO/v3RBin1wDKQyZ8O4holMXW0AboJ60QlXR3KhXnamjJ8YgTG1/CUum2MN9GvCIKb7erkIdkd61A7NYT6Kf3ROYyLcXIIABTkKjjvDPXxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QCidRpY5; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QCidRpY5" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-493f431e317so23834175e9.0 for ; Thu, 16 Jul 2026 06:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784207113; x=1784811913; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HkXEhjWw8RR39Frioop/yuVyZX8tqDl1VlP5PStyz6E=; b=QCidRpY5AiaVnAGt/yYU+uDtue9x62zA+cXUGm40lcq9F61JrpLXcF9VtcxXSjo1vv qhzNqXq3KxPXAW190NuvTegi2UNDwCCtJhNxaXR+MIPGhgQ2Dm6jnQf8/XGsddWZywtu tK0YPLZ7FZ4rSxKp29JCbBRD9afsHb0bt87y01CS27vUiSOUx06fTcDR2IfjGJ/f4yuG ljfyls41AveZEoFpkyfrKWFyjxZ8F7vtFj5t9u7WhhJNHJySsiCRelAr6kQBexJhY+dg hPA3V4nrXC21Hem5fA8vX1aLOMdNjALlaZAI1QHKCGpxcHKQIvyfKvDj+1OMRUjWvHLL wQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784207113; x=1784811913; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HkXEhjWw8RR39Frioop/yuVyZX8tqDl1VlP5PStyz6E=; b=JtREEDJx4oHbmaxAEkD2XCuoGAkEFQZKwZRFOH45+81P1O1Db2EFvuoV30afGi706v tssVEvvBdyOP7nFS6c3Bqs7q0oBMQgDAd2LhZGYjhosS0jU8XTHS1PYM4w06nXTmJQET tY8oC5orCZuLN0J2olou5cH85Kb9zKz46xIOI0AQZmhH5P9fpZg/9ogyBUhfYOe/hAFa deya+13aHMvS1mUXQeZ98fhJfMHuUml85y7Q+KxXLmERJd6TxRoKuu+2la3V7QZeJmDJ wofzV1LLSvF9G47oPp+s6z6v44xHiaikMDYPlM73PiU7t1uILtHoVJthKiPvXVt0Kfrt /XZw== X-Forwarded-Encrypted: i=1; AHgh+Rp4Da2e+y7SIzdVrAml1OLI1zp/UnquBN8rB+2s66O/ofrDCrLc+fa1317cMrKq9mprFfiyDQVbUig2R24=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi0U50XzPGL8aKIuRQlX32FIC/7C3R5xAD0+KEOPoljepPYMOQ n6UssFhFgQQyYluQ4kiPr5dJ5Hjp13FiKxBeJsUO1AXDh5md3K0XfVK1 X-Gm-Gg: AfdE7ckpoNWIPcuqNUizfkzxFUdqGZ8xNHez6NvD1VXI9H01DBQkqVr/dBIWjW6r2f/ /8JINFcYq2b58YAliXSOYpQkdhT+HNFxEJlzWxPJ65CL8IcuJ6QV3OhJly5xOhqhna+iKx3GWqe FZjxPRBzpU2h4ObsP5M3CZ0/p5vq/SiSTDr6ZFA2RAjojMAZdfKoEbdtKCCmYLBVh+ouFKG74db xXXtkCkuVTjreZVazwIWUZ5RXx623VlGgcnfSeZc9mRRQMfrtrHjrq5ZOh329EuNhe7Kn8anOWy R2RescGwVlfCr5QIvpobUMNLFVuMH2cgiHTxkZHms0X0Yovu8qhEVSXzpzkmk9xR8p1UN2S7ETc BxF+eh0ejhhzm0QpONxrgp6bY+XPfQOhEm9fe552nagFgwTbBQJPdHmrOPF1qDg36L3FbuHzI2n BHhoo3l37vTlrg3qSN2+L7Zzas1IQF5KQE8+gzHCis8sMEN36/iZ+6uqf9qblrn9CugBdi56Kli 5MGyCLJBM7NVvWJSncsJXHYGNxLjVbRmQMpgmV0GttT9qLYfSUQRjkGTfK3YvV2jCUIsLX9cXFe wJL1vqLNOPAQRfKeV6pqhd+AdZSgxnoClZb5YO35rRLcAFL7gXLYv2vYxrxx26jTuljXZtxBbXJ aqiD8GqhrZDVW X-Received: by 2002:a05:600c:354e:b0:493:e38b:182d with SMTP id 5b1f17b1804b1-493f881800dmr243163685e9.22.1784207112542; Thu, 16 Jul 2026 06:05:12 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49541e7d22asm57635025e9.1.2026.07.16.06.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 06:05:12 -0700 (PDT) Date: Thu, 16 Jul 2026 15:05:09 +0200 From: Joshua Crofts To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" , sashiko-bot@kernel.org Subject: Re: [PATCH v8 2/8] iio: dac: ad5686: missing NULL check on match data Message-ID: <20260716150509.00002557@gmail.com> In-Reply-To: <20260716-ad5686-new-features-v8-2-ebb0051af5e5@analog.com> References: <20260716-ad5686-new-features-v8-0-ebb0051af5e5@analog.com> <20260716-ad5686-new-features-v8-2-ebb0051af5e5@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 16 Jul 2026 13:14:18 +0100 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Verify that chip_info pointer is not NULL. If a user binds the driver > using driver_override via sysfs with a device name not present in the > id_table or of_match_table, match data will be NULL. > > Fixes: 0eb1728461a1 ("iio: dac: ad5686: drop enum id") > Reported-by: sashiko-bot@kernel.org > Closes: https://lore.kernel.org/all/20260710113149.53EC51F000E9@smtp.kernel.org/ > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/dac/ad5686.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c > index 713fe71ad1e7..d34250647aa4 100644 > --- a/drivers/iio/dac/ad5686.c > +++ b/drivers/iio/dac/ad5686.c > @@ -479,6 +479,9 @@ int ad5686_probe(struct device *dev, > struct iio_dev *indio_dev; > int ret, i; > > + if (!chip_info) > + return -ENODEV; > + > indio_dev = devm_iio_device_alloc(dev, sizeof(*st)); > if (indio_dev == NULL) > return -ENOMEM; > LGTM. Reviewed-by: Joshua Crofts -- Kind regards CJD