From: sashiko-bot@kernel.org
To: "Jiayuan Chen" <jiayuan.chen@linux.dev>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Run arena tests serially
Date: Thu, 16 Jul 2026 15:27:35 +0000 [thread overview]
Message-ID: <20260716152735.DBC631F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716142746.8794-2-jiayuan.chen@linux.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete serialization of BPF arena tests leaves the CI environment vulnerable to OOM.
--
--- Patch [2]: [PATCH bpf-next 2/3] selftests/bpf: Run arena tests serially ---
commit 4661bf4c3b39723c6187b74928c316a1e721ac60
Author: Jiayuan Chen <jiayuan.chen@linux.dev>
selftests/bpf: Run arena tests serially
This commit changes several BPF arena tests to run serially to prevent memory
exhaustion during KASAN builds. By renaming the test functions to start with
serial_test_, the selftests framework ensures at most one arena is alive at a
time.
> Make the arena tests serial so at most one arena is alive at a time.
[Severity: High]
This is a pre-existing issue, but there are other tests that allocate
BPF_MAP_TYPE_ARENA maps which are still running in parallel.
For example, in tools/testing/selftests/bpf/prog_tests/verifier.c:
void test_verifier_arena(void) { RUN(verifier_arena); }
void test_verifier_arena_large(void) { RUN(verifier_arena_large); }
In tools/testing/selftests/bpf/prog_tests/stream.c:
void test_stream_success(void)
{
RUN_TESTS(stream);
return;
}
In tools/testing/selftests/bpf/prog_tests/compute_live_registers.c:
void test_compute_live_registers(void)
{
RUN_TESTS(compute_live_registers);
}
Since these remain prefixed with test_ rather than serial_test_, won't they
still run concurrently and potentially exhaust memory on KASAN builds?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716142746.8794-1-jiayuan.chen@linux.dev?part=2
next prev parent reply other threads:[~2026-07-16 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 14:24 [PATCH bpf-next 1/3] bpf: Add memory usage for arena Jiayuan Chen
2026-07-16 14:24 ` [PATCH bpf-next 2/3] selftests/bpf: Run arena tests serially Jiayuan Chen
2026-07-16 15:27 ` sashiko-bot [this message]
2026-07-16 14:25 ` [PATCH bpf-next 3/3] selftests/bpf: Add tests for memory usage for arena Jiayuan Chen
2026-07-16 15:40 ` sashiko-bot
2026-07-16 14:48 ` [PATCH bpf-next 1/3] bpf: Add " sashiko-bot
2026-07-16 15:31 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716152735.DBC631F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.