Re: [PATCH 5/7] dt-bindings: reset: Add bindings for MediaTek MT6589 reset controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The mediatek,mtk-wdt.yaml binding schema was not updated to require #reset-cells for the MT6589 watchdog hardware variant.
--

--- Patch [5]: [PATCH 5/7] dt-bindings: reset: Add bindings for MediaTek MT6589 reset controller ---
commit b3f415af68c03c846f8813bd551b69190964c62a
Author: Akari Tsuyukusa <akkun11.open@gmail.com>

dt-bindings: reset: Add bindings for MediaTek MT6589 reset controller

This commit adds the reset controller index definitions for the MediaTek
MT6589 SoC. It defines 12 reset lines under the TOPRGU controller.

> diff --git a/include/dt-bindings/reset/mt6589-resets.h b/include/dt-bindings/reset/mt6589-resets.h
> new file mode 100644
> --- /dev/null
> +++ b/include/dt-bindings/reset/mt6589-resets.h
> @@ -0,0 +1,25 @@
[ ... ]
> +/* TOPRGU */
> +#define MT6589_TOPRGU_INFRA_RST		0
> +#define MT6589_TOPRGU_DISP_RST		1
[ ... ]
> +#define MT6589_TOPRGU_PWRAP_SPICTL_RST	11
> +
> +#define MT6589_TOPRGU_RST_NUM		12
> +
> +#endif  /* _DT_BINDINGS_RESET_MT6589_RESETS_H */

[Severity: Medium]
Should Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml also
be updated to require the #reset-cells property for the MT6589 variant?

Since this patch introduces the MT6589 hardware as a reset provider, device 
tree nodes lacking the #reset-cells property for mediatek,mt6589-wdt might
incorrectly pass schema validation. Would it make sense to add an if-then
block to the YAML schema in this series to enforce the #reset-cells
requirement?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716161923.266315-1-akkun11.open@gmail.com?part=5