All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: alejandro.lucero-palau@amd.com, linux-cxl@vger.kernel.org,
	linux-acpi@vger.kernel.org, rafael@kernel.org,
	Alejandro Lucero <alucerop@amd.com>
Subject: Re: [PATCH v2 1/1] acpi/hmat: preserve hmat_adist_nb notifier block
Date: Thu, 16 Jul 2026 17:20:14 -0700	[thread overview]
Message-ID: <20260716172014.0000299c@oss.qualcomm.com> (raw)
In-Reply-To: <4b146ef6-ffa1-4406-b625-85fe05ed4604@intel.com>

On Thu, 16 Jul 2026 13:27:56 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> On 7/16/26 11:11 AM, alejandro.lucero-palau@amd.com wrote:
> > From: Alejandro Lucero <alucerop@amd.com>
> > 
> > Remove __meminitdata from hmat_adist_nb declaration preserving it even
> > when CONFIG_MEMORY_HOTPLUG is not set. Otherwise further notifier
> > registrations using register_mt_adistance_algorithm() will find a
> > notifier chain likely corrupted.
> > 
> > This is the case when cxl_region_probe() calls
> > register_mt_adistance_algorithm() what can happen when CXL regions
> > are dynamically created at any time from Type3 device(s) or when a Type2
> > device is initialized at its driver probe.
> > 
> > Fixes: 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT")
> > 

This will trip some of the checker scripts that run on various trees.
No blank lines in a commit tag block. I guess who ever picks this up
can tidy that up though rather than needing a v2.

> > Signed-off-by: Alejandro Lucero <alucerop@amd.com>  
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Seems sensible to me.

Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

> 
> 
> > ---
> >  drivers/acpi/numa/hmat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> > index 9792dc394756..3006789ae31f 100644
> > --- a/drivers/acpi/numa/hmat.c
> > +++ b/drivers/acpi/numa/hmat.c
> > @@ -995,7 +995,7 @@ static int hmat_calculate_adistance(struct notifier_block *self,
> >  	return NOTIFY_STOP;
> >  }
> >  
> > -static struct notifier_block hmat_adist_nb __meminitdata = {
> > +static struct notifier_block hmat_adist_nb = {
> >  	.notifier_call = hmat_calculate_adistance,
> >  	.priority = 100,
> >  };  
> 
> 


      reply	other threads:[~2026-07-17  0:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 18:11 [PATCH v2 0/1] Fix hmat_adist_nb for CXL alejandro.lucero-palau
2026-07-16 18:11 ` [PATCH v2 1/1] acpi/hmat: preserve hmat_adist_nb notifier block alejandro.lucero-palau
2026-07-16 20:27   ` Dave Jiang
2026-07-17  0:20     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716172014.0000299c@oss.qualcomm.com \
    --to=jonathan.cameron@oss.qualcomm.com \
    --cc=alejandro.lucero-palau@amd.com \
    --cc=alucerop@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.