Re: [PATCH V17 8/9] iio: imu: inv_icm42607: Add Temp Support in icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Temperature channel SCALE and OFFSET attributes are inaccessible because the parent `read_raw` wrappers incorrectly intercept and reject these requests.
--

--- Patch [8]: [PATCH V17 8/9] iio: imu: inv_icm42607: Add Temp Support in icm42607 ---
commit b01bd8621993e536d7296ab4582e3caee33a909a
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Temp Support in icm42607

Add functions for reading temperature sensor data.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> index 7bb67f232d191..9a44a180e5ccf 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
[ ... ]
> @@ -186,6 +189,9 @@ static int inv_icm42607_accel_read_raw(struct iio_dev *indio_dev,
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
> +		if (chan->type == IIO_TEMP)
> +			return inv_icm42607_temp_read_raw(indio_dev, chan,
> +							  val, val2, mask);
>  		ret = inv_icm42607_read_sensor(indio_dev, chan, &data);
>  		if (ret)
>  			return ret;

[Severity: Medium]
Will userspace be able to read the scale and offset attributes for the
temperature channel?

Since the delegation to inv_icm42607_temp_read_raw() only happens inside the
IIO_CHAN_INFO_RAW case, requests for IIO_CHAN_INFO_SCALE and
IIO_CHAN_INFO_OFFSET are not forwarded.

For example, when reading IIO_CHAN_INFO_SCALE, the code drops down to:

	case IIO_CHAN_INFO_SCALE:
		if (chan->type != IIO_ACCEL)
			return -EINVAL;

which evaluates to true and returns -EINVAL.

Could the check for IIO_TEMP be moved outside the switch statement so it
handles all masks? This same logic also appears to apply to
inv_icm42607_gyro_read_raw() in inv_icm42607_gyro.c.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716182637.24310-1-macroalpha82@gmail.com?part=8