From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C50225F98A for ; Thu, 16 Jul 2026 17:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784224333; cv=none; b=m+trv2oWGUlmFKyni8SCv4146Sw5cC1+3Eat7m7Vw9nEy+6aax6fprApu0Qg3aVKGGHiXBwyNCGa45gqds9IJbxHFdGWI6/3Wvpsob8CQ1IFhSGUXv709ze5S4j88/7wiMI74GN7ZbU+1lo5FgfzxWj3jsRSFknuPv9nHm3RxSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784224333; c=relaxed/simple; bh=J6v4npz3OThd8NQjBNodgNvNGgFRWZH0AmcNMYfCyjc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tFrEvWIeRgLuyg6In0jsrSVHwKNZEX+yvtTFRgfiz0HvZu8lTikKeD1l3p6GybidPvR4/onptd/qkT8XzKc5XFI6xuExCIP13H55iX6U4MuuA9WHc/RA4lH+Ped4dWTuFsIgteARA1Myum8HMrGxE/3i3548kIfOJGeQbWRm8R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ITU6MBCT; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ITU6MBCT" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4629051c9d1so2208761f8f.2 for ; Thu, 16 Jul 2026 10:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784224330; x=1784829130; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=d9HnM57cPoFNZBFEZlPJlObGF0jJpBNUfGKI2DBSN2g=; b=ITU6MBCTmY8cCiarH4sBrVD+51WCwM3zv7082fKRygB7cSBDc/7nx95vfc+fDD+QCh N4/w/M2sjFhgn8LNLDqosve+RStW7SVvgYbd7Mp3r+2hQQ+9K5XAlL0cLLtPA6HyTB6k lPxuFTGtDJeBqxZjs3ivizSFWu6QcDQ8hb1IyER4km+yVKYDCgNFgodz6A2zWr1yS4/V pXUBfTIZMEZlD3kRaCnC9rMCaSKvWAcea91gMgfrqlAo0hObYhpTJXE1tyxfSR5KSkG+ 0Q298cYFyE6I3OKIx0HMCFOjio1bdx8z/M9X7Hxg+FXfuoGEJifj3hLDXNphESAdRsRR XYRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784224330; x=1784829130; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=d9HnM57cPoFNZBFEZlPJlObGF0jJpBNUfGKI2DBSN2g=; b=bv/HCpBiZ9gtH9/Vdsd+je2mTUIdXYBEhqgt5BA6XXANJ2bcaYovTRcjCN55Hqlvlk KmaAyZHzW0Tu1Taue6WEmcEEYTdBeBuIHz+0fZ1hwhBTavQM7zleqrR9AT7V6c2FcWT/ yYRQzIf7p5zmWJKepu7745L/hsEUJM5Vyg5ut+NFKLLckQEkakkvwr6N8dJ5G0HX8wd/ DCWwbAMEeDT/s67RZqIYIEYUiPEe4F+iKqLnBJUvbot2MdCW6y3CqQqcWS0mt70vf+rM XjWGHInMGTWlzi62JvLN6a00vJfK6plc7Y4qvtwXu+HP3YQMELUxx5Bd0wkWruGx7rKP BRYA== X-Forwarded-Encrypted: i=1; AHgh+RoNkormksz/tcJslwklC0yAVKjG/7/OxflkSJurEPvsOhMjJ6FryLqOg4W2JOIULzzuFu/b8w8ORpNQLu0=@vger.kernel.org X-Gm-Message-State: AOJu0YwsFOmAmfR4b8CSVz5xPiojOcnf85xcw1mjRcSCKSNNYfxKKxU9 ViO5YDzCgPrArbAzzcjNvy+v/he6EAHfDsL+3Swfi7YeFxDwEeNdEp32 X-Gm-Gg: AfdE7ckEx7G06vM/YUJpcO0CdQXVIBjzXN9SMASpZfIcShCyXM+oJrSavmFsa5Uhzn/ 5Mzmfcjd1uBgCGHdKz/vDPm6vPjWeKS1NfRyIM+oAF75D5VsMDrxqJvd2RX0BrQ8RVhKnNKode8 HbTPOw2MzSfNXIlSdPuJIaR8I+6LmhybXjLBow4tK1tYNK+eR1V8xiABuRTKYoVsDk8QAJEfE7e LjBCbT4ueWXyWz1pkryrlHC94yOCv52daaPuA3n3tQ01N6eybl9JxaQv5M3cIrn/FAmZbD7Wq9V QI5zJfI8m2WrKe0zTYDZXauqolFc6z0+vRW1lNJZBfjCpHZhJnLTI86CR1N3DzDTWhNGigEFG4P Z9JSBDD7nP+zw1703CJoMAVvijs0JSvKZtFs/jRjdj420dSyCr42FjFBmv2oDICOHQveJBPmElb tnQIZMK068JCe/DF/MTI/S4PlWsv5Wy/4m8H3X2AA= X-Received: by 2002:a05:6000:70f:b0:47b:69a5:7264 with SMTP id ffacd0b85a97d-47f6078d365mr30313f8f.5.1784224330442; Thu, 16 Jul 2026 10:52:10 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c30a9sm24929886f8f.31.2026.07.16.10.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 10:52:10 -0700 (PDT) Date: Thu, 16 Jul 2026 18:52:08 +0100 From: David Laight To: John Paul Adrian Glaubitz Cc: Florian Fuchs , Rich Felker , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: uaccess: Require offsettable operands for 64-bit user access Message-ID: <20260716185208.74ed22fa@pumpkin> In-Reply-To: References: <20260716165329.3418962-1-fuchsfl@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 16 Jul 2026 19:05:03 +0200 John Paul Adrian Glaubitz wrote: > Hi Florian, > > On Thu, 2026-07-16 at 18:53 +0200, Florian Fuchs wrote: > > The 64-bit __get_user_u64()/__put_user_u64() paths address the memory > > operand as %T2 (base+4). This base+4 requires an offsettable address, > > but "m" also allows the indexed mode @(R0,Rn) (e.g. for a variable- > > indexed array element), which has no displacement field for the +4. > > Depending on optimization this build fails with "invalid 'asm'" or an > > ICE in GCC's change_address_1. > > > > Require an offsettable memory operand, allowing GCC to reload an > > unsuitable indexed address into an appropriate form. An alternative would be to pass 'addr' and 'addr + 4' separately so that the C compilation adds in the offset. With a bit more effort the define wouldn't need repeating for LE and BE. There is a bug in the __put_user_u64 code - it is missing the exception table entry for the second word. (It is present in __get_user_u64, but a separate label would be better.) I also wonder whether there should be non-mmu copies? David