Re: [PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The converted YAML schema omits the `clocks` and `oc-gpios` properties. Since `additionalProperties: false` is set, `make dtbs_check` will incorrectly fail for existing valid device trees that use these properties. Furthermore, `clocks` is a mandatory hardware requirement, as the driver's probe function will fail without it.
--

--- Patch [1]: [PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema ---
commit 7116233f47fab25581fee6b5a4f1df2b63c1d5a9
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,da830-ohci: Convert to DT schema

Convert Texas Instruments da830-ohci bindings from legacy text to DT
schema. Name of binding is changed to match primary compatible property.

> diff --git a/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
> new file mode 100644
> index 0000000000000..ad23da6466487
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
> @@ -0,0 +1,50 @@

[ ... ]

> +  vbus-supply:
> +    description:
> +      phandle of regulator that controls vbus power / over-current
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - phys
> +  - phy-names
> +
> +additionalProperties: false

[Severity: Medium]
Because this schema enforces additionalProperties: false, won't make
dtbs_check incorrectly report validation errors for existing device trees
that include clocks or oc-gpios?

Existing device trees like arch/arm/boot/dts/ti/davinci/da850.dtsi define
a clocks property for this device:

arch/arm/boot/dts/ti/davinci/da850.dtsi:usb1() {
        ...
        phy-names = "usb-phy";
        clocks = <&psc1 2>;
        ...
}

Additionally, the driver drivers/usb/host/ohci-da8xx.c checks for an optional
"oc" GPIO (which translates to oc-gpios in the device tree):

drivers/usb/host/ohci-da8xx.c:ohci_da8xx_probe() {
        ...
        da8xx_ohci->oc_gpio = devm_gpiod_get_optional(dev, "oc", GPIOD_IN);
        ...
}

Furthermore, should clocks be added to the required list? The driver's probe
function appears to fail if the clock is missing:

drivers/usb/host/ohci-da8xx.c:ohci_da8xx_probe() {
        ...
        da8xx_ohci->usb11_clk = devm_clk_get(dev, NULL);
        if (IS_ERR(da8xx_ohci->usb11_clk)) {
        ...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-ti-da830-ohci-v1-1-3f2d111a2042@gmail.com?part=1