Re: [PATCH] dt-bindings: leds: backlight: Convert TPS65217 to DT schema

[Rob Herring <robh@kernel.org>]

On Wed, Jul 08, 2026 at 12:33:17PM +0000, Eduard Bostina wrote:
> Convert the Texas Instruments TPS65217 PMIC bindings to DT schema.
> 
> During the conversion, the following updates were made:
> - Make the 'backlight' node optional to resolve dtbs_check warnings.
>   Some boards declare a bare TPS65217 node without implementing the
>   backlight configuration.
> - Document the 'isink-en' property in the backlight subnode to resolve
>   dtbs_check warnings. This property is used (am335x-guardian.dts)
>   to manage the backlight current sinks. It was missing from the old
>   txt binding.
> - 'additionalProperties: true' is at the top level because the
>   TPS65217 node is documented across multiple independent schemas
>   matching the same compatible string.

We can't have true here.

Looks to me like you just need to define all the child nodes like 
'regulators' (and its children)  and 'charger' (which already has a 
schema). 

> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>  .../bindings/leds/backlight/ti,tps65217.yaml  | 82 +++++++++++++++++++
>  .../leds/backlight/tps65217-backlight.txt     | 27 ------
>  2 files changed, 82 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
>  delete mode 100644 Documentation/devicetree/bindings/leds/backlight/tps65217-backlight.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> new file mode 100644
> index 000000000000..07b15cab4b63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/ti,tps65217.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPS65217 family of regulators
> +
> +maintainers:
> +  - Eduard Bostina <egbostina@gmail.com>
> +
> +description: |

Don't need '|' if no formatting.

> +  The TPS65217 chip contains a boost converter and current sinks which can be
> +  used to drive LEDs for use as backlights.

> +
> +properties:
> +  compatible:
> +    const: ti,tps65217
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C slave address
> +
> +  backlight:
> +    type: object
> +    additionalProperties: false
> +    description:
> +      Node for specifying WLED1 and WLED2 lines in TPS65217.
> +
> +    properties:
> +      isel:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        enum: [1, 2]
> +        description: |
> +          Selection bit. Valid values:
> +            1 - ISEL1 (low-level)
> +            2 - ISEL2 (high-level)
> +
> +      fdim:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        enum: [100, 200, 500, 1000]
> +        description:
> +          PWM dimming frequency in Hz.
> +
> +      default-brightness:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 100
> +
> +      isink-en:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          Enable backlight current sinks.

Constraints? 0 or 1?

Not used by any driver, so perhaps it should be removed from the .dts 
file.

Rob