Re: [PATCH] dt-bindings: input: Convert TI Keypad Controller to DT schema

[Rob Herring <robh@kernel.org>]

On Wed, Jul 08, 2026 at 12:41:11PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Properties strictly required by the hardware and driver ('keypad,num-rows', 'keypad,num-columns', 'interrupts', and 'linux,keymap') are omitted from the 'required:' list, allowing non-functional device trees to silently pass validation.
> --
> 
> --- Patch [1]: [PATCH] dt-bindings: input: Convert TI Keypad Controller to DT schema ---
> commit 31e1662350e854e7b96beb7e7de83fc2b0d265e2
> Author: Eduard Bostina <egbostina@gmail.com>
> 
> dt-bindings: input: Convert TI Keypad Controller to DT schema
> 
> This commit converts the Texas Instruments Keypad Controller bindings to DT
> schema format. It updates the autorepeat property name, adds the reg-names
> property, and omits the keypad row and column properties from the required
> list to prevent validation failures.
> 
> > diff --git a/Documentation/devicetree/bindings/input/ti,omap4-keypad.yaml b/Documentation/devicetree/bindings/input/ti,omap4-keypad.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/ti,omap4-keypad.yaml
> [ ... ]
> > +required:
> > +  - compatible
> > +  - reg
> 
> [Severity: Medium]
> The commit message mentions that keypad,num-rows and keypad,num-columns were
> omitted from this required list because enforcing them causes validation
> failures. Should these properties, along with interrupts and linux,keymap,
> be included here to accurately reflect the driver's probing requirements?
> 
> Omitting them allows non-functional device tree nodes to silently pass
> schema validation. At runtime, the omap4-keypad driver will unconditionally
> fail to probe via platform_get_irq(), matrix_keypad_parse_properties(), and
> matrix_keypad_build_keymap() when these properties are missing.
> 
> Would it be better to enforce the strict hardware and driver requirements in
> the schema, and instead fix the incomplete device tree nodes that are
> failing validation?

Yes. sashiko is right.

Rob