From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F73C44512 for ; Thu, 16 Jul 2026 22:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s7AlRyNbK6gqM1YO3A7oDIipkngqxzqvPLwBoKQVngo=; b=wm0DxRGFRWOeal mIQWlhJdbTL3Wkzpvyb1MBZ5xGhTD44Z8v/NBIlwpTsEjQxdo3uZMQO1b7ErAQI6ICV5Zs7/vNZGY eRKY7GezWsSsdoDR16Ylexb4m+91DVCD1y8/KsLIkuSRnFp1lmn3+Rs9DYTXBQMtGRTEsAJNoiDTV FfAymoonqKcD4yJlk6UFuaoJutw8+TxzRf5VCMhenYqlT8Ei02P40PlCUfMxCtie9PPHY/Orzu58J mcN0ECTT27rYysFjoHMQ66Kv7AfG5ApXNltDkA3XXdqrT3xNVF1+CdHNohc6QN2hP7xSPM9qq48Q0 fq9GV6Ga8L2d6WjK38Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkUX4-00000000jG7-3kW2; Thu, 16 Jul 2026 22:26:18 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkUX4-00000000jFj-0X3n for linux-phy@lists.infradead.org; Thu, 16 Jul 2026 22:26:18 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 49BCD60A5E; Thu, 16 Jul 2026 22:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8612B1F000E9; Thu, 16 Jul 2026 22:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784240777; bh=3+LM7zpoT/B9K90aIiX++aRa/GvaKYwxj0Y2NjRnwGw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ELwnmHVcKdjWEteeVd5ofcF02t6OGAAprHZ1+uxZvEcFaOsQMkK722RNCWQbpIgei gzo3eoeDwoGV4wNta4/pa4qdj/IWUA5G2aw+9xEq5aUeJeddsxM19xEjnbq5MlR2LD lqWfXG0KAuHuJD4lOfuo2QkWUOv02YxL1plDEEvWFeRLcAqvDGxyACvuHE30puyMJs bVTIQ0nkRxLmjO6RIhqAeBsKLxCB5q5I75ZWUdbJkhXmu8AcqnNRRLcGp6A+CWTEuR 2PCvLIa79Qhd4azP1elztNCJ4zpOmMeO8/wNKHH9x5gQHd6DEP3e/ZXJC1TOkc/9RS 1twMD58qmQNtw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/13] clk: zte: Add Clock registration infrastructure To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: vkoul@kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org In-Reply-To: <20260717-zx29clk-v7-6-408411cfcf36@gmail.com> References: <20260717-zx29clk-v7-0-408411cfcf36@gmail.com> <20260717-zx29clk-v7-6-408411cfcf36@gmail.com> Date: Thu, 16 Jul 2026 22:26:16 +0000 Message-Id: <20260716222616.8612B1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIEluIGB6eF9jbGtfY29t bW9uX3Byb2JlKClgLCB0aGUgZXJyb3IgcGF0aCBmb3IgYGRhdGEtPmluaXQobWFwKWAgaW5jb3Jy ZWN0bHkgcmV0dXJucyBgUFRSX0VSUihjbGspYCBpbnN0ZWFkIG9mIHByb3BhZ2F0aW5nIHRoZSBh Y3R1YWwgZXJyb3IgY29kZSBgcmVzYC4KLS0KCi0tLSBQYXRjaCBbNl06IFtQQVRDSCB2NyAwNi8x M10gY2xrOiB6dGU6IEFkZCBDbG9jayByZWdpc3RyYXRpb24gaW5mcmFzdHJ1Y3R1cmUgLS0tCmNv bW1pdCAzNzdhNmFmNzc2OWI4NDBkODdhODViMzJhZjMwMDFmZDVmNDQzMWRkCkF1dGhvcjogU3Rl ZmFuIETDtnNpbmdlciA8c3RlZmFuZG9lc2luZ2VyQGdtYWlsLmNvbT4KCmNsazogenRlOiBBZGQg Q2xvY2sgcmVnaXN0cmF0aW9uIGluZnJhc3RydWN0dXJlCgpUaGlzIGNvbW1pdCBhZGRzIHRoZSBj b21tb24gY2xvY2sgcmVnaXN0cmF0aW9uIGluZnJhc3RydWN0dXJlIGZvciBaVEUgU29Dcy4KSXQg aW5jbHVkZXMgc3VwcG9ydCBmb3IgcmVnaXN0ZXJpbmcgUExMcywgbXV4ZXMsIGRpdmlkZXJzLCBh bmQgZ2F0ZXMgdXNpbmcKcmVnbWFwLCBhbmQgaW50cm9kdWNlcyBhIGNvbW1vbiBwcm9iZSBmdW5j dGlvbiB0byBpbml0aWFsaXplIHRoZW0uCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay96dGUv Y2xrLXp4LmMgYi9kcml2ZXJzL2Nsay96dGUvY2xrLXp4LmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmRiNGZhZDJiNGIwNTYKPiAtLS0gL2Rldi9udWxsCj4g KysrIGIvZHJpdmVycy9jbGsvenRlL2Nsay16eC5jClsgLi4uIF0KPiBAQCAtMCwwICsxLDE1NSBA QApbIC4uLiBdCj4gK2ludCB6eF9jbGtfY29tbW9uX3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IGRldmljZV9ub2RlICpvZl9ub2RlLAo+ICsJCQljb25zdCBzdHJ1Y3QgenhfY2xrX2Rh dGEgKmRhdGEpCj4gK3sKWyAuLi4gXQo+ICsJaWYgKGRhdGEtPmluaXQpIHsKPiArCQlyZXMgPSBk YXRhLT5pbml0KG1hcCk7Cj4gKwkJaWYgKHJlcykKPiArCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUo ZGV2LCBQVFJfRVJSKGNsayksICJDb250cm9sbGVyIGluaXQgZmFpbHVyZVxuIik7CgpbU2V2ZXJp dHk6IEhpZ2hdCkRvZXMgdGhpcyBjb2RlIHBhc3MgdGhlIHdyb25nIGVycm9yIGNvZGUgdG8gZGV2 X2Vycl9wcm9iZSgpIGluIHRoZQp6eF9jbGtfY29tbW9uX3Byb2JlKCkgZXJyb3IgcGF0aD8KCldo ZW4gZGF0YS0+aW5pdChtYXApIGZhaWxzLCBpdCByZXR1cm5zIGEgbm9uLXplcm8gZXJyb3IgY29k ZSBpbnRvIHJlcy4KSG93ZXZlciwgdGhlIGVycm9yIGhhbmRsaW5nIGJsb2NrIGluY29ycmVjdGx5 IGV2YWx1YXRlcyBhbmQgcmV0dXJucwpQVFJfRVJSKGNsaykuCgpTaW5jZSBjbGsgaXMgbWVyZWx5 IGFuIGl0ZXJhdGlvbiB2YXJpYWJsZSBmcm9tIHRoZSBwcmVjZWRpbmcgbG9vcHMsIGl0IGNvdWxk CmJlIGNvbXBsZXRlbHkgdW5pbml0aWFsaXplZCBpZiBudW1faW5wdXRzX2VuYWJsZSBhbmQgbnVt X2lucHV0cyBhcmUgMCwgd2hpY2gKbWlnaHQgdHJpY2sgdGhlIGRyaXZlciBjb3JlIGludG8gYXNz dW1pbmcgdGhlIHByb2JlIHN1Y2NlZWRlZCBkZXNwaXRlCmluaXRpYWxpemF0aW9uIGZhaWxpbmcu CgpJZiB0aGUgbG9vcHMgZGlkIGV4ZWN1dGUgc3VjY2Vzc2Z1bGx5LCBjbGsgaG9sZHMgYSB2YWxp ZCBwb2ludGVyLCBhbmQKUFRSX0VSUihjbGspIHdpbGwgcmV0dXJuIGEgcmFuZG9tIGxhcmdlIG51 bWJlciBkZXBlbmRpbmcgb24gdGhlIHBvaW50ZXIncwptZW1vcnkgYWRkcmVzcywgcmVzdWx0aW5n IGluIGEgbWVhbmluZ2xlc3MgZXJyb3IgY29kZS4KClNob3VsZCB0aGlzIHJldHVybiByZXMgaW5z dGVhZCBvZiBQVFJfRVJSKGNsayk/Cgo+ICsJfQo+ICsKPiArCXJlcyA9IHp4X2Nsa19yZWdpc3Rl cl9wbGxzKGRldiwgbWFwLCBkYXRhLT5wbGxzLCBkYXRhLT5udW1fcGxscyk7Cj4gKwlpZiAocmVz KQo+ICsJCXJldHVybiByZXM7ClsgLi4uIF0KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MTctengyOWNsay12Ny0wLTQwODQxMWNm Y2YzNkBnbWFpbC5jb20/cGFydD02CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1w aHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06163BD643 for ; Thu, 16 Jul 2026 22:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240778; cv=none; b=heKECl+zZAzkT3O7Co/v4L0g4saf/5cKex5Mhgt135lSQ4qSdl3OD562THCMZ4lN/+LnvSXsWpZFPoB4ROwn4dwx+7lHnuRyVXNzeRbdn6iqc4Tq+ccaoq4/3Gq6dhczjppBF5dWhiV4j5MfU14o/e02/onlEeeFALChYrGmRoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784240778; c=relaxed/simple; bh=iPbVI9GPwrzRFsiKQe9ExVHN8M5GCBGQD8DzBEEiELA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=d3mzuagmhD8PgbkYh3edJFxWAqr3U2yOMzAU1a/+AMMX1DQV8s+7UOa42OhJdSSaH2MpUoi7TQizlkdaWB51Dw+GWWzdZrkpDC1SbmQ6UVUCsTdoN6hmNncuimuxiu8ZlcP39gcQKRtwHvdTZqPzAaClaBhlPX31c3N995wD7XY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ELwnmHVc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ELwnmHVc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8612B1F000E9; Thu, 16 Jul 2026 22:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784240777; bh=3+LM7zpoT/B9K90aIiX++aRa/GvaKYwxj0Y2NjRnwGw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ELwnmHVcKdjWEteeVd5ofcF02t6OGAAprHZ1+uxZvEcFaOsQMkK722RNCWQbpIgei gzo3eoeDwoGV4wNta4/pa4qdj/IWUA5G2aw+9xEq5aUeJeddsxM19xEjnbq5MlR2LD lqWfXG0KAuHuJD4lOfuo2QkWUOv02YxL1plDEEvWFeRLcAqvDGxyACvuHE30puyMJs bVTIQ0nkRxLmjO6RIhqAeBsKLxCB5q5I75ZWUdbJkhXmu8AcqnNRRLcGp6A+CWTEuR 2PCvLIa79Qhd4azP1elztNCJ4zpOmMeO8/wNKHH9x5gQHd6DEP3e/ZXJC1TOkc/9RS 1twMD58qmQNtw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 06/13] clk: zte: Add Clock registration infrastructure Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: vkoul@kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org In-Reply-To: <20260717-zx29clk-v7-6-408411cfcf36@gmail.com> References: <20260717-zx29clk-v7-0-408411cfcf36@gmail.com> <20260717-zx29clk-v7-6-408411cfcf36@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 16 Jul 2026 22:26:16 +0000 Message-Id: <20260716222616.8612B1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] In `zx_clk_common_probe()`, the error path for `data->init(map)` i= ncorrectly returns `PTR_ERR(clk)` instead of propagating the actual error c= ode `res`. -- --- Patch [6]: [PATCH v7 06/13] clk: zte: Add Clock registration infrastruc= ture --- commit 377a6af7769b840d87a85b32af3001fd5f4431dd Author: Stefan D=C3=B6singer clk: zte: Add Clock registration infrastructure This commit adds the common clock registration infrastructure for ZTE SoCs. It includes support for registering PLLs, muxes, dividers, and gates using regmap, and introduces a common probe function to initialize them. > diff --git a/drivers/clk/zte/clk-zx.c b/drivers/clk/zte/clk-zx.c > new file mode 100644 > index 0000000000000..db4fad2b4b056 > --- /dev/null > +++ b/drivers/clk/zte/clk-zx.c [ ... ] > @@ -0,0 +1,155 @@ [ ... ] > +int zx_clk_common_probe(struct device *dev, struct device_node *of_node, > + const struct zx_clk_data *data) > +{ [ ... ] > + if (data->init) { > + res =3D data->init(map); > + if (res) > + return dev_err_probe(dev, PTR_ERR(clk), "Controller init failure\n"); [Severity: High] Does this code pass the wrong error code to dev_err_probe() in the zx_clk_common_probe() error path? When data->init(map) fails, it returns a non-zero error code into res. However, the error handling block incorrectly evaluates and returns PTR_ERR(clk). Since clk is merely an iteration variable from the preceding loops, it could be completely uninitialized if num_inputs_enable and num_inputs are 0, which might trick the driver core into assuming the probe succeeded despite initialization failing. If the loops did execute successfully, clk holds a valid pointer, and PTR_ERR(clk) will return a random large number depending on the pointer's memory address, resulting in a meaningless error code. Should this return res instead of PTR_ERR(clk)? > + } > + > + res =3D zx_clk_register_plls(dev, map, data->plls, data->num_plls); > + if (res) > + return res; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260717-zx29clk-v7= -0-408411cfcf36@gmail.com?part=3D6