From: Nathan Chancellor <nathan@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Alex Williamson <alex@shazbot.org>,
David Matlack <dmatlack@google.com>,
Justin Stitt <justinstitt@google.com>,
kvm@vger.kernel.org, Leon Romanovsky <leon@kernel.org>,
linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org,
llvm@lists.linux.dev, Mark Bloch <mbloch@nvidia.com>,
Bill Wendling <morbo@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Shuah Khan <shuah@kernel.org>, Tariq Toukan <tariqt@nvidia.com>,
patches@lists.linux.dev
Subject: Re: [PATCH v3 06/11] selftests: Fix arm64 IO barriers to match kernel
Date: Thu, 16 Jul 2026 16:22:10 -0700 [thread overview]
Message-ID: <20260716232210.GA700430@ax162> (raw)
In-Reply-To: <6-v3-76f117ad04f1+28a90-mlx5st_jgg@nvidia.com>
On Thu, Jul 16, 2026 at 02:03:22PM -0300, Jason Gunthorpe wrote:
> The tools/include readl/writel MMIO accessors on arm64 use
> inner-shareable barriers (dmb ish) while the kernel uses
> outer-shareable (dmb osh). Fix them to match.
>
> Add __io_bw() and __io_ar() definitions matching the kernel's
> arch/arm64/include/asm/io.h, including the dummy control dependency
> in __io_ar() that orders MMIO reads against all subsequent
> instructions.
>
> Assisted-by: Claude:claude-opus-4.6
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
...
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index f02cc8a2e4ae32..fdd22df9174b88 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -5,9 +5,14 @@ ifneq ($(filter %/,$(LLVM)),)
> LLVM_PREFIX := $(LLVM)
> else ifneq ($(filter -%,$(LLVM)),)
> LLVM_SUFFIX := $(LLVM)
> +else ifneq ($(LLVM),1)
> +$(error Invalid value for LLVM, see Documentation/kbuild/llvm.rst)
> endif
>
> CLANG := $(LLVM_PREFIX)clang$(LLVM_SUFFIX)
> +LD := $(LLVM_PREFIX)ld.lld$(LLVM_SUFFIX)
> +# Selftests link through $(CC), so point clang at the LLVM linker.
> +LDFLAGS += --ld-path=$(LD)
>
> CLANG_TARGET_FLAGS_arm := arm-linux-gnueabi
> CLANG_TARGET_FLAGS_arm64 := aarch64-linux-gnu
Was this hunk intended to be included in this change? It is not
mentioned anywhere. I assume this is the only reason that the LLVM folks
were CC'd on this series.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-07-16 23:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 17:03 [PATCH v3 00/11] mlx5 support for VFIO self test Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 01/11] net/mlx5: Add IFC structures for CQE and WQE Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 02/11] net/mlx5: Move HW constant groups from device.h/cq.h to mlx5_ifc.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 03/11] net/mlx5: Extract MLX5_SET/GET macros into mlx5_ifc_macros.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 04/11] net/mlx5: Add ONCE and MMIO accessor variants to mlx5_ifc_macros.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 05/11] selftests: Add additional kernel functions to tools/include/ Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 06/11] selftests: Fix arm64 IO barriers to match kernel Jason Gunthorpe
2026-07-16 23:22 ` Nathan Chancellor [this message]
2026-07-17 0:36 ` Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 07/11] vfio: selftests: Allow drivers to specify required region size Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 08/11] vfio: selftests: Add dev_dbg Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 09/11] vfio: selftests: Add mlx5 driver - HW init and command interface Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 10/11] vfio: selftests: Add mlx5 driver - data path and memcpy ops Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 11/11] vfio: selftests: mlx5 driver - add send_msi support Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716232210.GA700430@ax162 \
--to=nathan@kernel.org \
--cc=alex@shazbot.org \
--cc=dmatlack@google.com \
--cc=jgg@nvidia.com \
--cc=justinstitt@google.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mbloch@nvidia.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.