From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F2A9C44507 for ; Fri, 17 Jul 2026 04:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z0YnSzfQwH0ttUvM6RmfTp2Z8kWjkNXj7NJGqBNUpuU=; b=byLLMqhsAF6O/u TW1e/qQUcSvg0kRFagvGA7eCaNa+UJBldoikz6QCVOMBu7Fnm+GKfRcibxZT3YoJ9zYIxTOnOqgwk u4ZeEE8CCMYftqJphZoweMNsiUTHmKmoJU7HSi19YX+5o/INPJU1Ypbutr1zXRRYijX7x8HCkTxd+ 0aopJDlsut5/6t9mrh6e+p21FL8c7rPjbuZJAjt0anl+LG+osB0Aj+/ufbQEnNZea4DvDDOjgdX7Y pYiuM8MFj60hzvlso8XjJc8NvxCnsNBKrUYJWmxLe0EU4G2dka1vb3inzsHQhtxo/cW8iv8Tq7zlZ O6OYf5OGgRTvV1wA8oaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkZkx-00000001666-1IZo; Fri, 17 Jul 2026 04:00:59 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkZkw-0000000165g-11hC for linux-i3c@lists.infradead.org; Fri, 17 Jul 2026 04:00:58 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2550060A5E; Fri, 17 Jul 2026 04:00:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA971F000E9; Fri, 17 Jul 2026 04:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784260856; bh=PwOkEy8C3+8zcielTkx4YVyJzWQmV+QDjPL3dA5zhL8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oGDGmGcjXIaBSQhsBTXBCkaQ96uPaETinbUeOASHOBgUHTf5xBhKAN70wuaDhIS6P vGwKXLcgv9IiXuMuGfElPzEpP+gIdTEzxh235a3m4tbT7d2eItp/N9R72lBSds+LRv 0uQ4R5Jbpeq7hzjntzmpdzw4qCk/YSuD/ui0mvQkL90PUPkVXFaY1cf4BOemocSMZK Gur3IoMT8t+V+pbYMEQ+JWdu/kIcn+nm/3Owz0XzhILAG5Y6k5tReuniGsVX+W1Fqz xs32m82p1mjG/ieAxln+h9/fwZ+HHYcwEHOSumSx6jRa1UMckuMuRO8DgsS29sVuj5 y5oZ5riGuLxxQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant To: "Swark Yang" Cc: linux-i3c@lists.infradead.org, "Alexandre Belloni" , robh@kernel.org, Frank.Li@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260716-upstream-axiado-ax3005-upstream-v3-2-c429095143ec@axiado.com> References: <20260716-upstream-axiado-ax3005-upstream-v3-0-c429095143ec@axiado.com> <20260716-upstream-axiado-ax3005-upstream-v3-2-c429095143ec@axiado.com> Date: Fri, 17 Jul 2026 04:00:55 +0000 Message-Id: <20260717040056.6BA971F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBzY2hlbWEgZW5m b3JjZXMgYSAzLWl0ZW0gY29tcGF0aWJsZSBzdHJpbmcgY2hhaW4gdGhhdCB1bmludGVudGlvbmFs bHkgZm9yY2VzIEFYMzAwNSBkZXZpY2VzIHRvIGluaGVyaXQgYW4gQVgzMDAwLXNwZWNpZmljIGRy aXZlciBxdWlyaywgY29udHJhZGljdGluZyB0aGUgY29tbWl0IG1lc3NhZ2UuCi0tCgotLS0gUGF0 Y2ggWzJdOiBbUEFUQ0ggdjMgMi84XSBkdC1iaW5kaW5nczogZ3BpbzogY2RuczogYWRkIEF4aWFk byBBWDMwMDUgR1BJTyB2YXJpYW50IC0tLQpjb21taXQgNTNjNjdlN2RjNDYwOWVlOWU2MWY1N2Ex ZDQzYzljNmNhMDRkMTIzYgpBdXRob3I6IFN3YXJrIFlhbmcgPHN5YW5nQGF4aWFkby5jb20+Cgpk dC1iaW5kaW5nczogZ3BpbzogY2RuczogYWRkIEF4aWFkbyBBWDMwMDUgR1BJTyB2YXJpYW50CgpB ZGQgYmluZGluZyBmb3IgdGhlIEF4aWFkbyBBWDMwMDUgR1BJTyBjb250cm9sbGVyLiBUaGUgY29t bWl0IG1lc3NhZ2Ugc3RhdGVzCnRoZXJlIGFyZSBubyBrbm93biBjaGFuZ2VzIGFuZCBpdCBzaG91 bGQgZmFsbCBiYWNrIGRpcmVjdGx5IHRvIHRoZQpjZG5zLGdwaW8tcjFwMDIgY29tcGF0aWJsZSBz dHJpbmcuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv Z3Bpby9jZG5zLGdwaW8ueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9n cGlvL2NkbnMsZ3Bpby55YW1sCj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2dwaW8vY2RucyxncGlvLnlhbWwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZ3Bpby9jZG5zLGdwaW8ueWFtbAo+IEBAIC0xNCw4ICsxNCwxMSBAQCBwcm9wZXJ0 aWVzOgo+ICAgICAgb25lT2Y6Cj4gICAgICAgIC0gY29uc3Q6IGNkbnMsZ3Bpby1yMXAwMgo+ICAg ICAgICAtIGl0ZW1zOgo+IC0gICAgICAgICAgLSBlbnVtOgo+IC0gICAgICAgICAgICAgIC0gYXhp YWRvLGF4MzAwMC1ncGlvCj4gKyAgICAgICAgICAtIGNvbnN0OiBheGlhZG8sYXgzMDAwLWdwaW8K PiArICAgICAgICAgIC0gY29uc3Q6IGNkbnMsZ3Bpby1yMXAwMgo+ICsgICAgICAtIGl0ZW1zOgo+ ICsgICAgICAgICAgLSBjb25zdDogYXhpYWRvLGF4MzAwNS1ncGlvCj4gKyAgICAgICAgICAtIGNv bnN0OiBheGlhZG8sYXgzMDAwLWdwaW8KPiAgICAgICAgICAgIC0gY29uc3Q6IGNkbnMsZ3Bpby1y MXAwMgoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIGZvcmNpbmcgYXhpYWRvLGF4MzAwMC1ncGlvIGlu dG8gdGhlIDMtaXRlbSBjb21wYXRpYmxlIHN0cmluZyBjaGFpbgp1bmludGVudGlvbmFsbHkgY2F1 c2UgQVgzMDA1IGRldmljZXMgdG8gaW5oZXJpdCBBWDMwMDAtc3BlY2lmaWMgZHJpdmVyCnF1aXJr cz8KCkJ5IHJlcXVpcmluZyB0aGUgYXhpYWRvLGF4MzAwMC1ncGlvIGNvbXBhdGlibGUgc3RyaW5n IGluIHRoZSBmYWxsYmFjayBjaGFpbiwKYW55IEFYMzAwNSBkZXZpY2UgdHJlZSBtdXN0IGluY2x1 ZGUgaXQgdG8gcGFzcyBzY2hlbWEgdmFsaWRhdGlvbi4gVGhlCnVuZGVybHlpbmcgZHJpdmVyIHdp bGwgdGhlbiBtYXRjaCB0aGlzIGludGVybWVkaWF0ZSBzdHJpbmcgdmlhCmRldmljZV9nZXRfbWF0 Y2hfZGF0YSgpIGFuZCBhcHBseSBheDMwMDBfZ3Bpb19xdWlya3MsIHN1Y2ggYXMgc2tpcHBpbmcK aW5pdGlhbGl6YXRpb24gb2YgQ0ROU19HUElPX0RJUkVDVElPTl9NT0RFIGFuZCBDRE5TX0dQSU9f T1VUUFVUX0VOLgoKVGhlIGNvbW1pdCBtZXNzYWdlIHN0YXRlcyB0aGUgaW50ZW50IGlzIHRvIGZh bGwgYmFjayB0byB0aGUgY2RucyxncGlvLXIxcDAyCmNvbXBhdGlibGUuIFNob3VsZCBheGlhZG8s YXgzMDA1LWdwaW8gaW5zdGVhZCBiZSBhZGRlZCB0byBhbiBlbnVtIGFsb25nc2lkZQpheGlhZG8s YXgzMDAwLWdwaW8gaW4gYSAyLWl0ZW0gZmFsbGJhY2sgY2hhaW4sIGF2b2lkaW5nIHRoZSBpbnRl cm1lZGlhdGUKQVgzMDAwIHN0cmluZyBlbnRpcmVseT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDC tyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MTYtdXBzdHJlYW0tYXhpYWRv LWF4MzAwNS11cHN0cmVhbS12My0wLWM0MjkwOTUxNDNlY0BheGlhZG8uY29tP3BhcnQ9MgoKLS0g CmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1pM2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47410169AD2 for ; Fri, 17 Jul 2026 04:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784260858; cv=none; b=kWsmnGljYzGHPlFGiijFSE7kUa7T+qUY/TkK8x9Guts+ALmSRGLNlQQxggb36qKZeZeDQ8TlMV0hTC6WE4ez6faeuP7kXYpE6Uyo6gNxkz2/CYILRsA4ffqEUgzSolOpIdLk6YteqsRQtOHnsUeEYy9LpBOHj94LJ/EwkGofiyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784260858; c=relaxed/simple; bh=1sy0SqeqpzzX1PNT3Q3uBBX1PTnbxCXQEIwpfv4JS2A=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=bmGlmLTm+kZe55Uj1ClQbfWppaI0p2ykohAcSdWUIJFGB7QLGZngcvMtLEsHhVJS9pXfAwhqKIRtS1vti50AQUwtRvNdVFrekO/jPH1+IQ0fxQOpL8FsRPrT4Z7XaIlln9hKafphXbFoAZk1wOlUUM0eZnhmVV31WMBJogEpim0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oGDGmGcj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGDGmGcj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA971F000E9; Fri, 17 Jul 2026 04:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784260856; bh=PwOkEy8C3+8zcielTkx4YVyJzWQmV+QDjPL3dA5zhL8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=oGDGmGcjXIaBSQhsBTXBCkaQ96uPaETinbUeOASHOBgUHTf5xBhKAN70wuaDhIS6P vGwKXLcgv9IiXuMuGfElPzEpP+gIdTEzxh235a3m4tbT7d2eItp/N9R72lBSds+LRv 0uQ4R5Jbpeq7hzjntzmpdzw4qCk/YSuD/ui0mvQkL90PUPkVXFaY1cf4BOemocSMZK Gur3IoMT8t+V+pbYMEQ+JWdu/kIcn+nm/3Owz0XzhILAG5Y6k5tReuniGsVX+W1Fqz xs32m82p1mjG/ieAxln+h9/fwZ+HHYcwEHOSumSx6jRa1UMckuMuRO8DgsS29sVuj5 y5oZ5riGuLxxQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant Reply-To: sashiko-reviews@lists.linux.dev To: "Swark Yang" Cc: linux-i3c@lists.infradead.org, "Alexandre Belloni" , robh@kernel.org, Frank.Li@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260716-upstream-axiado-ax3005-upstream-v3-2-c429095143ec@axiado.com> References: <20260716-upstream-axiado-ax3005-upstream-v3-0-c429095143ec@axiado.com> <20260716-upstream-axiado-ax3005-upstream-v3-2-c429095143ec@axiado.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Jul 2026 04:00:55 +0000 Message-Id: <20260717040056.6BA971F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] The schema enforces a 3-item compatible string chain that unintent= ionally forces AX3005 devices to inherit an AX3000-specific driver quirk, c= ontradicting the commit message. -- --- Patch [2]: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GP= IO variant --- commit 53c67e7dc4609ee9e61f57a1d43c9c6ca04d123b Author: Swark Yang dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant Add binding for the Axiado AX3005 GPIO controller. The commit message states there are no known changes and it should fall back directly to the cdns,gpio-r1p02 compatible string. > diff --git a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml b/Docu= mentation/devicetree/bindings/gpio/cdns,gpio.yaml > --- a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml > @@ -14,8 +14,11 @@ properties: > oneOf: > - const: cdns,gpio-r1p02 > - items: > - - enum: > - - axiado,ax3000-gpio > + - const: axiado,ax3000-gpio > + - const: cdns,gpio-r1p02 > + - items: > + - const: axiado,ax3005-gpio > + - const: axiado,ax3000-gpio > - const: cdns,gpio-r1p02 [Severity: High] Does forcing axiado,ax3000-gpio into the 3-item compatible string chain unintentionally cause AX3005 devices to inherit AX3000-specific driver quirks? By requiring the axiado,ax3000-gpio compatible string in the fallback chain, any AX3005 device tree must include it to pass schema validation. The underlying driver will then match this intermediate string via device_get_match_data() and apply ax3000_gpio_quirks, such as skipping initialization of CDNS_GPIO_DIRECTION_MODE and CDNS_GPIO_OUTPUT_EN. The commit message states the intent is to fall back to the cdns,gpio-r1p02 compatible. Should axiado,ax3005-gpio instead be added to an enum alongside axiado,ax3000-gpio in a 2-item fallback chain, avoiding the intermediate AX3000 string entirely? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260716-upstream-a= xiado-ax3005-upstream-v3-0-c429095143ec@axiado.com?part=3D2