Re: [PATCH v3 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CLK_MAILI_VIDEOCC incorrectly selects CLK_HAWI_GCC instead of a Maili-specific Global Clock Controller.
--

--- Patch [2]: [PATCH v3 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC ---
commit 3279b9315bb8b961f7460eb907c8f81979b2b267
Author: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

This commit adds support for the Qualcomm Maili video clock controller
driver. It introduces the new videocc-maili module and its Kconfig entry
for devices requiring video encode/decode clock functionalities.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 63f271aff1771..690f0b6fe227c 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -181,6 +181,16 @@ config CLK_KAANAPALI_VIDEOCC
>  	  Say Y if you want to support video devices and functionality such as
>  	  video encode/decode.
>  
> +config CLK_MAILI_VIDEOCC
> +	tristate "Maili Video Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select CLK_HAWI_GCC

[Severity: Low]
Is this select statement accurate? The CLK_MAILI_VIDEOCC config appears to
select CLK_HAWI_GCC, which seems to be a Global Clock Controller for the Hawi
platform rather than Maili. 

Could this be a copy-paste error that should instead select a Maili-specific
GCC?

> +	default m if ARCH_QCOM
> +	help
> +	  Support for the video clock controller on Maili devices.
> +	  Say Y if you want to support video devices and functionality such as
> +	  video encode/decode.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-maili_videocc-v3-0-6656694b06a7@oss.qualcomm.com?part=2