From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613433DCD80 for ; Fri, 17 Jul 2026 08:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275254; cv=none; b=pM+PqtluMhv8880VtVJjblwcw6D9tWrxIu3MkT/HiXqY/WFs1wVd6pT8gEjjlUasDz73Z7YKR26VTo716W+xYinmjmF+QvDEVyG0QssceLKWaZ4rN2RyDB2aCpARexJIsR6bXDIJtWFNjoo6DD6j1lLVh4ZfHlo5MqrSZL+KAzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784275254; c=relaxed/simple; bh=5TK5+A8l3/UCcWk86OmEsOO2M+0k4ZunqEhdaKTEsqY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZBxgPCqY1kh+1DjmtEnK3+TbXWg4gcrEmLvbp/okH8KPzxu9QcM58z17kXbC8uI7vVCvkxIpxA1tpg4cIo176GikewUfLE5k8uhTcjCwsW8e0pRSKkWBQo9f7S7sqbyWwXMxaDUiumiFPiSvod7nxZ/eaIdU/09Qy/nx6xocwBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CsNmJaqn; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CsNmJaqn" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4758bd3731bso1119671f8f.0 for ; Fri, 17 Jul 2026 01:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784275250; x=1784880050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g5XOjj3wvMb//AUkLm3Blkifr6hBS1t4fksNlwiTW34=; b=CsNmJaqnfu/0TM4wOnDaumnRMl0RxuM5NopLvfNwONGrctFhLphkH3UYE6VMXGgS2F 2lESpy+Jy0jdGU2jXInvOAviZdOdXxjs2yP4N6w4dtsUWTgR1CpdXUMIsavI2x5Q3MfM OLI7TedGhGTSAQu8l44RGLSNzIFJ9ypjk49L4GDKBaugMvTndJbc/0TEi6jsPHSM1ffv IEHLb5n4Q/C25szQYOVpcaJ0WsAYqpvMQtSaXzS1jWx7aq1gDzibnDI5hF2C8im1oEMU bTINXsbDgJQiwtFB2u5tfANrDqRPHWrsplnsW/KMs+m5pdPMookCNQjidCvdxqCb2fYk u1Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784275250; x=1784880050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=g5XOjj3wvMb//AUkLm3Blkifr6hBS1t4fksNlwiTW34=; b=W7PnXm7pQ6rgve3r/YyqyHmv8dijJQ5pYRG2gly+kX+pbds+TruxQ3EoraPSfpD9g4 9jjKUHlXb/mwVE+nzCTesRZn8o2k7z7WXAyDnpZIoma8GbvkkcDUWfSxlo1AsjQmq4Pj Synct83MC8Qwao684OExX7+K5HUNH5gL1bCaLyg+KyWtksR2a0Qt2KJDwOUKfF2qNFMf zjaGuNCOGxz6Dm4i+S9mLv3413RFvuO2p1Zl+Em/lpU/I8WwbQ6+Jir9pSLHzbOm3U4D xMEQ+sma++9FxUg4tcVdLxw7JbKwxOGDBh+v8Ca7W0yv0BhMe8/tBFwgbUeheyyE1bMM qYmw== X-Forwarded-Encrypted: i=1; AHgh+Rod2gvLl00/az7iXLz3JVJLep2LA03zGpZstCki+U61+iFCf4fMLtKfFmO3Zx8owES4rOSpF9wukwrs1wk=@vger.kernel.org X-Gm-Message-State: AOJu0YxojDmshhtZibrbECV3X2RQfyatbYOKAXXGD/CpaFQQ2qnvCNxZ duu/ZT71sBBOjx+XU7cTXKkAfGkxTaeKs5oKE3kYUVpbzlnF0TpJs3UK X-Gm-Gg: AfdE7cl+9maz11uhntO9Xx+NOSH+b2k3lJSLGvg/HODxom8fo6cyS2/ZrppUPl97LYP r+xxo2Vm8rPQ+KwM/EeLAVyoAk9oGjwAsdRJacxvznCa68TU12qzB2mnS6ADTR402Q7zuodh95m tj/VATwNYOc+G8Zxj/CBa5cilUcY4MJMOhefYQqZ0uM5s9umkuzqj6XMb7YLNYtJxdJMOVdU9In 7+85wbti0Os86wS2OQNF/e9V5nJu8vozukSdkJynkzmBqSnNOUgelFBkeoK4AqtEZ8Jltjq23Qn S2jFeTwCg6vGFfezlKJ7wBQrSdqOB1YuhvrLR5s4KdXrObItXIZOWkH58Z6bfsTsXr3Vk8CKQah yhA+ovzbSYSQ9c25J4DK8a/gEblrR3BTbQPS3LFhdF7dD+p1VCpRgajU1mvS7DLCiLupleWJPAt KgdxtA54N/uJIB6fqTzdZ0PGU2jikvfM3NjxOgXO+Vv165hoCqLiqgoCU= X-Received: by 2002:a05:6000:4381:b0:473:1e79:87e6 with SMTP id ffacd0b85a97d-47f623ae0demr1833373f8f.3.1784275250197; Fri, 17 Jul 2026 01:00:50 -0700 (PDT) Received: from flaviu-Aspire-E5-572G.. ([93.122.248.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63edda29sm1769819f8f.32.2026.07.17.01.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:00:49 -0700 (PDT) From: Flaviu Nistor To: Guenter Roeck , Jean Delvare Cc: Flaviu Nistor , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] hwmon: (lm90) Switch channel parsing to fwnode APIs Date: Fri, 17 Jul 2026 11:00:27 +0300 Message-ID: <20260717080027.8370-1-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717070614.6492-1-flaviu.nistor@gmail.com> References: <20260717070614.6492-1-flaviu.nistor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 17 Jul 2026 10:06, Flaviu Nistor wrote >On Fri, 17 Jul 2026 09:49, sashiko-bot wrote: >>Thank you for your contribution! Sashiko AI review found 2 potential issue(= >>s) to consider: >> >>New issues: >>- [Low] Incompatible pointer type causing build failure >> >>Pre-existing issues: >>- [Critical] Sysfs read triggers NULL pointer dereference via uninitialized= >> hwmon_dev >>-- >> >>--- Patch [1]: [PATCH v2] hwmon: (lm90) Switch channel parsing to fwnode AP= >>Is --- >>commit 3d5d792e5529b3545ccefc21f7dfd9c2acecc999 >>Author: Flaviu Nistor >> >>hwmon: (lm90) Switch channel parsing to fwnode APIs >> =20 >>This commit replaces OF property handling with fwnode APIs in the probe >>function to read channel properties. This improves compatibility by no long= >>er >>limiting it to Device Tree. >> >>Link: https://lore.kernel.org/all/20260713190659.4511-1-flaviu.nistor@gmail= >>.com/ >> >>> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c >>> index 4b9c0ccdf2609..7d4b8e61bec51 100644 >>> --- a/drivers/hwmon/lm90.c >>> +++ b/drivers/hwmon/lm90.c >>[ ... ] >>> @@ -2701,27 +2701,27 @@ static int lm90_probe_channel_from_dt(struct i2c_= >>client *client, >>[ ... ] >>> -=09err =3D of_property_read_s32(child, "temperature-offset-millicelsius"= >>>, &val); >>> +=09err =3D fwnode_property_read_u32(child, "temperature-offset-millicels= >>ius", &val); >> >>[Severity: Low] >>Will this cause a build failure or compiler warning? >> >>In lm90_probe_channel(), val is declared as an s32, but it is being passed >>to fwnode_property_read_u32() which expects a u32 pointer. This pointer typ= >>e >>mismatch can trigger a -Wincompatible-pointer-types error in modern builds. > >This is absolutely true and I can't understand how this got into the patch since >I have test is. I will send a v3 correcting s32 to u32. >Sorry for this! > >Best regards, >Flaviu > I have double checked and there is no warning or error when building the driver. Please ignore my previews reply as v2 can be used. I had in mind something different and it looks like not a great morning start. I am sorry for the noise on the mailing list. Best regards, Flaviu