From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82FF0C44514 for ; Fri, 17 Jul 2026 08:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T9IS9Al3mIFXCOw2Id0142/2nl4qoGYh7PELtVIi8Ec=; b=IGB/k90DJjttJm RsX3LRTBxJWJQUjk2KVKr8cNASHpgWad42O2qJSlBW4fhOgYtPrKkoEWoAB3xihOaDYiixTVX47Qx o34GmF/lfAHwiZKxFZxSviAw4yfIL4lky3WMh4X+TkJK271oZByucqUAbry6gDXUDZoqMTGUnc+Rz nYnqOLADdTj/p7/0NQN/eXvdTu2q4wvwRYl5KuUE/aEW3xO7IDNeYmxiR+oqWKUd7o43mXAPzZC2B mwDu9nvxaOr1U54naSBG1k3rJUYU163bEIX23DDCwZXLlK5spB3SHb38Zd2rYt/aQgdaQGykHoDT4 BBuowXFXtnSa0FA3d9ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkdge-00000001aV7-0XQj; Fri, 17 Jul 2026 08:12:48 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkdgc-00000001aUe-0xQw for linux-amlogic@lists.infradead.org; Fri, 17 Jul 2026 08:12:46 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 597EA60204; Fri, 17 Jul 2026 08:12:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D79571F000E9; Fri, 17 Jul 2026 08:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784275964; bh=ncSEbtpoGrxwz8CdKqVbIe93famOhvKCm2NkfVjTcgM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=O6lWPGY1bQw9TjHq7ueeNXHiqy724AoEo+vMYAkEIPErmSFd1vIE+WLXoGtG/TZjf 6GY5dOuuag7ZF5ZVC66sks8rxKK/dkGP0OQRauQw5IcQavE2ktl1f5IwEYC9C3aUqE 7q/eMCUuHDHrJ9pvFd0Azi/jZoaTerLV+iNqtkmF1AksPlz/cxdsuDB3C7zfnsp85z w9G3p2LVB+BaOHFe+XBegGBj5cRl5Vxs+sEvU+UGs/7yjPLd/IMQtYjwWLxPV1cUlL JxDF+d/tDTCzDDFXSix8ukKzGIdm72sUc80SaBHM6PkOTEVSurXQSZNeuQZTvGE8DG 10M+97nsx1SWw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 02/12] crypto: amlogic - Remove redundant dev_err() To: "Pan Chuang" Cc: neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260717080045.191538-3-panchuang@vivo.com> References: <20260717080045.191538-1-panchuang@vivo.com> <20260717080045.191538-3-panchuang@vivo.com> Date: Fri, 17 Jul 2026 08:12:43 +0000 Message-Id: <20260717081243.D79571F000E9@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBJUlFzIGFyZSByZXF1ZXN0ZWQgdmlhIGRldm1fcmVxdWVzdF9pcnEgYmVmb3JlIHRo ZSBkZXZpY2UgY2xvY2sgaXMgZW5hYmxlZCBhbmQgdGhlIGNoYW5uZWwgbGlzdCBpcyBhbGxvY2F0 ZWQuCi0gW0hpZ2hdIFRoZSBkcml2ZXIgbW9kaWZpZXMgYSBzaGFyZWQgc3RhdGljIGdsb2JhbCBh cnJheSBvZiBhbGdvcml0aG0gdGVtcGxhdGVzIGR1cmluZyBwcm9iZSwgcHJldmVudGluZyBtdWx0 aXBsZSBkZXZpY2UgaW5zdGFuY2VzIGFuZCBjb3JydXB0aW5nIGNyeXB0byBBUEkgc3RhdGUuCi0g W0hpZ2hdIERNQSBtYXBwaW5ncyBhcmUgbGVha2VkIGluIGBtZXNvbl9jaXBoZXJgIHdoZW4gc2Nh dHRlcmxpc3QgbWFwcGluZyBmYWlscyBvciBleGNlZWRzIHRoZSBtYXhpbXVtIGRlc2NyaXB0b3Ig Y291bnQuCi0gW01lZGl1bV0gVGhlIElSUSBoYW5kbGVyIHVuY29uZGl0aW9uYWxseSByZXR1cm5z IElSUV9IQU5ETEVEIGV2ZW4gZm9yIHNwdXJpb3VzIGludGVycnVwdHMuCi0tCgotLS0gUGF0Y2gg WzJdOiBbUEFUQ0ggMDIvMTJdIGNyeXB0bzogYW1sb2dpYyAtIFJlbW92ZSByZWR1bmRhbnQgZGV2 X2VycigpIC0tLQpjb21taXQgODJjNTAwMmQyYTAwMjhhMjFlMjY4OGRkMjEwNmU0ZDQxMDQ4N2Y5 ZQpBdXRob3I6IFBhbiBDaHVhbmcgPHBhbmNodWFuZ0B2aXZvLmNvbT4KCmNyeXB0bzogYW1sb2dp YyAtIFJlbW92ZSByZWR1bmRhbnQgZGV2X2VycigpCgpTaW5jZSBjb21taXQgNTViNDhlMjNmNWM0 ICgiZ2VuaXJxL2RldnJlczogQWRkIGVycm9yIGhhbmRsaW5nIGluCmRldm1fcmVxdWVzdF8qX2ly cSgpIiksIGRldm1fcmVxdWVzdF9pcnEoKSBhdXRvbWF0aWNhbGx5IGxvZ3MKZGV0YWlsZWQgZXJy b3IgbWVzc2FnZXMgb24gZmFpbHVyZS4gUmVtb3ZlIHRoZSBub3ctcmVkdW5kYW50CmRyaXZlci1z cGVjaWZpYyBkZXZfZXJyKCkgY2FsbHMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NyeXB0by9h bWxvZ2ljL2FtbG9naWMtZ3hsLWNvcmUuYyBiL2RyaXZlcnMvY3J5cHRvL2FtbG9naWMvYW1sb2dp Yy1neGwtY29yZS5jCj4gaW5kZXggNmNiMzM5NDk5MTVmZS4uMTY5YzZlZWI1MWU1MSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2NyeXB0by9hbWxvZ2ljL2FtbG9naWMtZ3hsLWNvcmUuYwo+ICsrKyBi L2RyaXZlcnMvY3J5cHRvL2FtbG9naWMvYW1sb2dpYy1neGwtY29yZS5jCj4gQEAgLTI1NywxMCAr MjU3LDggQEAgc3RhdGljIGludCBtZXNvbl9jcnlwdG9fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiAgCj4gIAkJZXJyID0gZGV2bV9yZXF1ZXN0X2lycSgmcGRldi0+ZGV2LCBt Yy0+aXJxc1tpXSwgbWVzb25faXJxX2hhbmRsZXIsIDAsCj4gIAkJCQkgICAgICAgImd4bC1jcnlw dG8iLCBtYyk7Cj4gLQkJaWYgKGVyciA8IDApIHsKPiAtCQkJZGV2X2VycihtYy0+ZGV2LCAiQ2Fu bm90IHJlcXVlc3QgSVJRIGZvciBmbG93ICVkXG4iLCBpKTsKPiArCQlpZiAoZXJyIDwgMCkKPiAg CQkJcmV0dXJuIGVycjsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBp c3N1ZSwgYnV0IGRvZXMgcmVxdWVzdGluZyB0aGUgaW50ZXJydXB0IGF0IHRoaXMgcG9pbnQKcmlz ayBhIGNyYXNoIGlmIGFuIGludGVycnVwdCBmaXJlcyBpbW1lZGlhdGVseT8KCklmIGFuIGludGVy cnVwdCBmaXJlcyBiZXR3ZWVuIGRldm1fcmVxdWVzdF9pcnEoKSBhbmQgdGhlIHN1YnNlcXVlbnQg Y2FsbHMgdG8KY2xrX3ByZXBhcmVfZW5hYmxlKCkgb3IgbWVzb25fYWxsb2NhdGVfY2hhbmxpc3Qo KSwgdGhlIGhhbmRsZXIgd2lsbCBydW4gYmVmb3JlCnJlc291cmNlcyBhcmUgaW5pdGlhbGl6ZWQu CgpJbiBkcml2ZXJzL2NyeXB0by9hbWxvZ2ljL2FtbG9naWMtZ3hsLWNvcmUuYzptZXNvbl9pcnFf aGFuZGxlcigpOgoKICAgIHAgPSByZWFkbChtYy0+YmFzZSArICgoMHgwNCArIGZsb3cpIDw8IDIp KTsKICAgIGlmIChwKSB7CiAgICAgICAgd3JpdGVsX3JlbGF4ZWQoMHhGLCBtYy0+YmFzZSArICgo MHg0ICsgZmxvdykgPDwgMikpOwogICAgICAgIG1jLT5jaGFubGlzdFtmbG93XS5zdGF0dXMgPSAx OwoKVGhlIGhhbmRsZXIgcGVyZm9ybXMgYSByZWFkbCgpIG9uIHVuY2xvY2tlZCBkZXZpY2UgcmVn aXN0ZXJzLCB3aGljaCBjYW4gY2F1c2UKYSBzeW5jaHJvbm91cyBleHRlcm5hbCBhYm9ydCBvciBi dXMgaGFuZy4gSXQgYWxzbyBhY2Nlc3NlcyBtYy0+Y2hhbmxpc3QKd2l0aG91dCBjaGVja2luZyBp ZiBpdCBpcyBhbGxvY2F0ZWQsIHdoaWNoIGNvdWxkIGNhdXNlIGEgbnVsbCBwb2ludGVyCmRlcmVm ZXJlbmNlLgoKW1NldmVyaXR5OiBNZWRpdW1dClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUs IGJ1dCBkb2VzIG1lc29uX2lycV9oYW5kbGVyKCkgdW5jb25kaXRpb25hbGx5CnJldHVybiBJUlFf SEFORExFRCBldmVuIGZvciBzcHVyaW91cyBpbnRlcnJ1cHRzPwoKTG9va2luZyBhdCBkcml2ZXJz L2NyeXB0by9hbWxvZ2ljL2FtbG9naWMtZ3hsLWNvcmUuYzptZXNvbl9pcnFfaGFuZGxlcigpOgoK ICAgIGRldl9lcnIobWMtPmRldiwgIiVzICVkIGZyb20gdW5rbm93biBpcnFcbiIsIF9fZnVuY19f LCBpcnEpOwogICAgcmV0dXJuIElSUV9IQU5ETEVEOwoKSWYgYW4gdW5oYW5kbGVkIGludGVycnVw dCBvY2N1cnMsIHJldHVybmluZyBJUlFfSEFORExFRCBwcmV2ZW50cyB0aGUgY29yZQppbnRlcnJ1 cHQgc3Vic3lzdGVtJ3MgIm5vYm9keSBjYXJlZCIgbG9naWMgZnJvbSBkaXNhYmxpbmcgYSBzdHVj ayBpbnRlcnJ1cHQKbGluZS4gQ291bGQgdGhpcyByZXN1bHQgaW4gYW4gaW50ZXJydXB0IHN0b3Jt IGxvY2tpbmcgdXAgYSBwcm9jZXNzb3IgaWYgdGhlCmhhcmR3YXJlIG1hbGZ1bmN0aW9ucz8KCj4g LQkJfQo+ICAJfQo+ICAKPiAgCWVyciA9IGNsa19wcmVwYXJlX2VuYWJsZShtYy0+YnVzY2xrKTsK CltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IGRvZXMg dGhlIGRyaXZlciBtb2RpZnkgYSBzaGFyZWQgc3RhdGljCmdsb2JhbCBhcnJheSBkdXJpbmcgcHJv YmU/CgpMb29raW5nIGF0IG1lc29uX3JlZ2lzdGVyX2FsZ3MoKSB3aGljaCBpcyBjYWxsZWQgc2hv cnRseSBhZnRlciBpbgptZXNvbl9jcnlwdG9fcHJvYmUoKToKCkluIGRyaXZlcnMvY3J5cHRvL2Ft bG9naWMvYW1sb2dpYy1neGwtY29yZS5jOm1lc29uX3JlZ2lzdGVyX2FsZ3MoKToKCiAgICBtY19h bGdzW2ldLm1jID0gbWM7CiAgICBzd2l0Y2ggKG1jX2FsZ3NbaV0udHlwZSkgewogICAgY2FzZSBD UllQVE9fQUxHX1RZUEVfU0tDSVBIRVI6CiAgICAgICAgZXJyID0gY3J5cHRvX2VuZ2luZV9yZWdp c3Rlcl9za2NpcGhlcigmbWNfYWxnc1tpXS5hbGcuc2tjaXBoZXIpOwoKTW9kaWZ5aW5nIHRoZSBz aGFyZWQgZ2xvYmFsIHN0YXRpYyBhcnJheSBtY19hbGdzIHdpdGggZGV2aWNlLXNwZWNpZmljIHBv aW50ZXJzCnByZXZlbnRzIG11bHRpcGxlIGRldmljZSBpbnN0YW5jZXMgZnJvbSBmdW5jdGlvbmlu ZyBjb3JyZWN0bHkuIFByb2JpbmcgbXVsdGlwbGUKaW5zdGFuY2VzIG9yIHVuYmluZGluZyBhbmQg cmViaW5kaW5nIHRoZSBkZXZpY2Ugd2lsbCBtdXRhdGUgdGhpcyBzaGFyZWQgc3RhdGUsCndoaWNo IG1pZ2h0IGNvcnJ1cHQgdGhlIGxpbmtlZCBsaXN0cyB3aXRoaW4gdGhlIGtlcm5lbCdzIGNyeXB0 byBzdWJzeXN0ZW0uCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNz dWUsIGJ1dCBkb2VzIG1lc29uX2NpcGhlcigpIGxlYWsgZGlyZWN0IG1lbW9yeSBhY2Nlc3MKbWFw cGluZ3Mgd2hlbiBzY2F0dGVybGlzdCBtYXBwaW5nIGZhaWxzPwoKSW4gZHJpdmVycy9jcnlwdG8v YW1sb2dpYy9hbWxvZ2ljLWd4bC1jaXBoZXIuYzptZXNvbl9jaXBoZXIoKToKCiAgICBpZiAoIW5y X3NncyB8fCBucl9zZ3MgPiBNQVhERVNDIC0gMykgewogICAgICAgIGRldl9lcnIobWMtPmRldiwg IkludmFsaWQgU0cgY291bnQgJWRcbiIsIG5yX3Nncyk7CiAgICAgICAgZXJyID0gLUVJTlZBTDsK ICAgICAgICBnb3RvIHRoZWVuZDsKICAgIH0KCkFuZCBpbiB0aGUgZXJyb3IgcGF0aDoKCiAgICB0 aGVlbmQ6CiAgICAgICAga2ZyZWVfc2Vuc2l0aXZlKGJrZXlpdik7CiAgICAgICAga2ZyZWVfc2Vu c2l0aXZlKGJhY2t1cF9pdik7CgogICAgICAgIHJldHVybiBlcnI7CgpUaGUgZXJyb3IgcGF0aCBm cmVlcyBtZW1vcnkgYnV0IGRvZXMgbm90IGNhbGwgZG1hX3VubWFwX3NpbmdsZSgpIGZvciB0aGUK cHJldmlvdXNseSBtYXBwZWQgcGh5a2V5aXYsIG5vciBkbWFfdW5tYXBfc2coKSBmb3IgdGhlIGFs cmVhZHkgbWFwcGVkCmFyZXEtPnNyYy4gQ2FuIHRoaXMgcGVybWFuZW50bHkgbGVhayBtYXBwaW5n IHJlc291cmNlcyB1bnRpbCBleGhhdXN0aW9uIGlmCmZyYWdtZW50ZWQgc2NhdHRlcmxpc3RzIGFy ZSBzdWJtaXR0ZWQ/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRl di8jL3BhdGNoc2V0LzIwMjYwNzE3MDgwMDQ1LjE5MTUzOC0xLXBhbmNodWFuZ0B2aXZvLmNvbT9w YXJ0PTIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9n aWMK