All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Cui <cui.tao@linux.dev>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, tj@kernel.org, yukuai@kernel.org,
	yangxiuwei@kylinos.cn, cui.tao@linux.dev, cuitao@kylinos.cn
Subject: [PATCH] blk-cgroup: remove unused blk_queue_for_each_rl stub
Date: Fri, 17 Jul 2026 18:20:49 +0800	[thread overview]
Message-ID: <20260717102049.2080768-1-cui.tao@linux.dev> (raw)

From: Tao Cui <cuitao@kylinos.cn>

blk_queue_for_each_rl() was added by commit a051661ca6d1 ("blkcg:
implement per-blkg request allocation") to iterate over the root request
list and per-blkg request lists for the legacy (non-blk-mq) request
allocation path.  The request_list code, including q->root_rl from
struct request_queue, was later removed in 2018 by commit db6d99523560
("block: remove request_list code").

The macro definition left behind in the !CONFIG_BLK_CGROUP fallback
branch of the private block/blk-cgroup.h header now references the
removed q->root_rl field, and has no callers in-tree (it would fail to
compile if expanded, so it cannot have any out-of-tree users either).

Remove the dead stub.

Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
 block/blk-cgroup.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
index 615390f751aa..6a309d2d3db5 100644
--- a/block/blk-cgroup.h
+++ b/block/blk-cgroup.h
@@ -500,9 +500,6 @@ static inline void blkg_put(struct blkcg_gq *blkg) { }
 static inline void blk_cgroup_bio_start(struct bio *bio) { }
 static inline bool blk_cgroup_mergeable(struct request *rq, struct bio *bio) { return true; }
 
-#define blk_queue_for_each_rl(rl, q)	\
-	for ((rl) = &(q)->root_rl; (rl); (rl) = NULL)
-
 #endif	/* CONFIG_BLK_CGROUP */
 
 #endif /* _BLK_CGROUP_PRIVATE_H */
-- 
2.43.0


                 reply	other threads:[~2026-07-17 10:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717102049.2080768-1-cui.tao@linux.dev \
    --to=cui.tao@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=cuitao@kylinos.cn \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yangxiuwei@kylinos.cn \
    --cc=yukuai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.