From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2102F3E959C for ; Fri, 17 Jul 2026 10:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284303; cv=none; b=tsKNSHhGQTm6dxsIGpDKwuku8X7knRB7rbd8f7swbpfObxtSkD+/1v99rE4r5Yd03VlbavTPpKYGtpFeCoFiakBNdij/BLAOBTTXY4y8mrwdvsDvBTAudTji5WixK6xjYiqV+2csJTf1NaZTGtl/+Ril1wCieOtQtZalChjorDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784284303; c=relaxed/simple; bh=jRvVYLWkAvqbd8w6jhsQ9DKjqT6FMQdZj7A1oNvnvNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gvh4WNN5CD+CgQQhpyvF9oyQ3q3Cw79E2p0PK5hYwXQ5GEHqg02EvI+k77HrxclrOvprqzGEm//AS0pKeRvNwdgAuP62QJGso4/+l8axZouYZ/jgUHb+JEUYzLfH5sKa0MiRm/WbORQoREDrWzitX1DkIPrsufmTzclwTMnYSKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=c0oikjKz; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="c0oikjKz" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784284298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ao7C6ooGb0afah8XWkrSWPprX9tUe0ryJDO7SNjWk4Y=; b=c0oikjKz0K+OEm7GYkUYKuw1K6yiAXHPckJTpiWQNikEbhMvbAcUxnFuSauXUv3o7lzeMP IZR1Yqhg0RAIwnDLh3bvzkmqVWn1qs453wRGupMHA9hFqA9cz7cBvkxtFxW0d5RBWn0A2+ KxE2urdyVRXPsgwlpXD54O2gfmzuHIk= From: Hongfu Li To: ljs@kernel.org Cc: akpm@linux-foundation.org, david@kernel.org, hongfu.li@linux.dev, liam@infradead.org, lihongfu@kylinos.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Date: Fri, 17 Jul 2026 18:31:13 +0800 Message-ID: <20260717103113.95239-1-hongfu.li@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT > > From: Hongfu Li > > > > unlock_page(), end_page_writeback() and wait_on_page_writeback() > > are void wrappers forwarding to folio-based functions which also > > return void. Explicit return statements here are syntactically valid > > but unnecessary, and inconsistent with other nearby compat helpers > > such as mark_page_accessed() and set_page_writeback(). > > > > Drop all these superfluous return keywords. > > > > Signed-off-by: Hongfu Li > > LGTM so: > > Reviewed-by: Lorenzo Stoakes (ARM) > > I would ask that you maybe slow down on the flow of patches lately :) review is > pretty overwhelmed atm. Sorry about the heavy patch stream recently. I'll space out my patch submissions to reduce review pressure. Really appreciate your time and careful review. Best regards, Hongfu