From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9E317C220 for ; Fri, 17 Jul 2026 12:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784290616; cv=none; b=MiLpEnKoA0TLJBK2PoQBMrV3QgTUAyU0T1T6yPDyR89Y78H4ZIMxfHHyV6d28qbInE21WMtgUVx2g43CNPDpdTtCfWkH69DIogN11WyrPdfuxbMMLspUvpMqNjra4gKF1o3LCtuZLe2DQszKRw4XCS4EhmSlW+d7chFuamY4iLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784290616; c=relaxed/simple; bh=toiSGxYzYXi6MLKYbCPyVjrqAPQGxpl0SlBfu5hVE3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=astgLfG4yj/bNO1n7lhSRT1gJJhb6d+NphnW+rvVmhjir5jK6lFVKoMeELUoESVFey7m9wN+F0II6m80PFRCi5pm6jv1CuBMB6B/e/WTH7wW9C3yS0JV1Sh6oDe310/z/p4mVWSFWbPWu1totaC/1IsG3FJX4SJoDI9lYgS2k8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=s3ffDdch; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="s3ffDdch" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493f6de72faso11022555e9.0 for ; Fri, 17 Jul 2026 05:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1784290612; x=1784895412; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lck7mvbc7eYTVs8kX/2ICJBoonP7+T15i+odIB/wu+4=; b=s3ffDdch+SFP1GsXqU87g9BHn10jlgsl+G5JEaK/o4FQgLPww0OsZXPdXjM/sur+gN EQgSyNXynFR5blrkC/tMShv90rR7vS5RnyNEU2ZG3GGhzjQXuKHQPiQhmePPnCLCF1h4 4u62WTLaE0Xu9L+yM8Y80aOgUfxdtTs3UgvYkJgQzHSipY3NDb5hHw8jPLr3qgslRhzy Whk/AmOhEmauJBGnXeqZNRK2Zw8XxsuyE/0Mv8YE4JikwwMSYGWnhJVE4PmNHdXx7ye8 FzPzsIS2cV0Bgkr3XIWorik18OZqIX1IikVAjIsWxwBG17N3PVEvKmPvkmFAuMisUQiy zXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784290612; x=1784895412; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lck7mvbc7eYTVs8kX/2ICJBoonP7+T15i+odIB/wu+4=; b=NLJHOPzgywIIdevESY9rkeTJ7uRPwTdDAWb/GAzRKTCIgqYlVlDkI099Ar0e5tLA9J NolBp+p8vk3qe04+6TGpuWmEYNmdDHIOIQp1t5NdwIfjnxzfch4HXX/qUPoxuEM7zmJ0 z7mks54IHBZKaU6olcI70Xu/dW2U1PV7qyN95yP0HLOjlQCzo/4aK3qZK9H/wdtOdNSK R7XWM/3wn/kaMTxq8X04r1z6aecnRq42UiXbF46NhHzlJUVPkpnQ5YAyO+L9cg2sbWw7 tjzd1Y8eI7Vb45xE49WKbcAZA7ctawkmTRWmdSzhLWV7cZxspxenlTV6+OGhtc/Fpu91 Md7w== X-Forwarded-Encrypted: i=1; AHgh+RopSWfBU6Xb4Hna3kAZZqjpI7yJ7fBHEbwdTfME2hbAon5KA3EZ6ekq+Tg2ke0HJ0wP3EOMQqN9Ci4D4fo=@vger.kernel.org X-Gm-Message-State: AOJu0YxEvRB08ylf5n4y5dQ9K4pqVYsUlU2tI2VqToPbGJ/9lmWe1Upf Gzk/f8duk90/0szQTFjbUZdKksdUTTi9MP/0qWKYZXu+T7lhToEIXeFQxN/BJOaztxU= X-Gm-Gg: AfdE7cl4QvmfCHZo/ZjnEL5pF3L1v4FnEG7tMQkCbUJ3rLzk33kZy5BT7Q4K00f3+Py Cn9aLA+7NyvtpisIfZk6lSwcOYrlD8wXjbP7jNIDfLnKrzhAYARM5mdqeUSS9Z0nz/vU93Ly2SS KVy3VqZYqN5AoWWY1VbSb1CrlFnovWFHisC0hjQLsWAv5UWpvFABm3pl4Wpdmhp1zJxIsCtdBi2 IN4R0ybXLb3ENMvZeHNzXUNXEp/5OaNVx2M1TW2aEkdMcTNNbTpm+6oVZjQgWaskpy7TdMj4h/L 31Yj+/427deEEDSWJDQHiB+lZE793Jc+urJZdtmLjbPbWbVXqjopOxsyeGSpJUEcQH1XsIyc9om d/VC4PiB3j6ibltVr4Pv/o903NSnlImq80RySvhAL1rcVObmHf2grPyCQAF/R2vKHT8TGPCYDin w6LaIEAB/jkWW+SISXJdcB X-Received: by 2002:a05:600c:a48:b0:492:6f5c:fd8c with SMTP id 5b1f17b1804b1-4954a33dd95mr24670235e9.15.1784290611451; Fri, 17 Jul 2026 05:16:51 -0700 (PDT) Received: from localhost ([2a02:8071:6401:180:d892:bf43:a0b4:83b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2b074csm45198355e9.6.2026.07.17.05.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 05:16:50 -0700 (PDT) Date: Fri, 17 Jul 2026 14:16:45 +0200 From: Johannes Weiner To: Ridong Cc: Andrew Morton , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH 2/3] mm: vmscan: propagate real error code from per-node proactive reclaim Message-ID: <20260717121645.GD6843@cmpxchg.org> References: <20260717113300.214717-1-ridong.chen@linux.dev> <20260717113300.214717-3-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717113300.214717-3-ridong.chen@linux.dev> On Fri, Jul 17, 2026 at 07:32:59PM +0800, Ridong wrote: > From: Ridong Chen > > It has been observed that per-node proactive reclaim always returns > -EAGAIN when any error occurs. As discussed in the mailing list [1], > the interface should distinguish between cases where no reclaimable > memory is left and where another entity is concurrently using the > same interface. Propagate the real error code, consistent with how > memcg proactive reclaim handles errors. > > [1] https://lore.kernel.org/all/20250717235604.2atyx2aobwowpge3@offworld/T/#m3514718be82a31b05726a49da9b61fbfc69a589e > > Fixes: b980077899ea ("mm: introduce per-node proactive reclaim interface") > Signed-off-by: Ridong Chen Acked-by: Johannes Weiner