From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210A963CB for ; Fri, 17 Jul 2026 12:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784290664; cv=none; b=a/ebiJXZka4TmXnpcvNQhOrLAcTOBHePsMZYVUHLkWC1XP+vde276fCAc1pXvF1Y7ykQJZB8Vr6jsfH1uqJzRC3u7eQdN/0o6tqCRbmNqaVhnOxJlcBnjIRpv+B+Bz8/nuNGbAf4RSuyRc+Y0bI1Zt6hkMWeb/EzndsxQA3vmNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784290664; c=relaxed/simple; bh=U0WAJj8cTp6qyTcYHJyoOA4GsmqlMVA0Ig7rcXd2U+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lju/gUxyd3WyZO3RcP0kpgjhp6F12LCpqZwBOsT/2gxte7i0gsSqumbV/G3G+HCjBJmDjIABehIuBYKd2DNw9M3tM8VBuUTyC2xAczPbulyiniExm1vKP1ZyP7fgtu5UHIorknDXGFy9aMCU4FnJeqWjc1CMGVO7g+9N4Z3EOc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=X7dYcl3R; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="X7dYcl3R" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-47f365afc5aso3428452f8f.0 for ; Fri, 17 Jul 2026 05:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1784290660; x=1784895460; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SodxN+jfsIGxYmyP0i3Gg8E/VNQFrjgtEwk/0lVmN+M=; b=X7dYcl3RGjyh8T3PoYIVnkr5U2qoiqGMCbG4Nmbbk9o8fKA2BcA8SxP0gVWEkrRyqm Z8lpC5Sfueu8OstkjUl8d+YV2nGlKj8XPP1mYY7IVMgypJoZ1RmVMvZ8FEyKtersTjy7 yCMHytOTms1blTWzaUpVRMYCeOSGuDfHBCdUuHelYHa2l4qzqTPejDd6JhKLSSd8UUzF gYYxOLTjXe3G/2vM8+z1iUosdAMGRV9baFoFsYEOLb56RVe3e6Q84gm9l940pvZ5f6gE IBeV/UvO4sAX3rMoPsGs3KbJb/WvbpnjFxfOBgGXDR/pxnwDK0cL8UYUkARFMwBrL1jb 2a2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784290660; x=1784895460; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SodxN+jfsIGxYmyP0i3Gg8E/VNQFrjgtEwk/0lVmN+M=; b=SdHq7LTydn4wdsq0Kqoj6nMmVKFFH7oHLFijzHVJsBzpzZveCOX0gcAcuQNpqNvVxG FMlOh1ANn1fxpB+AaaBZHXH8dIwsGiRPuNZsnO5SJGmUJfXmdC+SXD3i7Ygb/lwKA9rM WeU0ot3uQoxrSSkzi9RsVdEn1bAMn37h5KJPTOEMwW94QfSbHCemnWonoZFhKyMCbZHv FA7gemVR4oENLBfDtOIYp8wnGn+SOy6jYKh7HCDZtTgCip532rCGelaEg5A35lNoI+lZ W6HNaWTkldLFWCfjzPL23TLYxXkidvMZ9LX92j/jdZVbsOw+GZjPvTRoCKOg7GLZtUzX ff6w== X-Forwarded-Encrypted: i=1; AHgh+RrhsujwkHBxK3wrrMzGMTisXya76nf89GfLGA26CdSNS0oVcXoX2Qojan9Mk5I4pRMCJBl1jRlLOspbgfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwttvrpYOPh/sd5nHgbuiSV1cBW23wlJN2mdMR3baX2Yef+PVL1 GS3w3G97TGln5n7kV9k/oQSvZbNKVVpOpxa6AULDFRmiKPiVyyAXY4j6h+zvs0F5l2E= X-Gm-Gg: AfdE7cnu8AahCF1k/SIf3SH9cu9fHIY8grUVZd2EE5WoETvR4oVeVBzm6VNeysSalxA R9n+VsnEhwroRvy/IsJ9w8ZePJl7ku4zgJPVahTmqn33ELmnFrs4kOJ9hgWZcdKu63KlusdJyU9 b1VWI9DnU96OcwWO+nedLcwk5QQgDfdld7dN7VQHvAqQA6YvTp28ZlYJWjFx6M6GMSG0Wnku1iP PI2DDhXOzcYtuNrJmggBH3+c5JGGcNtHTdInrhliydN7TalsN2ZDV+KPcIKY8JyCajcvonOcl6f 46tuRuNTuMcBMyebv8loLUVzAFupNraFjlryNxiX9VMqoN3RV67JWEuOg8l6d4bpUNLddyd64Pk Tc9Zd1P0wGVfK7DYSTzF4MmmLpUh1NxwG+pEKabKLKrVO3woDGgvrYxbogosh80CuySPj41OSVt o= X-Received: by 2002:a5d:5d84:0:b0:47f:56f7:7a57 with SMTP id ffacd0b85a97d-47f6232c4abmr3338983f8f.28.1784290659814; Fri, 17 Jul 2026 05:17:39 -0700 (PDT) Received: from localhost ([2a02:8071:6401:180:d892:bf43:a0b4:83b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ee926dsm3054661f8f.35.2026.07.17.05.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 05:17:38 -0700 (PDT) Date: Fri, 17 Jul 2026 14:17:37 +0200 From: Johannes Weiner To: Ridong Cc: Andrew Morton , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH 3/3] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() Message-ID: <20260717121737.GE6843@cmpxchg.org> References: <20260717113300.214717-1-ridong.chen@linux.dev> <20260717113300.214717-4-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717113300.214717-4-ridong.chen@linux.dev> On Fri, Jul 17, 2026 at 07:33:00PM +0800, Ridong wrote: > From: Ridong Chen > > Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic") > moved the scan_control construction out to the callers and passed the > struct in by pointer. After that change every use of the gfp mask inside > __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter > unused. Just remove the dead parameter and update the callers accordingly. > No functional change. > > Signed-off-by: Ridong Chen Acked-by: Johannes Weiner