Re: [PATCH v5 10/56] scsi: qla2xxx: Add extended status continuation and marker IOCBs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Commit Message and Implementation Mismatch
- [Low] Architectural Inconsistency in Header Placement
--

--- Patch [10]: [PATCH v5 10/56] scsi: qla2xxx: Add extended status continuation and marker IOCBs ---
commit 1df9414084849f00c05087b262dc690e15f3cf79
Author: Anil Gurumurthy <agurumurthy@marvell.com>

scsi: qla2xxx: Add extended status continuation and marker IOCBs

This commit adds a 128-byte status continuation entry structure for 29xx
firmware and includes the new qla_fw29.h header. The commit message also notes
the addition of a marker IOCB.

>     Add the 128-byte sts_cont_entry_ext_t and mrk_entry_ext_t
>     structures required by 29xx firmware.

[Severity: Medium]
Is this commit message accurate for the provided code changes?

The diff only introduces struct sts_cont_entry_ext without the _t typedef
convention, and entirely omits the mrk_entry_ext_t marker entry structure.
It appears the marker structure was added in an earlier patch under a
different name.

> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index 7423687578dc9..4de0de5cccc8d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h

[ ... ]

> @@ -2360,6 +2361,15 @@ typedef struct {
>  	uint8_t reserved_2[48];
>  } mrk_entry_t;
>  
> +/* 29xx definitions */
> +struct sts_cont_entry_ext {

[Severity: Low]
Should this 128-byte IOCB definition be placed in qla_fw29.h instead of
qla_def.h?

The qla_fw29.h header was recently created specifically to hold new 128-byte
IOCB definitions for 29xx and isolate them from earlier generations. Placing
sts_cont_entry_ext in the generic header seems to bypass the dedicated
firmware header.

> +	uint8_t entry_type;		/* Entry type. */
> +	uint8_t entry_count;		/* Entry count. */
> +	uint8_t sys_define;		/* System defined. */
> +	uint8_t entry_status;		/* Entry Status. */
> +	uint8_t data[124];		/* data */
> +};
> +
>  /*
>   * ISP queue - Management Server entry structure definition.
>   */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717152904.3155730-1-njavali@marvell.com?part=10